Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
On Wed, Aug 7, 2019 at 3:50 PM Numan Siddique wrote: > > > On Wed, Aug 7, 2019 at 4:59 PM Damijan Skvarc > wrote: > >> Within this function actions & match dynamic strings are used as helper >> variables for adding entries into logical flow table. Variables are >> used several times in order to optimize number of memory allocations, >> however at the end memory was forgotten to be deallocated. >> >> Signed-off-by: Damijan Skvarc >> > > Hi Damijan, > > This patch is already applied to ovn master repo a couple of days back - > https://github.com/ovn-org/ovn/commit/c1ba3f68a78af3b852aa5709a0d96f001b63b243 > Sorry, my mistake, I have incorrectly resent the same leftover artifact file. > > Would you please submit the patch to OVS branch 2.12 so that it can be > backported (with the subject prefix - "branch 2.12") > I've already tried, but 0-day robot refused it, complaining about not having Mark Michelson in a list of authors... ( https://mail.openvswitch.org/pipermail/ovs-dev/2019-August/361326.html). Also branch 2.12 token was not specified in a subject. I'll retry once more... > Thanks > Numan > > > >> --- >> northd/ovn-northd.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c >> index 979dea4..8588961 100644 >> --- a/northd/ovn-northd.c >> +++ b/northd/ovn-northd.c >> @@ -5667,6 +5667,8 @@ add_distributed_nat_routes(struct hmap *lflows, >> const struct ovn_port *op) >> ds_clear(); >> } >> } >> +ds_destroy(); >> +ds_destroy(); >> } >> >> static void >> -- >> 2.7.4 >> >> ___ >> dev mailing list >> d...@openvswitch.org >> https://mail.openvswitch.org/mailman/listinfo/ovs-dev >> > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
On Wed, Aug 7, 2019 at 4:59 PM Damijan Skvarc wrote: > Within this function actions & match dynamic strings are used as helper > variables for adding entries into logical flow table. Variables are > used several times in order to optimize number of memory allocations, > however at the end memory was forgotten to be deallocated. > > Signed-off-by: Damijan Skvarc > Hi Damijan, This patch is already applied to ovn master repo a couple of days back - https://github.com/ovn-org/ovn/commit/c1ba3f68a78af3b852aa5709a0d96f001b63b243 Would you please submit the patch to OVS branch 2.12 so that it can be backported (with the subject prefix - "branch 2.12") Thanks Numan > --- > northd/ovn-northd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > index 979dea4..8588961 100644 > --- a/northd/ovn-northd.c > +++ b/northd/ovn-northd.c > @@ -5667,6 +5667,8 @@ add_distributed_nat_routes(struct hmap *lflows, > const struct ovn_port *op) > ds_clear(); > } > } > +ds_destroy(); > +ds_destroy(); > } > > static void > -- > 2.7.4 > > ___ > dev mailing list > d...@openvswitch.org > https://mail.openvswitch.org/mailman/listinfo/ovs-dev > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (northd/ovn-northd.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 ovn-northd: fix memory leak in add_distributed_nat_routes() function The copy of the patch that failed is found in: /var/lib/jenkins/jobs/upstream_build_from_pw/workspace/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan Skvarc --- northd/ovn-northd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 979dea4..8588961 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -5667,6 +5667,8 @@ add_distributed_nat_routes(struct hmap *lflows, const struct ovn_port *op) ds_clear(); } } +ds_destroy(); +ds_destroy(); } static void -- 2.7.4 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Unexpected sign-offs from developers who are not authors or co-authors or committers: Mark Michelson Lines checked: 33, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
Done! Thanks for review. On Wed, Jul 31, 2019 at 6:40 PM Mark Michelson wrote: > I've pushed this to OVN master. Damijan, could you post a backport patch > for OVS 2.12, please? Thanks! > > On 7/31/19 9:17 AM, Mark Michelson wrote: > > Thanks for the fix! > > Acked-by: Mark Michelson > > > > This will need a backport to the OVS 2.12 branch as well. > > > > On 7/31/19 6:43 AM, Damijan Skvarc wrote: > >> Within this function actions & match dynamic strings are used as helper > >> variables for adding entries into logical flow table. Variables are > >> used several times in order to optimize number of memory allocations, > >> however at the end memory was forgotten to be deallocated. > >> > >> Signed-off-by: Damijan Skvarc > >> --- > >> northd/ovn-northd.c | 2 ++ > >> 1 file changed, 2 insertions(+) > >> > >> diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c > >> index 979dea4..8588961 100644 > >> --- a/northd/ovn-northd.c > >> +++ b/northd/ovn-northd.c > >> @@ -5667,6 +5667,8 @@ add_distributed_nat_routes(struct hmap *lflows, > >> const struct ovn_port *op) > >> ds_clear(); > >> } > >> } > >> +ds_destroy(); > >> +ds_destroy(); > >> } > >> static void > >> > > > > ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan Skvarc Acked-by: Mark Michelson Signed-off-by: Mark Michelson --- ovn/northd/ovn-northd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index ae09cf3..95b9570 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@ -5717,6 +5717,8 @@ add_distributed_nat_routes(struct hmap *lflows, const struct ovn_port *op) ds_clear(); } } +ds_destroy(); +ds_destroy(); } static void -- 2.7.4 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (northd/ovn-northd.c). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 ovn-northd: fix memory leak in add_distributed_nat_routes() function The copy of the patch that failed is found in: /var/lib/jenkins/jobs/upstream_build_from_pw/workspace/.git/rebase-apply/patch When you have resolved this problem, run "git am --resolved". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Please check this out. If you feel there has been an error, please email acon...@bytheb.org Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
I've pushed this to OVN master. Damijan, could you post a backport patch for OVS 2.12, please? Thanks! On 7/31/19 9:17 AM, Mark Michelson wrote: Thanks for the fix! Acked-by: Mark Michelson This will need a backport to the OVS 2.12 branch as well. On 7/31/19 6:43 AM, Damijan Skvarc wrote: Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan Skvarc --- northd/ovn-northd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 979dea4..8588961 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -5667,6 +5667,8 @@ add_distributed_nat_routes(struct hmap *lflows, const struct ovn_port *op) ds_clear(); } } + ds_destroy(); + ds_destroy(); } static void ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
Thanks for the fix! Acked-by: Mark Michelson This will need a backport to the OVS 2.12 branch as well. On 7/31/19 6:43 AM, Damijan Skvarc wrote: Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan Skvarc --- northd/ovn-northd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 979dea4..8588961 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -5667,6 +5667,8 @@ add_distributed_nat_routes(struct hmap *lflows, const struct ovn_port *op) ds_clear(); } } +ds_destroy(); +ds_destroy(); } static void ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH 1/1] ovn-northd: fix memory leak in add_distributed_nat_routes() function
Within this function actions & match dynamic strings are used as helper variables for adding entries into logical flow table. Variables are used several times in order to optimize number of memory allocations, however at the end memory was forgotten to be deallocated. Signed-off-by: Damijan Skvarc --- northd/ovn-northd.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/northd/ovn-northd.c b/northd/ovn-northd.c index 979dea4..8588961 100644 --- a/northd/ovn-northd.c +++ b/northd/ovn-northd.c @@ -5667,6 +5667,8 @@ add_distributed_nat_routes(struct hmap *lflows, const struct ovn_port *op) ds_clear(); } } +ds_destroy(); +ds_destroy(); } static void -- 2.7.4 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
