Re: [ovs-dev] [PATCH 1/4] ofproto-dpif-xlate: Fix bad memory free.

2017-10-30 Thread Ben Pfaff
On Mon, Oct 30, 2017 at 10:27:52AM -0700, William Tu wrote: > Clang reports possibly bad free of 'ofm' when it comes from the stack > instead of malloc because Clang is not able to verify whether the previous > if condition 'ctx->xin->xcache' still hold the same. Fix it by > adding additional cond

[ovs-dev] [PATCH 1/4] ofproto-dpif-xlate: Fix bad memory free.

2017-10-30 Thread William Tu
Clang reports possibly bad free of 'ofm' when it comes from the stack instead of malloc because Clang is not able to verify whether the previous if condition 'ctx->xin->xcache' still hold the same. Fix it by adding additional condition. Signed-off-by: William Tu --- ofproto/ofproto-dpif-xlate.c