Re: [ovs-dev] [PATCH 10/10] conntrack: Validate accessing of conntrack data in pkt_metadata

2019-09-17 Thread William Tu
On Wed, Sep 11, 2019 at 02:18:36PM -0700, Yifeng Sun wrote: > Valgrind reported: > > 1305: ofproto-dpif - conntrack - ipv6 > > ==26942== Conditional jump or move depends on uninitialised value(s) > ==26942==at 0x587C00: check_orig_tuple (conntrack.c:1006) > ==26942==by 0x587C00: process_o

Re: [ovs-dev] [PATCH 10/10] conntrack: Validate accessing of conntrack data in pkt_metadata

2019-09-11 Thread 0-day Robot
Bleep bloop. Greetings Yifeng Sun, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 80 characters long (recommended limit is 79) #93 FILE: lib/conntrack.c:1142:

[ovs-dev] [PATCH 10/10] conntrack: Validate accessing of conntrack data in pkt_metadata

2019-09-11 Thread Yifeng Sun
Valgrind reported: 1305: ofproto-dpif - conntrack - ipv6 ==26942== Conditional jump or move depends on uninitialised value(s) ==26942==at 0x587C00: check_orig_tuple (conntrack.c:1006) ==26942==by 0x587C00: process_one (conntrack.c:1141) ==26942==by 0x587C00: conntrack_execute (conntra