Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-06 Thread William Tu
On Fri, Sep 6, 2019 at 1:14 AM Eelco Chaudron wrote: > > > > On 5 Sep 2019, at 18:21, William Tu wrote: > > >> Did some more testing and with PVP I see a performance decrease, with > >> physical to physical I see an increase. > >> Tests are performed with a port redirect open flow rule on an

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-06 Thread Eelco Chaudron
On 5 Sep 2019, at 18:21, William Tu wrote: Did some more testing and with PVP I see a performance decrease, with physical to physical I see an increase. Tests are performed with a port redirect open flow rule on an ixgbe (Xeon E5-2690 v4 2.60GHz):

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-05 Thread William Tu
On Wed, Sep 4, 2019 at 7:10 AM Ilya Maximets wrote: > > > Hi Eelco, > > > > Thanks for your testing and review. > > > > On Wed, Sep 4, 2019 at 1:04 AM Eelco Chaudron > > wrote: > >> > >> > >> > >> On 27 Aug 2019, at 1:02, William Tu wrote: > >> > >> > The patch adds support for using

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-05 Thread William Tu
> Did some more testing and with PVP I see a performance decrease, with > physical to physical I see an increase. > Tests are performed with a port redirect open flow rule on an ixgbe > (Xeon E5-2690 v4 2.60GHz): > >

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-04 Thread William Tu
On Wed, Sep 4, 2019 at 7:27 AM Ilya Maximets wrote: > > On 04.09.2019 17:04, William Tu wrote: > > Hi Ilya, > > > > Thanks for the feedback. > > > > On Wed, Sep 4, 2019 at 5:19 AM Ilya Maximets wrote: > >> > >> Hi William, > >> > >> Thanks for the patch! > >> One general comment is that we,

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-04 Thread Ilya Maximets
On 04.09.2019 17:04, William Tu wrote: > Hi Ilya, > > Thanks for the feedback. > > On Wed, Sep 4, 2019 at 5:19 AM Ilya Maximets wrote: >> >> Hi William, >> >> Thanks for the patch! >> One general comment is that we, probably, should make this feature >> configurable. There are 2 reasons: >> >>

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-04 Thread Ilya Maximets
> Hi Eelco, > > Thanks for your testing and review. > > On Wed, Sep 4, 2019 at 1:04 AM Eelco Chaudron wrote: >> >> >> >> On 27 Aug 2019, at 1:02, William Tu wrote: >> >> > The patch adds support for using need_wakeup flag in AF_XDP rings. >> > When this flag is used, it means that OVS has to

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-04 Thread William Tu
Hi Ilya, Thanks for the feedback. On Wed, Sep 4, 2019 at 5:19 AM Ilya Maximets wrote: > > Hi William, > > Thanks for the patch! > One general comment is that we, probably, should make this feature > configurable. There are 2 reasons: > > 1. We might want to run OVS on older kernel while

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-04 Thread William Tu
Hi Eelco, Thanks for your testing and review. On Wed, Sep 4, 2019 at 1:04 AM Eelco Chaudron wrote: > > > > On 27 Aug 2019, at 1:02, William Tu wrote: > > > The patch adds support for using need_wakeup flag in AF_XDP rings. > > When this flag is used, it means that OVS has to explicitly wake > >

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-04 Thread Ilya Maximets
Hi William, Thanks for the patch! One general comment is that we, probably, should make this feature configurable. There are 2 reasons: 1. We might want to run OVS on older kernel while building with more recent libbpf. In this case socket creation will fail due to unsupported flag and

Re: [ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-09-04 Thread Eelco Chaudron
On 27 Aug 2019, at 1:02, William Tu wrote: The patch adds support for using need_wakeup flag in AF_XDP rings. When this flag is used, it means that OVS has to explicitly wake up the kernel RX, using poll() syscall and wake up TX, using sendto() syscall. This feature improves the performance

[ovs-dev] [PATCH 2/2] netdev-afxdp: Add need_wakeup supprt.

2019-08-26 Thread William Tu
The patch adds support for using need_wakeup flag in AF_XDP rings. When this flag is used, it means that OVS has to explicitly wake up the kernel RX, using poll() syscall and wake up TX, using sendto() syscall. This feature improves the performance by avoiding unnecessary syscalls, so keeping more