Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-23 Thread Jakub Sitnicki
On Thu, 22 Feb 2018 18:07:55 +0100 Jakub Sitnicki wrote: > On Wed, Feb 14, 2018 at 09:54 PM GMT, Ben Pfaff wrote: [...] > > +uint32_t > > +sbrec_logical_flow_hash(const struct sbrec_logical_flow *lf) > > +{ > > +const struct sbrec_datapath_binding *ld = lf->logical_datapath; > > +if (!l

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-22 Thread Jakub Sitnicki
Hi Ben, On Wed, Feb 14, 2018 at 09:54 PM GMT, Ben Pfaff wrote: > Jakub Sitnicki demonstrated that repeatedly calculating row hashes is > expensive, so this should improve ovn-northd performance. > > Reported-by: Jakub Sitnicki > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2018-

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-21 Thread Numan Siddique
On Thu, Feb 22, 2018 at 4:49 AM, Mark Michelson wrote: > Hi, > > While testing an unrelated change in OVS master (using make sandbox > SANDBOXFLAGS="--ovn"), I noticed that my laptop was making way more noise > than normal. Looking at `top` output, an ovsdb-server process was running > at 100% CP

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-21 Thread Mark Michelson
Hi, While testing an unrelated change in OVS master (using make sandbox SANDBOXFLAGS="--ovn"), I noticed that my laptop was making way more noise than normal. Looking at `top` output, an ovsdb-server process was running at 100% CPU, ovn-controller was running at 75% CPU, and ovn-northd was ru

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-20 Thread Numan Siddique
On Tue, Feb 20, 2018 at 7:39 PM, Lorenzo Bianconi < lorenzo.bianc...@redhat.com> wrote: > > On Fri, Feb 16, 2018 at 05:10:29PM +0100, Jakub Sitnicki wrote: > >> Ben, > >> > >> On Wed, Feb 14, 2018 at 09:54 PM GMT, Ben Pfaff wrote: > >> > Jakub Sitnicki demonstrated that repeatedly calculating row

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-20 Thread Lorenzo Bianconi
> On Fri, Feb 16, 2018 at 05:10:29PM +0100, Jakub Sitnicki wrote: >> Ben, >> >> On Wed, Feb 14, 2018 at 09:54 PM GMT, Ben Pfaff wrote: >> > Jakub Sitnicki demonstrated that repeatedly calculating row hashes is >> > expensive, so this should improve ovn-northd performance. >> > >> > Reported-by: Jak

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-16 Thread Ben Pfaff
On Fri, Feb 16, 2018 at 05:10:29PM +0100, Jakub Sitnicki wrote: > Ben, > > On Wed, Feb 14, 2018 at 09:54 PM GMT, Ben Pfaff wrote: > > Jakub Sitnicki demonstrated that repeatedly calculating row hashes is > > expensive, so this should improve ovn-northd performance. > > > > Reported-by: Jakub Sitni

Re: [ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-16 Thread Jakub Sitnicki
Ben, On Wed, Feb 14, 2018 at 09:54 PM GMT, Ben Pfaff wrote: > Jakub Sitnicki demonstrated that repeatedly calculating row hashes is > expensive, so this should improve ovn-northd performance. > > Reported-by: Jakub Sitnicki > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2018-Feb

[ovs-dev] [PATCH 4/4] ovn-northd: Reduce amount of flow hashing.

2018-02-14 Thread Ben Pfaff
Jakub Sitnicki demonstrated that repeatedly calculating row hashes is expensive, so this should improve ovn-northd performance. Reported-by: Jakub Sitnicki Reported-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-February/344404.html Signed-off-by: Ben Pfaff --- ovn/lib/ovn-sb-idl.ann