subject:"\[ovs\-dev\] \[PATCH V2\] OF1.5\/EXT\-334 OXS\/Extensible Flow Entry Statistics Support"

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-02-02 Thread Ben Pfaff

I'm not going to change the established semantics of dump-flows, but I
want a patch that applies and doesn't break tests before I provide any
more detailed feedback.

On Fri, Feb 02, 2018 at 04:00:44PM +, Jan Scheurich wrote:
> Hi Ben,
> 
> I would appreciate if you could comment on my general concerns with this 
> patch.
> 
> I think it is unwise to sacrifice the semantics of the established ovs-ofctl 
> dump-flow command just in order to align the CLI commands with the particular 
> re-arrangement of  multipart requests messages in OpenFlow 1.5.
> 
> There is no need for one-to-one correspondence between ovs-ofctl commands and 
> underlying OF message types. Especially not if these change between OF 
> versions. The CLI commands should have a well-defined stable semantics and 
> use whatever message is appropriate for the OF protocol version in question 
> to implement that.
> 
> Thanks, Jan
> 
> > -Original Message-
> > From: Ben Pfaff [mailto:b...@ovn.org]
> > Sent: Friday, 02 February, 2018 16:52
> > To: Satyavalli Rama <satyavalli.r...@tcs.com>
> > Cc: SatyaValli <satyavalli.r...@gmail.com>; d...@openvswitch.org; 
> > manasa.cherukupa...@tcs.com; p.pava...@tcs.com; Harivelam
> > Lavanya <harivelam.lava...@tcs.com>; muttamsetty.su...@tcs.com; Jan 
> > Scheurich <jan.scheur...@ericsson.com>
> > Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> > Statistics Support
> > 
> > Please start by rebasing and reposting.
> > 
> > On Fri, Feb 02, 2018 at 06:04:49PM +0530, Satyavalli Rama wrote:
> > > Hi Ben,
> > >
> > > We didn't observed any test case breaks and we've updated the same with 
> > > logs in our previous conversations.
> > > Could you please provide your inputs regarding the Jan's comments about 
> > > command syntax modifications.
> > >
> > > Thanks & Regards
> > > Satya Valli
> > > Tata Consultancy Services
> > > Mailto: satyavalli.r...@tcs.com
> > > Website: http://www.tcs.com
> > > 
> > > Experience certainty. IT Services
> > > Business Solutions
> > > Consulting
> > > 
> > >
> > >
> > > -Ben Pfaff <b...@ovn.org> wrote: -
> > > To: Satyavalli Rama <satyavalli.r...@tcs.com>
> > > From: Ben Pfaff <b...@ovn.org>
> > > Date: 02/02/2018 03:43AM
> > > Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
> > > <d...@openvswitch.org>, manasa.cherukupa...@tcs.com,
> > p.pava...@tcs.com, Harivelam Lavanya <harivelam.lava...@tcs.com>, 
> > muttamsetty.su...@tcs.com, Jan Scheurich
> > <jan.scheur...@ericsson.com>
> > > Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> > > Statistics Support
> > >
> > > At the very minimum I can't review a patch that breaks tests.
> > >
> > > On Wed, Jan 31, 2018 at 05:29:12PM +0530, Satyavalli Rama wrote:
> > > > Hi Ben,
> > > >
> > > > Are you also agreeing with the Jan's comments.
> > > >
> > > > Thanks & Regards
> > > > Satya Valli
> > > > Tata Consultancy Services
> > > > Mailto: satyavalli.r...@tcs.com
> > > > Website: http://www.tcs.com
> > > > 
> > > > Experience certainty.   IT Services
> > > > Business Solutions
> > > > Consulting
> > > > ____________
> > > >
> > > >
> > > > -Jan Scheurich <jan.scheur...@ericsson.com> wrote: -
> > > > To: Satyavalli Rama <satyavalli.r...@tcs.com>, Ben Pfaff <b...@ovn.org>
> > > > From: Jan Scheurich <jan.scheur...@ericsson.com>
> > > > Date: 01/08/2018 06:31PM
> > > > Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
> > > > <d...@openvswitch.org>, "manasa.cherukupa...@tcs.com"
> > <manasa.cherukupa...@tcs.com>, "p.pava...@tcs.com" <p.pava...@tcs.com>, 
> > Harivelam Lavanya <harivelam.lava...@tcs.com>,
> > "muttamsetty.su...@tcs.com" <muttamsetty.su...@tcs.com>
> > > > Subject: RE: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow 
> > > > Entry Statistics Support
> > > >
> > > > Hi Satyavalli,
> >

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-02-02 Thread Jan Scheurich

Hi Ben,

I would appreciate if you could comment on my general concerns with this patch.

I think it is unwise to sacrifice the semantics of the established ovs-ofctl 
dump-flow command just in order to align the CLI commands with the particular 
re-arrangement of  multipart requests messages in OpenFlow 1.5.

There is no need for one-to-one correspondence between ovs-ofctl commands and 
underlying OF message types. Especially not if these change between OF 
versions. The CLI commands should have a well-defined stable semantics and use 
whatever message is appropriate for the OF protocol version in question to 
implement that.

Thanks, Jan

> -Original Message-
> From: Ben Pfaff [mailto:b...@ovn.org]
> Sent: Friday, 02 February, 2018 16:52
> To: Satyavalli Rama <satyavalli.r...@tcs.com>
> Cc: SatyaValli <satyavalli.r...@gmail.com>; d...@openvswitch.org; 
> manasa.cherukupa...@tcs.com; p.pava...@tcs.com; Harivelam
> Lavanya <harivelam.lava...@tcs.com>; muttamsetty.su...@tcs.com; Jan Scheurich 
> <jan.scheur...@ericsson.com>
> Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> Statistics Support
> 
> Please start by rebasing and reposting.
> 
> On Fri, Feb 02, 2018 at 06:04:49PM +0530, Satyavalli Rama wrote:
> > Hi Ben,
> >
> > We didn't observed any test case breaks and we've updated the same with 
> > logs in our previous conversations.
> > Could you please provide your inputs regarding the Jan's comments about 
> > command syntax modifications.
> >
> > Thanks & Regards
> > Satya Valli
> > Tata Consultancy Services
> > Mailto: satyavalli.r...@tcs.com
> > Website: http://www.tcs.com
> > 
> > Experience certainty.   IT Services
> > Business Solutions
> > Consulting
> > 
> >
> >
> > -Ben Pfaff <b...@ovn.org> wrote: -
> > To: Satyavalli Rama <satyavalli.r...@tcs.com>
> > From: Ben Pfaff <b...@ovn.org>
> > Date: 02/02/2018 03:43AM
> > Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
> > <d...@openvswitch.org>, manasa.cherukupa...@tcs.com,
> p.pava...@tcs.com, Harivelam Lavanya <harivelam.lava...@tcs.com>, 
> muttamsetty.su...@tcs.com, Jan Scheurich
> <jan.scheur...@ericsson.com>
> > Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> > Statistics Support
> >
> > At the very minimum I can't review a patch that breaks tests.
> >
> > On Wed, Jan 31, 2018 at 05:29:12PM +0530, Satyavalli Rama wrote:
> > > Hi Ben,
> > >
> > > Are you also agreeing with the Jan's comments.
> > >
> > > Thanks & Regards
> > > Satya Valli
> > > Tata Consultancy Services
> > > Mailto: satyavalli.r...@tcs.com
> > > Website: http://www.tcs.com
> > > 
> > > Experience certainty. IT Services
> > > Business Solutions
> > > Consulting
> > > 
> > >
> > >
> > > -Jan Scheurich <jan.scheur...@ericsson.com> wrote: -
> > > To: Satyavalli Rama <satyavalli.r...@tcs.com>, Ben Pfaff <b...@ovn.org>
> > > From: Jan Scheurich <jan.scheur...@ericsson.com>
> > > Date: 01/08/2018 06:31PM
> > > Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
> > > <d...@openvswitch.org>, "manasa.cherukupa...@tcs.com"
> <manasa.cherukupa...@tcs.com>, "p.pava...@tcs.com" <p.pava...@tcs.com>, 
> Harivelam Lavanya <harivelam.lava...@tcs.com>,
> "muttamsetty.su...@tcs.com" <muttamsetty.su...@tcs.com>
> > > Subject: RE: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> > > Statistics Support
> > >
> > > Hi Satyavalli,
> > >
> > > Please find my responses below.
> > >
> > > Regards, Jan
> > >
> > > From: Satyavalli Rama [mailto:satyavalli.r...@tcs.com]
> > > Sent: Friday, 05 January, 2018 12:25
> > > To: Ben Pfaff <b...@ovn.org>; Jan Scheurich <jan.scheur...@ericsson.com>
> > > Cc: SatyaValli <satyavalli.r...@gmail.com>; d...@openvswitch.org; 
> > > manasa.cherukupa...@tcs.com; p.pava...@tcs.com; Harivelam
> Lavanya <harivelam.lava...@tcs.com>; muttamsetty.su...@tcs.com
> > > Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> > > Statistics Support
> > >
&g

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-02-02 Thread Ben Pfaff

Please start by rebasing and reposting.

On Fri, Feb 02, 2018 at 06:04:49PM +0530, Satyavalli Rama wrote:
> Hi Ben,
> 
> We didn't observed any test case breaks and we've updated the same with logs 
> in our previous conversations.
> Could you please provide your inputs regarding the Jan's comments about 
> command syntax modifications.
> 
> Thanks & Regards
> Satya Valli
> Tata Consultancy Services
> Mailto: satyavalli.r...@tcs.com
> Website: http://www.tcs.com
> 
> Experience certainty. IT Services
> Business Solutions
> Consulting
> 
> 
> 
> -Ben Pfaff <b...@ovn.org> wrote: -
> To: Satyavalli Rama <satyavalli.r...@tcs.com>
> From: Ben Pfaff <b...@ovn.org>
> Date: 02/02/2018 03:43AM
> Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
> <d...@openvswitch.org>, manasa.cherukupa...@tcs.com, p.pava...@tcs.com, 
> Harivelam Lavanya <harivelam.lava...@tcs.com>, muttamsetty.su...@tcs.com, Jan 
> Scheurich <jan.scheur...@ericsson.com>
> Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> Statistics Support
> 
> At the very minimum I can't review a patch that breaks tests.
> 
> On Wed, Jan 31, 2018 at 05:29:12PM +0530, Satyavalli Rama wrote:
> > Hi Ben,
> > 
> > Are you also agreeing with the Jan's comments.
> > 
> > Thanks & Regards
> > Satya Valli
> > Tata Consultancy Services
> > Mailto: satyavalli.r...@tcs.com
> > Website: http://www.tcs.com
> > 
> > Experience certainty.   IT Services
> > Business Solutions
> > Consulting
> > 
> > 
> > 
> > -Jan Scheurich <jan.scheur...@ericsson.com> wrote: -
> > To: Satyavalli Rama <satyavalli.r...@tcs.com>, Ben Pfaff <b...@ovn.org>
> > From: Jan Scheurich <jan.scheur...@ericsson.com>
> > Date: 01/08/2018 06:31PM
> > Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
> > <d...@openvswitch.org>, "manasa.cherukupa...@tcs.com" 
> > <manasa.cherukupa...@tcs.com>, "p.pava...@tcs.com" <p.pava...@tcs.com>, 
> > Harivelam Lavanya <harivelam.lava...@tcs.com>, "muttamsetty.su...@tcs.com" 
> > <muttamsetty.su...@tcs.com>
> > Subject: RE: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> > Statistics Support
> > 
> > Hi Satyavalli,
> >  
> > Please find my responses below.
> >  
> > Regards, Jan
> >  
> > From: Satyavalli Rama [mailto:satyavalli.r...@tcs.com] 
> > Sent: Friday, 05 January, 2018 12:25
> > To: Ben Pfaff <b...@ovn.org>; Jan Scheurich <jan.scheur...@ericsson.com>
> > Cc: SatyaValli <satyavalli.r...@gmail.com>; d...@openvswitch.org; 
> > manasa.cherukupa...@tcs.com; p.pava...@tcs.com; Harivelam Lavanya 
> > <harivelam.lava...@tcs.com>; muttamsetty.su...@tcs.com
> > Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> > Statistics Support
> >  
> > Hi Jan and Ben,
> >  
> > Please find the inline responses.
> >  
> > 
> > -Ben Pfaff <b...@ovn.org> wrote: -
> > To: Jan Scheurich <jan.scheur...@ericsson.com>
> > From: Ben Pfaff <b...@ovn.org>
> > Date: 01/05/2018 02:35AM
> > Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
> > <d...@openvswitch.org>, Manasa Cherukupally <manasa.cherukupa...@tcs.com>, 
> > Pavani Panthagada <p.pava...@tcs.com>, Lavanya Harivelam 
> > <harivelam.lava...@tcs.com>, Surya Muttamsetty <muttamsetty.su...@tcs.com>, 
> > SatyaValli <satyavalli.r...@tcs.com>
> > Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> > Statistics Support
> > 
> > On Wed, Jan 03, 2018 at 04:24:06PM +, Jan Scheurich wrote:
> > > > > >
> > > > > > This Patch provides implementation Existing flow entry statistics 
> > > > > > are
> > > > > > redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> > > > > > displaying the arbitrary flow stats.The existing Flow Stats were 
> > > > > > renamed
> > > > > > as Flow Description.
> > > > > >
> > > > > > To support this implementation below messages are newly added
> > > > > >
> > > >

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-02-02 Thread Satyavalli Rama

Hi Ben,

We didn't observed any test case breaks and we've updated the same with logs in 
our previous conversations.
Could you please provide your inputs regarding the Jan's comments about command 
syntax modifications.

Thanks & Regards
Satya Valli
Tata Consultancy Services
Mailto: satyavalli.r...@tcs.com
Website: http://www.tcs.com

Experience certainty.   IT Services
Business Solutions
Consulting



-Ben Pfaff <b...@ovn.org> wrote: -
To: Satyavalli Rama <satyavalli.r...@tcs.com>
From: Ben Pfaff <b...@ovn.org>
Date: 02/02/2018 03:43AM
Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
<d...@openvswitch.org>, manasa.cherukupa...@tcs.com, p.pava...@tcs.com, 
Harivelam Lavanya <harivelam.lava...@tcs.com>, muttamsetty.su...@tcs.com, Jan 
Scheurich <jan.scheur...@ericsson.com>
Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
Statistics Support

At the very minimum I can't review a patch that breaks tests.

On Wed, Jan 31, 2018 at 05:29:12PM +0530, Satyavalli Rama wrote:
> Hi Ben,
> 
> Are you also agreeing with the Jan's comments.
> 
> Thanks & Regards
> Satya Valli
> Tata Consultancy Services
> Mailto: satyavalli.r...@tcs.com
> Website: http://www.tcs.com
> 
> Experience certainty. IT Services
> Business Solutions
> Consulting
> 
> 
> 
> -Jan Scheurich <jan.scheur...@ericsson.com> wrote: -
> To: Satyavalli Rama <satyavalli.r...@tcs.com>, Ben Pfaff <b...@ovn.org>
> From: Jan Scheurich <jan.scheur...@ericsson.com>
> Date: 01/08/2018 06:31PM
> Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
> <d...@openvswitch.org>, "manasa.cherukupa...@tcs.com" 
> <manasa.cherukupa...@tcs.com>, "p.pava...@tcs.com" <p.pava...@tcs.com>, 
> Harivelam Lavanya <harivelam.lava...@tcs.com>, "muttamsetty.su...@tcs.com" 
> <muttamsetty.su...@tcs.com>
> Subject: RE: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> Statistics Support
> 
> Hi Satyavalli,
>  
> Please find my responses below.
>  
> Regards, Jan
>  
> From: Satyavalli Rama [mailto:satyavalli.r...@tcs.com] 
> Sent: Friday, 05 January, 2018 12:25
> To: Ben Pfaff <b...@ovn.org>; Jan Scheurich <jan.scheur...@ericsson.com>
> Cc: SatyaValli <satyavalli.r...@gmail.com>; d...@openvswitch.org; 
> manasa.cherukupa...@tcs.com; p.pava...@tcs.com; Harivelam Lavanya 
> <harivelam.lava...@tcs.com>; muttamsetty.su...@tcs.com
> Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> Statistics Support
>  
> Hi Jan and Ben,
>  
> Please find the inline responses.
>  
> 
> -Ben Pfaff <b...@ovn.org> wrote: -
> To: Jan Scheurich <jan.scheur...@ericsson.com>
> From: Ben Pfaff <b...@ovn.org>
> Date: 01/05/2018 02:35AM
> Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
> <d...@openvswitch.org>, Manasa Cherukupally <manasa.cherukupa...@tcs.com>, 
> Pavani Panthagada <p.pava...@tcs.com>, Lavanya Harivelam 
> <harivelam.lava...@tcs.com>, Surya Muttamsetty <muttamsetty.su...@tcs.com>, 
> SatyaValli <satyavalli.r...@tcs.com>
> Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> Statistics Support
> 
> On Wed, Jan 03, 2018 at 04:24:06PM +, Jan Scheurich wrote:
> > > > >
> > > > > This Patch provides implementation Existing flow entry statistics are
> > > > > redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> > > > > displaying the arbitrary flow stats.The existing Flow Stats were 
> > > > > renamed
> > > > > as Flow Description.
> > > > >
> > > > > To support this implementation below messages are newly added
> > > > >
> > > > > OFPRAW_OFPT15_FLOW_REMOVED,
> > > > > OFPRAW_OFPST15_FLOW_REQUEST,
> > > > > OFPRAW_OFPST15_FLOW_DESC_REQUEST,
> > > > > OFPRAW_OFPST15_AGGREGATE_REQUEST,
> > > > > OFPRAW_OFPST15_FLOW_REPLY,
> > > > > OFPRAW_OFPST15_FLOW_DESC_REPLY,
> > > > > OFPRAW_OFPST15_AGGREGATE_REPLY,
> > > > >
> > > > > The current commit adds support for the new feature in flow statistics
> > > > > multipart messages,aggregate multipart messages and OXS support for 
> > > > > flow
> > > > >

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-01-08 Thread Jan Scheurich

Hi Satyavalli,

Please find my responses below.

Regards, Jan

From: Satyavalli Rama [mailto:satyavalli.r...@tcs.com]
Sent: Friday, 05 January, 2018 12:25
To: Ben Pfaff <b...@ovn.org>; Jan Scheurich <jan.scheur...@ericsson.com>
Cc: SatyaValli <satyavalli.r...@gmail.com>; d...@openvswitch.org; 
manasa.cherukupa...@tcs.com; p.pava...@tcs.com; Harivelam Lavanya 
<harivelam.lava...@tcs.com>; muttamsetty.su...@tcs.com
Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
Statistics Support

Hi Jan and Ben,

Please find the inline responses.


-Ben Pfaff <b...@ovn.org<mailto:b...@ovn.org>> wrote: -
To: Jan Scheurich 
<jan.scheur...@ericsson.com<mailto:jan.scheur...@ericsson.com>>
From: Ben Pfaff <b...@ovn.org<mailto:b...@ovn.org>>
Date: 01/05/2018 02:35AM
Cc: SatyaValli <satyavalli.r...@gmail.com<mailto:satyavalli.r...@gmail.com>>, 
"d...@openvswitch.org<mailto:d...@openvswitch.org>" 
<d...@openvswitch.org<mailto:d...@openvswitch.org>>, Manasa Cherukupally 
<manasa.cherukupa...@tcs.com<mailto:manasa.cherukupa...@tcs.com>>, Pavani 
Panthagada <p.pava...@tcs.com<mailto:p.pava...@tcs.com>>, Lavanya Harivelam 
<harivelam.lava...@tcs.com<mailto:harivelam.lava...@tcs.com>>, Surya 
Muttamsetty <muttamsetty.su...@tcs.com<mailto:muttamsetty.su...@tcs.com>>, 
SatyaValli <satyavalli.r...@tcs.com<mailto:satyavalli.r...@tcs.com>>
Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
Statistics Support
On Wed, Jan 03, 2018 at 04:24:06PM +, Jan Scheurich wrote:
> > > >
> > > > This Patch provides implementation Existing flow entry statistics are
> > > > redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> > > > displaying the arbitrary flow stats.The existing Flow Stats were renamed
> > > > as Flow Description.
> > > >
> > > > To support this implementation below messages are newly added
> > > >
> > > > OFPRAW_OFPT15_FLOW_REMOVED,
> > > > OFPRAW_OFPST15_FLOW_REQUEST,
> > > > OFPRAW_OFPST15_FLOW_DESC_REQUEST,
> > > > OFPRAW_OFPST15_AGGREGATE_REQUEST,
> > > > OFPRAW_OFPST15_FLOW_REPLY,
> > > > OFPRAW_OFPST15_FLOW_DESC_REPLY,
> > > > OFPRAW_OFPST15_AGGREGATE_REPLY,
> > > >
> > > > The current commit adds support for the new feature in flow statistics
> > > > multipart messages,aggregate multipart messages and OXS support for flow
> > > > removal message, individual flow description messages.
> > > >
> > > > "ovs-ofctl dump-flows" needs to be provided with the arbitrary OXS 
> > > > fields
> > > > for displaying the desired flow stats.
> > > >
> > > > Below are Commands to display OXS stats field wise
> > > >
> > > > Flow Statistics Multipart
> > > > ovs-ofctl dump-flows -O OpenFlow15  idle_time
> > > > ovs-ofctl dump-flows -O OpenFlow15  packet_count
> > > > ovs-ofctl dump-flows -O OpenFlow15  byte_count
> > >
> > > This would break backward compatibility for one of the most frequently 
> > > used OVS CLI commands. Why don't you introduce a new
> > command such as "ovs-ofctl dump-flow-stats" for the new OXS stats?
> >
> > I think you might be misinterpreting the meaning here.  It doesn't
> > appear to break compatibility, at least not in a major way, since it
> > doesn't do a lot of updates to the tests that would otherwise be
> > required.
>
> Perhaps I am missing the point of some of these changes. I understand that 
> OVS needs to support the new extensible OXS flow stats syntax in OpenFlow 1.5 
> and the differentiated MP request/reply pairs OFPMP_FLOW_DESC (replacing the 
> former OFPMP_FLOW) and OFPMP_FLOW_STATS (just fetching flow stats per flow 
> w/o the rest of the flow data).
>
> But I don't understand why this should have any impact on the existing CLI 
> command "ovs-ofctl dump-flows" and its output. This tool expressly fetches 
> and displays the complete flow dump from OVS, including match, 
> instructions/actions and statistics. When using OF 1.5 it should 
> transparently apply OFPMP_FLOW_DESC MP request/reply to fetch the data, up to 
> OF 1.4 it should use the original OFPMP_FLOW.
>
> I can't see any ovs-ofctl use case that would justify the use of the new 
> OFPMP_FLOW_STATS request/reply. The removed data in the reply compared to the 
> full flow description are mainly the instructions, the full match is still 
> there to identify each flow. So cutting down the transfer

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-01-05 Thread Satyavalli Rama

Hi Jan and Ben,

Please find the inline responses.


-Ben Pfaff <b...@ovn.org> wrote: -
To: Jan Scheurich <jan.scheur...@ericsson.com>
From: Ben Pfaff <b...@ovn.org>
Date: 01/05/2018 02:35AM
Cc: SatyaValli <satyavalli.r...@gmail.com>, "d...@openvswitch.org" 
<d...@openvswitch.org>, Manasa Cherukupally <manasa.cherukupa...@tcs.com>, 
Pavani Panthagada <p.pava...@tcs.com>, Lavanya Harivelam 
<harivelam.lava...@tcs.com>, Surya Muttamsetty <muttamsetty.su...@tcs.com>, 
SatyaValli <satyavalli.r...@tcs.com>
Subject: Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
Statistics Support

On Wed, Jan 03, 2018 at 04:24:06PM +, Jan Scheurich wrote:
> > > >
> > > > This Patch provides implementation Existing flow entry statistics are
> > > > redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> > > > displaying the arbitrary flow stats.The existing Flow Stats were renamed
> > > > as Flow Description.
> > > >
> > > > To support this implementation below messages are newly added
> > > >
> > > > OFPRAW_OFPT15_FLOW_REMOVED,
> > > > OFPRAW_OFPST15_FLOW_REQUEST,
> > > > OFPRAW_OFPST15_FLOW_DESC_REQUEST,
> > > > OFPRAW_OFPST15_AGGREGATE_REQUEST,
> > > > OFPRAW_OFPST15_FLOW_REPLY,
> > > > OFPRAW_OFPST15_FLOW_DESC_REPLY,
> > > > OFPRAW_OFPST15_AGGREGATE_REPLY,
> > > >
> > > > The current commit adds support for the new feature in flow statistics
> > > > multipart messages,aggregate multipart messages and OXS support for flow
> > > > removal message, individual flow description messages.
> > > >
> > > > "ovs-ofctl dump-flows" needs to be provided with the arbitrary OXS 
> > > > fields
> > > > for displaying the desired flow stats.
> > > >
> > > > Below are Commands to display OXS stats field wise
> > > >
> > > > Flow Statistics Multipart
> > > > ovs-ofctl dump-flows -O OpenFlow15  idle_time
> > > > ovs-ofctl dump-flows -O OpenFlow15  packet_count
> > > > ovs-ofctl dump-flows -O OpenFlow15  byte_count
> > >
> > > This would break backward compatibility for one of the most frequently 
> > > used OVS CLI commands. Why don't you introduce a new
> > command such as "ovs-ofctl dump-flow-stats" for the new OXS stats?
> > 
> > I think you might be misinterpreting the meaning here.  It doesn't
> > appear to break compatibility, at least not in a major way, since it
> > doesn't do a lot of updates to the tests that would otherwise be
> > required.
> 
> Perhaps I am missing the point of some of these changes. I understand that 
> OVS needs to support the new extensible OXS flow stats syntax in OpenFlow 1.5 
> and the differentiated MP request/reply pairs OFPMP_FLOW_DESC (replacing the 
> former OFPMP_FLOW) and OFPMP_FLOW_STATS (just fetching flow stats per flow 
> w/o the rest of the flow data).
> 
> But I don't understand why this should have any impact on the existing CLI 
> command "ovs-ofctl dump-flows" and its output. This tool expressly fetches 
> and displays the complete flow dump from OVS, including match, 
> instructions/actions and statistics. When using OF 1.5 it should 
> transparently apply OFPMP_FLOW_DESC MP request/reply to fetch the data, up to 
> OF 1.4 it should use the original OFPMP_FLOW.
> 
> I can't see any ovs-ofctl use case that would justify the use of the new 
> OFPMP_FLOW_STATS request/reply. The removed data in the reply compared to the 
> full flow description are mainly the instructions, the full match is still 
> there to identify each flow. So cutting down the transferred data volume can 
> hardly be the reason (Note, this may still be different for real OF 1.5 
> controllers).
> 
> If you believe we should have an ovs-ofctl command anyhow, e.g. for testing 
> purposes, I suggest to introduce a new command or add an option to dump-flows 
> to force use of this particular MP message. The output would be limited to 
> flow match and stats in that case.
> 

As per our understanding and from previous review comments we treated OF1.5+ 
has two different ways to request and get replies for Flow Stats: FLOW_DESC and 
FLOW_STATS (which will be even used for Flow Stats Trigger). And we've 
supported this with the help of two commands

OFPMP_FLOW_DESC - ovs-ofctl dump-flow-desc -O OpenFlow15
OFPMP_FLOW_STATS - ovs-ofctl dump-flows -O OpenFlow15

> The new command to dump aggregate flow stats is of course a welcome addition. 
> It should work irrespectively of the used OpenFlow

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-01-04 Thread Ben Pfaff

On Wed, Jan 03, 2018 at 04:24:06PM +, Jan Scheurich wrote:
> > > >
> > > > This Patch provides implementation Existing flow entry statistics are
> > > > redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> > > > displaying the arbitrary flow stats.The existing Flow Stats were renamed
> > > > as Flow Description.
> > > >
> > > > To support this implementation below messages are newly added
> > > >
> > > > OFPRAW_OFPT15_FLOW_REMOVED,
> > > > OFPRAW_OFPST15_FLOW_REQUEST,
> > > > OFPRAW_OFPST15_FLOW_DESC_REQUEST,
> > > > OFPRAW_OFPST15_AGGREGATE_REQUEST,
> > > > OFPRAW_OFPST15_FLOW_REPLY,
> > > > OFPRAW_OFPST15_FLOW_DESC_REPLY,
> > > > OFPRAW_OFPST15_AGGREGATE_REPLY,
> > > >
> > > > The current commit adds support for the new feature in flow statistics
> > > > multipart messages,aggregate multipart messages and OXS support for flow
> > > > removal message, individual flow description messages.
> > > >
> > > > "ovs-ofctl dump-flows" needs to be provided with the arbitrary OXS 
> > > > fields
> > > > for displaying the desired flow stats.
> > > >
> > > > Below are Commands to display OXS stats field wise
> > > >
> > > > Flow Statistics Multipart
> > > > ovs-ofctl dump-flows -O OpenFlow15  idle_time
> > > > ovs-ofctl dump-flows -O OpenFlow15  packet_count
> > > > ovs-ofctl dump-flows -O OpenFlow15  byte_count
> > >
> > > This would break backward compatibility for one of the most frequently 
> > > used OVS CLI commands. Why don't you introduce a new
> > command such as "ovs-ofctl dump-flow-stats" for the new OXS stats?
> > 
> > I think you might be misinterpreting the meaning here.  It doesn't
> > appear to break compatibility, at least not in a major way, since it
> > doesn't do a lot of updates to the tests that would otherwise be
> > required.
> 
> Perhaps I am missing the point of some of these changes. I understand that 
> OVS needs to support the new extensible OXS flow stats syntax in OpenFlow 1.5 
> and the differentiated MP request/reply pairs OFPMP_FLOW_DESC (replacing the 
> former OFPMP_FLOW) and OFPMP_FLOW_STATS (just fetching flow stats per flow 
> w/o the rest of the flow data).
> 
> But I don't understand why this should have any impact on the existing CLI 
> command "ovs-ofctl dump-flows" and its output. This tool expressly fetches 
> and displays the complete flow dump from OVS, including match, 
> instructions/actions and statistics. When using OF 1.5 it should 
> transparently apply OFPMP_FLOW_DESC MP request/reply to fetch the data, up to 
> OF 1.4 it should use the original OFPMP_FLOW.
> 
> I can't see any ovs-ofctl use case that would justify the use of the new 
> OFPMP_FLOW_STATS request/reply. The removed data in the reply compared to the 
> full flow description are mainly the instructions, the full match is still 
> there to identify each flow. So cutting down the transferred data volume can 
> hardly be the reason (Note, this may still be different for real OF 1.5 
> controllers).
> 
> If you believe we should have an ovs-ofctl command anyhow, e.g. for testing 
> purposes, I suggest to introduce a new command or add an option to dump-flows 
> to force use of this particular MP message. The output would be limited to 
> flow match and stats in that case.
> 
> The new command to dump aggregate flow stats is of course a welcome addition. 
> It should work irrespectively of the used OpenFlow version with the 
> OFPMP_AGGREGATE_STATS primitive using classic flow stats prior to OF 1.5 and 
> OXS flow stats in OF 1.5.
> 
> All in all I am NACK-ing this patch as it stands.
> 
> Regards, Jan
> 
> BTW: I have played a bit with the patch. The existing ovs-ofctl test cases 
> appear to not break because the changes described in the commit message and 
> the documentation are not effective. The legacy command format "ovs-ofctl 
> dump-flows -O OpenFlow15  []" still produces the complete flow 
> dump including instructions/actions:
> 
> # ovs-ofctl -Oopenflow15 dump-flow-desc br0
> OFPST_FLOW_DESC reply (OF1.5) (xid=0x2):
>  cookie=0x0, duration=90.515s, table=0, n_packets=0, n_bytes=0, reset_counts 
> idle_age=840, hard_age=32766, in_port="br0-ns1" actions=output:"br0-ns2"
>  cookie=0x0, duration=90.507s, table=0, n_packets=0, n_bytes=0, reset_counts 
> idle_age=840, hard_age=32766, in_port="br0-ns2" actions=output:"br0-ns1"
>  cookie=0x0, duration=850.125s, table=0, n_packets=2, n_bytes=180, 
> idle_age=849, hard_age=32766, priority=0 actions=NORMAL
> 
> # ovs-ofctl -Oopenflow15 dump-flows br0
>  cookie=0x0, duration=94.634s, table=0, n_packets=0, n_bytes=0, idle_age=844, 
> hard_age=0, in_port="br0-ns1" actions=output:"br0-ns2"
>  cookie=0x0, duration=94.626s, table=0, n_packets=0, n_bytes=0, idle_age=844, 
> hard_age=0, in_port="br0-ns2" actions=output:"br0-ns1"
>  cookie=0x0, duration=854.244s, table=0, n_packets=2, n_bytes=180, 
> idle_age=853, hard_age=0, priority=0 actions=NORMAL
> 
> The only difference appears to be that the flow property reset_counts is 
> missing

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-01-03 Thread Jan Scheurich

> > >
> > > This Patch provides implementation Existing flow entry statistics are
> > > redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> > > displaying the arbitrary flow stats.The existing Flow Stats were renamed
> > > as Flow Description.
> > >
> > > To support this implementation below messages are newly added
> > >
> > > OFPRAW_OFPT15_FLOW_REMOVED,
> > > OFPRAW_OFPST15_FLOW_REQUEST,
> > > OFPRAW_OFPST15_FLOW_DESC_REQUEST,
> > > OFPRAW_OFPST15_AGGREGATE_REQUEST,
> > > OFPRAW_OFPST15_FLOW_REPLY,
> > > OFPRAW_OFPST15_FLOW_DESC_REPLY,
> > > OFPRAW_OFPST15_AGGREGATE_REPLY,
> > >
> > > The current commit adds support for the new feature in flow statistics
> > > multipart messages,aggregate multipart messages and OXS support for flow
> > > removal message, individual flow description messages.
> > >
> > > "ovs-ofctl dump-flows" needs to be provided with the arbitrary OXS fields
> > > for displaying the desired flow stats.
> > >
> > > Below are Commands to display OXS stats field wise
> > >
> > > Flow Statistics Multipart
> > > ovs-ofctl dump-flows -O OpenFlow15  idle_time
> > > ovs-ofctl dump-flows -O OpenFlow15  packet_count
> > > ovs-ofctl dump-flows -O OpenFlow15  byte_count
> >
> > This would break backward compatibility for one of the most frequently used 
> > OVS CLI commands. Why don't you introduce a new
> command such as "ovs-ofctl dump-flow-stats" for the new OXS stats?
> 
> I think you might be misinterpreting the meaning here.  It doesn't
> appear to break compatibility, at least not in a major way, since it
> doesn't do a lot of updates to the tests that would otherwise be
> required.

Perhaps I am missing the point of some of these changes. I understand that OVS 
needs to support the new extensible OXS flow stats syntax in OpenFlow 1.5 and 
the differentiated MP request/reply pairs OFPMP_FLOW_DESC (replacing the former 
OFPMP_FLOW) and OFPMP_FLOW_STATS (just fetching flow stats per flow w/o the 
rest of the flow data).

But I don't understand why this should have any impact on the existing CLI 
command "ovs-ofctl dump-flows" and its output. This tool expressly fetches and 
displays the complete flow dump from OVS, including match, instructions/actions 
and statistics. When using OF 1.5 it should transparently apply OFPMP_FLOW_DESC 
MP request/reply to fetch the data, up to OF 1.4 it should use the original 
OFPMP_FLOW.

I can't see any ovs-ofctl use case that would justify the use of the new 
OFPMP_FLOW_STATS request/reply. The removed data in the reply compared to the 
full flow description are mainly the instructions, the full match is still 
there to identify each flow. So cutting down the transferred data volume can 
hardly be the reason (Note, this may still be different for real OF 1.5 
controllers).

If you believe we should have an ovs-ofctl command anyhow, e.g. for testing 
purposes, I suggest to introduce a new command or add an option to dump-flows 
to force use of this particular MP message. The output would be limited to flow 
match and stats in that case.

The new command to dump aggregate flow stats is of course a welcome addition. 
It should work irrespectively of the used OpenFlow version with the 
OFPMP_AGGREGATE_STATS primitive using classic flow stats prior to OF 1.5 and 
OXS flow stats in OF 1.5.

All in all I am NACK-ing this patch as it stands.

Regards, Jan

BTW: I have played a bit with the patch. The existing ovs-ofctl test cases 
appear to not break because the changes described in the commit message and the 
documentation are not effective. The legacy command format "ovs-ofctl 
dump-flows -O OpenFlow15  []" still produces the complete flow 
dump including instructions/actions:

# ovs-ofctl -Oopenflow15 dump-flow-desc br0
OFPST_FLOW_DESC reply (OF1.5) (xid=0x2):
 cookie=0x0, duration=90.515s, table=0, n_packets=0, n_bytes=0, reset_counts 
idle_age=840, hard_age=32766, in_port="br0-ns1" actions=output:"br0-ns2"
 cookie=0x0, duration=90.507s, table=0, n_packets=0, n_bytes=0, reset_counts 
idle_age=840, hard_age=32766, in_port="br0-ns2" actions=output:"br0-ns1"
 cookie=0x0, duration=850.125s, table=0, n_packets=2, n_bytes=180, 
idle_age=849, hard_age=32766, priority=0 actions=NORMAL

# ovs-ofctl -Oopenflow15 dump-flows br0
 cookie=0x0, duration=94.634s, table=0, n_packets=0, n_bytes=0, idle_age=844, 
hard_age=0, in_port="br0-ns1" actions=output:"br0-ns2"
 cookie=0x0, duration=94.626s, table=0, n_packets=0, n_bytes=0, idle_age=844, 
hard_age=0, in_port="br0-ns2" actions=output:"br0-ns1"
 cookie=0x0, duration=854.244s, table=0, n_packets=2, n_bytes=180, 
idle_age=853, hard_age=0, priority=0 actions=NORMAL

The only difference appears to be that the flow property reset_counts is 
missing and that hard_age seems corrupt in the new ovs-ofctl dump-flow-desc.

Furthermore, specifying any OXS field at the end of ovs-ofctl dump-flows 
 is without effect:

# ovs-ofctl -Oopenflow15 dump-flows br0 duration
 cookie=0x0, duration=173.536s, table=0, n_packets=0,

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-01-02 Thread Ben Pfaff

On Tue, Jan 02, 2018 at 08:13:12AM +, Jan Scheurich wrote:
> > -Original Message-
> > From: ovs-dev-boun...@openvswitch.org 
> > [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of SatyaValli
> > Sent: Monday, 01 January, 2018 11:59
> > To: d...@openvswitch.org
> > Cc: Manasa Cherukupally <manasa.cherukupa...@tcs.com>; Surya Muttamsetty 
> > <muttamsetty.su...@tcs.com>; Pavani Panthagada
> > <p.pava...@tcs.com>; SatyaValli <satyavalli.r...@tcs.com>; Lavanya 
> > Harivelam <harivelam.lava...@tcs.com>
> > Subject: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> > Statistics Support
> > 
> > From: SatyaValli <satyavalli.r...@tcs.com>
> > 
> > This Patch provides implementation Existing flow entry statistics are
> > redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> > displaying the arbitrary flow stats.The existing Flow Stats were renamed
> > as Flow Description.
> > 
> > To support this implementation below messages are newly added
> > 
> > OFPRAW_OFPT15_FLOW_REMOVED,
> > OFPRAW_OFPST15_FLOW_REQUEST,
> > OFPRAW_OFPST15_FLOW_DESC_REQUEST,
> > OFPRAW_OFPST15_AGGREGATE_REQUEST,
> > OFPRAW_OFPST15_FLOW_REPLY,
> > OFPRAW_OFPST15_FLOW_DESC_REPLY,
> > OFPRAW_OFPST15_AGGREGATE_REPLY,
> > 
> > The current commit adds support for the new feature in flow statistics
> > multipart messages,aggregate multipart messages and OXS support for flow
> > removal message, individual flow description messages.
> > 
> > "ovs-ofctl dump-flows" needs to be provided with the arbitrary OXS fields
> > for displaying the desired flow stats.
> > 
> > Below are Commands to display OXS stats field wise
> > 
> > Flow Statistics Multipart
> > ovs-ofctl dump-flows -O OpenFlow15  idle_time
> > ovs-ofctl dump-flows -O OpenFlow15  packet_count
> > ovs-ofctl dump-flows -O OpenFlow15  byte_count
> 
> This would break backward compatibility for one of the most frequently used 
> OVS CLI commands. Why don't you introduce a new command such as "ovs-ofctl 
> dump-flow-stats" for the new OXS stats?

I think you might be misinterpreting the meaning here.  It doesn't
appear to break compatibility, at least not in a major way, since it
doesn't do a lot of updates to the tests that would otherwise be
required.
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-01-02 Thread Jan Scheurich

> -Original Message-
> From: ovs-dev-boun...@openvswitch.org 
> [mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of SatyaValli
> Sent: Monday, 01 January, 2018 11:59
> To: d...@openvswitch.org
> Cc: Manasa Cherukupally <manasa.cherukupa...@tcs.com>; Surya Muttamsetty 
> <muttamsetty.su...@tcs.com>; Pavani Panthagada
> <p.pava...@tcs.com>; SatyaValli <satyavalli.r...@tcs.com>; Lavanya Harivelam 
> <harivelam.lava...@tcs.com>
> Subject: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry 
> Statistics Support
> 
> From: SatyaValli <satyavalli.r...@tcs.com>
> 
> This Patch provides implementation Existing flow entry statistics are
> redefined as standard OXS(OpenFlow Extensible Statistics) fields for
> displaying the arbitrary flow stats.The existing Flow Stats were renamed
> as Flow Description.
> 
> To support this implementation below messages are newly added
> 
> OFPRAW_OFPT15_FLOW_REMOVED,
> OFPRAW_OFPST15_FLOW_REQUEST,
> OFPRAW_OFPST15_FLOW_DESC_REQUEST,
> OFPRAW_OFPST15_AGGREGATE_REQUEST,
> OFPRAW_OFPST15_FLOW_REPLY,
> OFPRAW_OFPST15_FLOW_DESC_REPLY,
> OFPRAW_OFPST15_AGGREGATE_REPLY,
> 
> The current commit adds support for the new feature in flow statistics
> multipart messages,aggregate multipart messages and OXS support for flow
> removal message, individual flow description messages.
> 
> "ovs-ofctl dump-flows" needs to be provided with the arbitrary OXS fields
> for displaying the desired flow stats.
> 
> Below are Commands to display OXS stats field wise
> 
> Flow Statistics Multipart
> ovs-ofctl dump-flows -O OpenFlow15  idle_time
> ovs-ofctl dump-flows -O OpenFlow15  packet_count
> ovs-ofctl dump-flows -O OpenFlow15  byte_count

This would break backward compatibility for one of the most frequently used OVS 
CLI commands. Why don't you introduce a new command such as "ovs-ofctl 
dump-flow-stats" for the new OXS stats?

> 
> Aggregate Flow Statistics Multipart
> ovs-ofctl dump-aggregate -O OpenFlow15  packet_count
> ovs-ofctl dump-aggregate -O OpenFlow15  byte_count
> 
> Flow Descritption
> ovs-ofctl dump-flow-desc -O OpenFlow15  idle_time
> ovs-ofctl dump-flow-desc -O OpenFlow15  packet_count
> ovs-ofctl dump-flow-desc -O OpenFlow15  byte_count
> 
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

2018-01-01 Thread SatyaValli

From: SatyaValli 

This Patch provides implementation Existing flow entry statistics are
redefined as standard OXS(OpenFlow Extensible Statistics) fields for
displaying the arbitrary flow stats.The existing Flow Stats were renamed
as Flow Description.

To support this implementation below messages are newly added

OFPRAW_OFPT15_FLOW_REMOVED,
OFPRAW_OFPST15_FLOW_REQUEST,
OFPRAW_OFPST15_FLOW_DESC_REQUEST,
OFPRAW_OFPST15_AGGREGATE_REQUEST,
OFPRAW_OFPST15_FLOW_REPLY,
OFPRAW_OFPST15_FLOW_DESC_REPLY,
OFPRAW_OFPST15_AGGREGATE_REPLY,

The current commit adds support for the new feature in flow statistics
multipart messages,aggregate multipart messages and OXS support for flow
removal message, individual flow description messages.

"ovs-ofctl dump-flows" needs to be provided with the arbitrary OXS fields
for displaying the desired flow stats.

Below are Commands to display OXS stats field wise

Flow Statistics Multipart
ovs-ofctl dump-flows -O OpenFlow15  idle_time
ovs-ofctl dump-flows -O OpenFlow15  packet_count
ovs-ofctl dump-flows -O OpenFlow15  byte_count

Aggregate Flow Statistics Multipart
ovs-ofctl dump-aggregate -O OpenFlow15  packet_count
ovs-ofctl dump-aggregate -O OpenFlow15  byte_count

Flow Descritption
ovs-ofctl dump-flow-desc -O OpenFlow15  idle_time
ovs-ofctl dump-flow-desc -O OpenFlow15  packet_count
ovs-ofctl dump-flow-desc -O OpenFlow15  byte_count

Signed-off-by: Satya Valli 
Co-authored-by: Lavanya Harivelam 
Signed-off-by: Lavanya Harivelam 
Co-authored-by: Surya Muttamsetty 
Signed-off-by: Surya Muttamsetty 
Co-authored-by: Manasa Cherukupally 
Signed-off-by: Manasa Cherukupally 
Co-authored-by: Pavani Panthagada 
Signed-off-by: Pavani Panthagada 

---
 NEWS|   9 +
 include/openflow/openflow-1.5.h |  81 
 include/openvswitch/ofp-msgs.h  |  31 +-
 include/openvswitch/ofp-parse.h |   6 +-
 include/openvswitch/ofp-util.h  |  18 +-
 lib/automake.mk |   2 +
 lib/ofp-parse.c |  72 ++-
 lib/ofp-print.c |   2 +
 lib/ofp-util.c  | 286 +++-
 lib/ox-stat.c   | 984 
 lib/ox-stat.h   |  52 +++
 lib/rconn.c |   2 +
 ofproto/ofproto.c   |   9 +-
 tests/ofp-print.at  | 127 ++
 tests/ofproto-dpif.at   |  84 
 tests/ofproto.at|   5 +
 utilities/ovs-ofctl.8.in|  48 +-
 utilities/ovs-ofctl.c   |  34 +-
 18 files changed, 1795 insertions(+), 57 deletions(-)
 create mode 100644 lib/ox-stat.c
 create mode 100644 lib/ox-stat.h

diff --git a/NEWS b/NEWS
index af98c2f..ec4501c 100644
--- a/NEWS
+++ b/NEWS
@@ -33,6 +33,15 @@ Post-v2.8.0
 v2.8.0 - 31 Aug 2017
 
- ovs-ofctl:
+ * Existing flow entry statistics are redefined as standard OXS(OpenFlow
+   Extensible Statistics) fields for displaying the arbitrary flow stats.
+ * Now "ovs-ofctl dump-flows" needs to be provided with the arbitrary OXS
+   fields i.e flow duration, flow count, packet count, byte count or all
+   for displaying the desired flow stats.By default with "ovs-ofctl dump-
+   flows" displays only flow duration. See ovs-ofctl(8) for details.
+ * The existing flow statistics are renamed as Flow Description. Now the
+   information about individual flow entries will be displayed with the
+   help of ovs-ofctl dump-flow-desc. See ovs-ofctl(8) for details.
  * ovs-ofctl can now accept and display port names in place of numbers.  By
default it always accepts names and in interactive use it displays them;
use --names or --no-names to override.  See ovs-ofctl(8) for details.
diff --git a/include/openflow/openflow-1.5.h b/include/openflow/openflow-1.5.h
index 73b76d8..d1870ce 100644
--- a/include/openflow/openflow-1.5.h
+++ b/include/openflow/openflow-1.5.h
@@ -163,4 +163,85 @@ struct ofp15_packet_out {
 };
 OFP_ASSERT(sizeof(struct ofp15_packet_out) == 8);
 
+struct ofp_oxs_stat {
+ovs_be16 reserved;  /* Reserved for future use,
+ * currently zeroed. */
+ovs_be16 length;/* Stats Length */
+};
+
+OFP_ASSERT(sizeof(struct ofp_oxs_stat) == 4);
+
+/* Body for ofp_multipart_request of type
+ * OFPMP_FLOW_DESC & OFPMP_FLOW_STATS. */
+struct ofp15_flow_stats_request {
+uint8_t table_id;   /* ID of table to read (from ofp_table_desc),
+ * OFPTT_ALL for all tables. */
+uint8_t pad[3]; /* Align to 32 bits. */
+ovs_be32 out_port;  /* Require matching entries to include this as
+ * an output port. A value of OFP_ANY
+

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

Re: [ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

[ovs-dev] [PATCH V2] OF1.5/EXT-334 OXS/Extensible Flow Entry Statistics Support

11 matches

Site Navigation

Mail list logo

Footer information