Re: [ovs-dev] [PATCH ovn] Typo fix in the ovn-nbctl man page.
On 3/28/23 15:46, Dumitru Ceara wrote: > From: Roberto Bartzen Acosta > > According to the ovn-nbctl man8 (NAT): > [--may-exist] [--stateless] [--gateway_port=GATEWAY_PORT] > lr-nat-add router type external_ip logical_ip [logical_port external_mac] > > Result using man page syntax: > ovn-nbctl: unrecognized option '--gateway_port' > > The option expected by the implementation is: > --gateway-port > > Signed-off-by: Roberto Bartzen Acosta > --- Submitted-at: https://github.com/ovn-org/ovn/pull/184 Thanks for the contribution, Roberto! I applied this to the main branch and I added you to the authors list. Regards, Dumitru ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
Re: [ovs-dev] [PATCH ovn] Typo fix in the ovn-nbctl man page.
Bleep bloop. Greetings Dumitru Ceara, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 275 characters long (recommended limit is 79) #30 FILE: utilities/ovn-nbctl.8.xml:1154: [--may-exist] [--stateless] [--gateway-port=GATEWAY_PORT] lr-nat-add router type external_ip logical_ip [logical_port external_mac] Lines checked: 37, Warnings: 1, Errors: 0 Please check this out. If you feel there has been an error, please email acon...@redhat.com Thanks, 0-day Robot ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
[ovs-dev] [PATCH ovn] Typo fix in the ovn-nbctl man page.
From: Roberto Bartzen Acosta According to the ovn-nbctl man8 (NAT): [--may-exist] [--stateless] [--gateway_port=GATEWAY_PORT] lr-nat-add router type external_ip logical_ip [logical_port external_mac] Result using man page syntax: ovn-nbctl: unrecognized option '--gateway_port' The option expected by the implementation is: --gateway-port Signed-off-by: Roberto Bartzen Acosta --- utilities/ovn-nbctl.8.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/utilities/ovn-nbctl.8.xml b/utilities/ovn-nbctl.8.xml index 72d4088f0c..54dbdb791e 100644 --- a/utilities/ovn-nbctl.8.xml +++ b/utilities/ovn-nbctl.8.xml @@ -1151,7 +1151,7 @@ NAT Commands - [--may-exist] [--stateless] [--gateway_port=GATEWAY_PORT] lr-nat-add router type external_ip logical_ip [logical_port external_mac] + [--may-exist] [--stateless] [--gateway-port=GATEWAY_PORT] lr-nat-add router type external_ip logical_ip [logical_port external_mac] Adds the specified NAT to router. -- 2.31.1 ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev
