Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-28 Thread Ankur Sharma
J6MJY=2-GAHL6i_h5e3goVtf9cLADVNik3Bq27XqQ4nlxoI3Q=m0JzoFgMJKZZSIFZ-EwA_6Q4s6fR9GoSsXqrlBX89b0= [2] https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_ovn-2Dorg_ovn_blob_master_tests_system-2Dovn.at-23L2751=DwICAg=s883GpUCOChKOHiocYtGcg=mZwX9gFQgeJHzTg-68aCJgsODyUEVsHGFOfL90J6MJY=2-GAHL6i_h5e3goVtf

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-28 Thread Lorenzo Bianconi
fda9a1dd3c995f25cad9e828e701f8b41d347bbb ("northd: manage ARP request locally for FIP traffic") they were not merged when I sent this particular fix. @Ankur: could you please take a look now at ovn.at/system-ovn.at? Do you think tests are fine now? If not I am 100% fine to add some more tests. Regards

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-28 Thread Numan Siddique
> Can you please see the reply from Ankur here - https://mail.openvswitch.org/pipermail/ovs-dev/2020-May/370908.html I think he has some suggestions about the test cases. I should have replied in that thread. Thanks Numan Regards, > Lorenzo > > > > > Do we need to apply this patch to

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-28 Thread Lorenzo Bianconi
duced a test case for this scenario here: https://github.com/ovn-org/ovn/blob/master/tests/ovn.at#L15022 and here: https://github.com/ovn-org/ovn/blob/master/tests/system-ovn.at#L2751 Do you mean something more specific? Regards, Lorenzo > > Do we need to apply this patch to 20.03 ? > &

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-28 Thread Numan Siddique
d you mind a follow up patch for this if it's possible ? Do we need to apply this patch to 20.03 ? Thanks Numan > > > Regards, > > Ankur > > ____________________ > > From: dev on behalf of Lorenzo > Bianconi > > Sent: Thursday, May 21, 2020 6:

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-22 Thread Ankur Sharma
Hi Lorenzo, Please find my replies inline. Regards, Ankur From: Lorenzo Bianconi Sent: Friday, May 22, 2020 12:48 AM To: Ankur Sharma Cc: ovs-dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes > Hi Lore

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-22 Thread Lorenzo Bianconi
f of Lorenzo Bianconi > > Sent: Thursday, May 21, 2020 6:46 AM > To: ovs-dev@openvswitch.org > Subject: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes > > When the ARP request is sent to a gw router and not to the final > destination of the packet buffere

Re: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-21 Thread Ankur Sharma
-dev@openvswitch.org Subject: [ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes When the ARP request is sent to a gw router and not to the final destination of the packet buffered_packets_map needs to be updated using next-hop IP address and not the destination one. Fixes

[ovs-dev] [PATCH ovn] controller: fix ip buffering with static routes

2020-05-21 Thread Lorenzo Bianconi
When the ARP request is sent to a gw router and not to the final destination of the packet buffered_packets_map needs to be updated using next-hop IP address and not the destination one. Fixes: 2e5cdb4b1392 ("OVN: add buffering support for ip packets") Signed-off-by: Lorenzo Bianconi ---