Re: [ovs-dev] [PATCH ovn] ovn-northd: Use HMAP_FOR_EACH when adding multicast lflows

2019-08-05 Thread Mark Michelson
I applied the change to master. On 8/5/19 9:08 AM, Numan Siddique wrote: On Thu, Aug 1, 2019 at 5:09 PM Dumitru Ceara wrote: There's no need to use HMAP_FOR_EACH_SAFE when we add the logical flows that correspond to IGMP groups as we don't modify the hashmap in the loop. Also, we should

Re: [ovs-dev] [PATCH ovn] ovn-northd: Use HMAP_FOR_EACH when adding multicast lflows

2019-08-05 Thread Numan Siddique
On Thu, Aug 1, 2019 at 5:09 PM Dumitru Ceara wrote: > There's no need to use HMAP_FOR_EACH_SAFE when we add the logical flows > that correspond to IGMP groups as we don't modify the hashmap in the > loop. > > Also, we should reinitialize match and actions only if the flow will be > added. > >

[ovs-dev] [PATCH ovn] ovn-northd: Use HMAP_FOR_EACH when adding multicast lflows

2019-08-01 Thread Dumitru Ceara
There's no need to use HMAP_FOR_EACH_SAFE when we add the logical flows that correspond to IGMP groups as we don't modify the hashmap in the loop. Also, we should reinitialize match and actions only if the flow will be added. Fixes: ddc64665b678 ("OVN: Add ovn-northd IGMP support")