Re: [ovs-dev] [PATCH ovn 1/2] Add ovn-appctl utility

2019-09-10 Thread Numan Siddique
On Wed, Sep 4, 2019 at 11:21 PM Mark Michelson wrote: > On 9/2/19 1:09 PM, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Now that OVN has it's own rundir, "ovs-appctl -t > ovn-controller/ovn-northd" > > doesn't work. To fix this, ovn-appctl utility is added which > > looks for the

Re: [ovs-dev] [PATCH ovn 1/2] Add ovn-appctl utility

2019-09-04 Thread Mark Michelson
On 9/2/19 1:09 PM, nusid...@redhat.com wrote: From: Numan Siddique Now that OVN has it's own rundir, "ovs-appctl -t ovn-controller/ovn-northd" doesn't work. To fix this, ovn-appctl utility is added which looks for the OVN pid/ctl files in the ovn rundir. The code is taken from ovs-appctl.c and

Re: [ovs-dev] [PATCH ovn 1/2] Add ovn-appctl utility

2019-09-02 Thread 0-day Robot
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator

[ovs-dev] [PATCH ovn 1/2] Add ovn-appctl utility

2019-09-02 Thread nusiddiq
From: Numan Siddique Now that OVN has it's own rundir, "ovs-appctl -t ovn-controller/ovn-northd" doesn't work. To fix this, ovn-appctl utility is added which looks for the OVN pid/ctl files in the ovn rundir. The code is taken from ovs-appctl.c and modified to use ovn_rundir() instead of ovs_run