Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Fix use of dangling pointers in I-P runtime_data.

2019-11-14 Thread Dumitru Ceara
On Wed, Nov 13, 2019 at 9:18 AM Dumitru Ceara wrote: > > On Fri, Nov 8, 2019 at 8:27 PM Han Zhou wrote: > > > > > > > > On Fri, Nov 8, 2019 at 11:22 AM Han Zhou wrote: > > > > > > 1. storage data and the void *arg of init() breaks the engine node data > > > encapsulation. > > > 2.

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Fix use of dangling pointers in I-P runtime_data.

2019-11-13 Thread Dumitru Ceara
On Fri, Nov 8, 2019 at 8:27 PM Han Zhou wrote: > > > > On Fri, Nov 8, 2019 at 11:22 AM Han Zhou wrote: > > > > 1. storage data and the void *arg of init() breaks the engine node data > > encapsulation. > > 2. engine_node_valid(_flow_output, engine_run_id) is not needed? Should > > use storage

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Fix use of dangling pointers in I-P runtime_data.

2019-11-08 Thread Han Zhou
On Fri, Nov 8, 2019 at 11:22 AM Han Zhou wrote: > > 1. storage data and the void *arg of init() breaks the engine node data encapsulation. > 2. engine_node_valid(_flow_output, engine_run_id) is not needed? Should use storage to access instead? > 3. refactor of engine is good but better to be a

Re: [ovs-dev] [PATCH ovn v2] ovn-controller: Fix use of dangling pointers in I-P runtime_data.

2019-11-08 Thread Han Zhou
1. storage data and the void *arg of init() breaks the engine node data encapsulation. 2. engine_node_valid(_flow_output, engine_run_id) is not needed? Should use storage to access instead? 3. refactor of engine is good but better to be a separate commit 4. we can have a new interface:

[ovs-dev] [PATCH ovn v2] ovn-controller: Fix use of dangling pointers in I-P runtime_data.

2019-11-04 Thread Dumitru Ceara
The incremental processing engine might stop a run before the en_runtime_data node is processed. In such cases the ed_runtime_data fields might contain pointers to already deleted SB records. For example, if a port binding corresponding to a patch port is removed from the SB database and the