On Thu, Mar 02, 2023 at 02:11:09PM +0100, Ilya Maximets wrote:
> For non-dynamic address, current version performs 1 strcmp + 4 attempts
> for ovs_scan. Updated code performs 1 strncmp + 1 ovs_scan.
>
> Also, for ports with both IPv4 and IPv6 specified, new version doesn't
> re-parse IPv4 twice.
Bleep bloop. Greetings Ilya Maximets, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Comment with 'xxx' marker
#52 FILE: lib/ovn-util.c:123:
/* Either
For non-dynamic address, current version performs 1 strcmp + 4 attempts
for ovs_scan. Updated code performs 1 strncmp + 1 ovs_scan.
Also, for ports with both IPv4 and IPv6 specified, new version doesn't
re-parse IPv4 twice.
Signed-off-by: Ilya Maximets
---
lib/ovn-util.c | 40