Re: [ovs-dev] [PATCH ovn v6 1/9] ovn-controller: Store the local port bindings in the runtime data I-P state.

2020-05-20 Thread Han Zhou
On Wed, May 20, 2020 at 2:25 AM Numan Siddique wrote: > > > > On Wed, May 20, 2020 at 1:27 PM Numan Siddique wrote: >> >> >> >> On Wed, May 20, 2020 at 6:35 AM Han Zhou wrote: >>> >>> Hi Numan, >>> >>> Please see my comments below. >>> >>> Thanks, >>> Han >>> >>> On Sat, May 16, 2020 at 10:56

Re: [ovs-dev] [PATCH ovn v6 1/9] ovn-controller: Store the local port bindings in the runtime data I-P state.

2020-05-20 Thread Numan Siddique
On Wed, May 20, 2020 at 1:27 PM Numan Siddique wrote: > > > On Wed, May 20, 2020 at 6:35 AM Han Zhou wrote: > >> Hi Numan, >> >> Please see my comments below. >> >> Thanks, >> Han >> >> On Sat, May 16, 2020 at 10:56 AM wrote: >> > >> > From: Numan Siddique >> > >> > This patch adds a new data

Re: [ovs-dev] [PATCH ovn v6 1/9] ovn-controller: Store the local port bindings in the runtime data I-P state.

2020-05-20 Thread Numan Siddique
On Wed, May 20, 2020 at 6:35 AM Han Zhou wrote: > Hi Numan, > > Please see my comments below. > > Thanks, > Han > > On Sat, May 16, 2020 at 10:56 AM wrote: > > > > From: Numan Siddique > > > > This patch adds a new data structure - 'struct local_binding' which > represents > > a probable local

Re: [ovs-dev] [PATCH ovn v6 1/9] ovn-controller: Store the local port bindings in the runtime data I-P state.

2020-05-19 Thread Han Zhou
Hi Numan, Please see my comments below. Thanks, Han On Sat, May 16, 2020 at 10:56 AM wrote: > > From: Numan Siddique > > This patch adds a new data structure - 'struct local_binding' which represents > a probable local port binding. A new object of this structure is creared for > each

[ovs-dev] [PATCH ovn v6 1/9] ovn-controller: Store the local port bindings in the runtime data I-P state.

2020-05-16 Thread numans
From: Numan Siddique This patch adds a new data structure - 'struct local_binding' which represents a probable local port binding. A new object of this structure is creared for each interface present in the integration bridge (br-int) with the external_ids:iface-id set. This struct has 2 main