Re: [ovs-dev] [PATCH v1] ofproto-dpif-trace: Fix for the segmentation fault in ofproto_trace().

2019-02-04 Thread Ben Pfaff
On Mon, Feb 04, 2019 at 03:34:34PM -0800, Ashish Varma wrote: > Added the check for NULL in "next_ct_states" argument passed to the > "ofproto_trace()" function. Under normal scenario, this is non-NULL. A NULL > "next_ct_states" argument is passed from the "upcall_xlate()" function on >

Re: [ovs-dev] [PATCH v1] ofproto-dpif-trace: Fix for the segmentation fault in ofproto_trace().

2019-02-04 Thread Yifeng Sun
Thanks for the fix. I am wondering if we can output some useful information in 'struct ds' for this case? On Mon, Feb 4, 2019 at 3:45 PM Ashish Varma wrote: > Added the check for NULL in "next_ct_states" argument passed to the > "ofproto_trace()" function. Under normal scenario, this is

[ovs-dev] [PATCH v1] ofproto-dpif-trace: Fix for the segmentation fault in ofproto_trace().

2019-02-04 Thread Ashish Varma
Added the check for NULL in "next_ct_states" argument passed to the "ofproto_trace()" function. Under normal scenario, this is non-NULL. A NULL "next_ct_states" argument is passed from the "upcall_xlate()" function on encountering XLATE_RECURSION_TOO_DEEP or XLATE_TOO_MANY_RESUBMITS error.