Re: [ovs-dev] [PATCH v1] ovs-lib: Fix standalone db migration to raft

2019-08-21 Thread Ben Pfaff
On Mon, Aug 19, 2019 at 06:36:13PM -0700, Aliasgar Ginwala wrote: > Current code of create-cluster from standalone db takes backup of existing > standalone db and then generates a new clustered dbs from backup dbs. Hence, > during migration if nb and sb dbs are still present, create-cluster will f

Re: [ovs-dev] [PATCH v1] ovs-lib: Fix standalone db migration to raft

2019-08-20 Thread Han Zhou
On Mon, Aug 19, 2019 at 6:36 PM Aliasgar Ginwala wrote: > > Current code of create-cluster from standalone db takes backup of existing > standalone db and then generates a new clustered dbs from backup dbs. Hence, > during migration if nb and sb dbs are still present, create-cluster will fail > s

Re: [ovs-dev] [PATCH v1] ovs-lib: Fix standalone db migration to raft

2019-08-19 Thread 0-day Robot
Bleep bloop. Greetings Aliasgar Ginwala, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author Aliasgar Ginwala needs to sign off. WARNING: Unexpected sign-offs from devel

[ovs-dev] [PATCH v1] ovs-lib: Fix standalone db migration to raft

2019-08-19 Thread Aliasgar Ginwala
Current code of create-cluster from standalone db takes backup of existing standalone db and then generates a new clustered dbs from backup dbs. Hence, during migration if nb and sb dbs are still present, create-cluster will fail saying file exists and will not really convert dbs to clustered dbs