Re: [ovs-dev] [PATCH v1 1/1] ofproto: Fix NULL deref reported by Coverity.

2024-04-02 Thread Ilya Maximets
On 4/2/24 19:04, Aaron Conole wrote: > mit...@outlook.com writes: > >> From: miter Please, adjust the 'From' to match the Sign-off tag. >> >> Ofproto_class_find__() may return NULL, and dereference it to cause >> segfault. >> >> Tested-by: Zhang YuHuang >> Signed-off-by: Lin Huang >> --- >

Re: [ovs-dev] [PATCH v1 1/1] ofproto: Fix NULL deref reported by Coverity.

2024-04-02 Thread Aaron Conole
mit...@outlook.com writes: > From: miter > > Ofproto_class_find__() may return NULL, and dereference it to cause > segfault. > > Tested-by: Zhang YuHuang > Signed-off-by: Lin Huang > --- I guess that type_run and type_wait aren't flagged this way because the only users walk the ofproto types

Re: [ovs-dev] [PATCH v1 1/1] ofproto: Fix NULL deref reported by Coverity.

2024-04-02 Thread 0-day Robot
Bleep bloop. Greetings miter, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: ERROR: Author miter needs to sign off. WARNING: Unexpected sign-offs from developers who are not

[ovs-dev] [PATCH v1 1/1] ofproto: Fix NULL deref reported by Coverity.

2024-04-02 Thread miterv
From: miter Ofproto_class_find__() may return NULL, and dereference it to cause segfault. Tested-by: Zhang YuHuang Signed-off-by: Lin Huang --- ofproto/ofproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto.c b/ofproto/ofproto.c index