Re: [ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Yang, Yi Y
Noticed, please check the reply for that one. -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Thursday, August 10, 2017 4:04 AM To: Yang, Yi Y Cc: d...@openvswitch.org Subject: Re: [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length I gave a

Re: [ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Ben Pfaff
I gave a more detailed explanation later: https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337164.html On Wed, Aug 09, 2017 at 07:52:38PM +, Yang, Yi Y wrote: > Ben, no matter it is MD type 1 or MD type 2, we use the same netlink > attribute OVS_ACTION_ATTR_ENCAP_NSH to transfer the

Re: [ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Yang, Yi Y
Ben, no matter it is MD type 1 or MD type 2, we use the same netlink attribute OVS_ACTION_ATTR_ENCAP_NSH to transfer these data, another netlink attribute OVS_KEY_ATTR_NSH is for struct ovs_key_nsh. So I can't catch your point, can you explain it more? -Original Message- From: Ben Pfaff

Re: [ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 07:45:13PM +0800, Yi Yang wrote: > In order to adapt to MD type 1 and MD type 2 at the same > time and avoid breaking Linux kernel uAPI later, we change > struct ovs_action_encap_nsh to the below format. > > struct ovs_action_encap_nsh { > uint8_t flags; > uint8_t m

[ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Yi Yang
In order to adapt to MD type 1 and MD type 2 at the same time and avoid breaking Linux kernel uAPI later, we change struct ovs_action_encap_nsh to the below format. struct ovs_action_encap_nsh { uint8_t flags; uint8_t mdtype; uint8_t mdlen; uint8_t np; __be32 path_hdr; uint