Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

2019-06-11 Thread Eelco Chaudron
On 7 Jun 2019, at 7:27, Anju Thomas wrote: Did a quick review, and I noticed some styling issues (mainly indentation), the rest seems ok. One small issue with applying the patchset to master, but nothing a manual inspection could quickly fix. Did some basic testing by forcing some of the dr

Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

2019-06-07 Thread Gregory Rose
On 6/7/2019 2:31 PM, Gregory Rose wrote: On 6/6/2019 10:27 PM, Anju Thomas wrote: Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in tab

Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

2019-06-07 Thread Gregory Rose
On 6/6/2019 10:27 PM, Anju Thomas wrote: Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by c

Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

2019-06-06 Thread 0-day Robot
Bleep bloop. Greetings Anju Thomas, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: :804: new blank line at EOF. + warning: 1 line adds whitespace errors. Failed to merge in the change

Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

2019-06-06 Thread Anju Thomas
Please disregard this path .. Sending an updated v10 -Original Message- From: 0-day Robot Sent: Friday, June 7, 2019 9:31 AM To: Anju Thomas Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS Bleep bloop. Greetings Anju Thomas, I am a

[ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

2019-06-06 Thread Anju Thomas
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the semantics of the c

Re: [ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

2019-06-06 Thread 0-day Robot
Bleep bloop. Greetings Anju Thomas, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. build: -e 's,[@]DBDIR[@],/usr/local/etc/openvswitch,g' \ -e 's,[@]PYTHON[@],/bin/python2,g' \ -e

[ovs-dev] [PATCH v10] Improved Packet Drop Statistics in OVS

2019-06-06 Thread Anju Thomas
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the semantics of the