Re: [ovs-dev] [PATCH v2] ofproto-dpif-ipfix: Fix an issue in flow key part

2018-02-15 Thread Ben Pfaff
Thanks Daniel and Michal. I applied this to master and branch-2.9. On Thu, Feb 15, 2018 at 01:23:04PM +, Weglicki, MichalX wrote: > Hi Daniel, Ben, > > Looks good to me! > > Br, > Michal. > > > -Original Message- > > From: Daniel Benli Ye [mailto:dani...@vmware.com] > > Sent: Th

Re: [ovs-dev] [PATCH v2] ofproto-dpif-ipfix: Fix an issue in flow key part

2018-02-15 Thread Weglicki, MichalX
Hi Daniel, Ben, Looks good to me! Br, Michal. > -Original Message- > From: Daniel Benli Ye [mailto:dani...@vmware.com] > Sent: Thursday, February 15, 2018 2:52 AM > To: b...@ovn.com; wen...@vmware.com; Weglicki, MichalX > ; d...@openvswitch.org > Cc: Benli Ye > Subject: [PATCH v2] o

Re: [ovs-dev] [PATCH v2] ofproto-dpif-ipfix: Fix an issue in flow key part

2018-02-14 Thread Ben Pfaff
On Wed, Feb 14, 2018 at 05:52:07PM -0800, Daniel Benli Ye wrote: > From: Benli Ye > > As struct ipfix_data_record_flow_key_iface didn't calculate > its length in flow key part, it may cause problem when flow > key part length is not enough. Use MAX_IF_LEN and MAX_IF_DESCR > to pre-allocate memory

[ovs-dev] [PATCH v2] ofproto-dpif-ipfix: Fix an issue in flow key part

2018-02-14 Thread Daniel Benli Ye
From: Benli Ye As struct ipfix_data_record_flow_key_iface didn't calculate its length in flow key part, it may cause problem when flow key part length is not enough. Use MAX_IF_LEN and MAX_IF_DESCR to pre-allocate memory for ipfix_data_record_flow_key_iface. v1 -> v2: Use strnlen() to limit the