Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2017-01-19 Thread Yang, Yi Y
org>; Jan Scheurich <jan.scheur...@web.de> Subject: Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames On Thu, Jan 19, 2017 at 03:12:20PM -0800, Joe Stringer wrote: > On 19 January 2017 at 12:17, Pravin Shelar <pshe...@ovn.org> wrote: > > On We

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2017-01-19 Thread Eric Garver
On Thu, Jan 19, 2017 at 03:12:20PM -0800, Joe Stringer wrote: > On 19 January 2017 at 12:17, Pravin Shelar wrote: > > On Wed, Jan 18, 2017 at 4:53 PM, Yang, Yi wrote: > >> On Wed, Jan 18, 2017 at 01:29:14PM -0800, Joe Stringer wrote: > >>> On 18 January 2017

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2017-01-19 Thread Joe Stringer
On 19 January 2017 at 12:17, Pravin Shelar wrote: > On Wed, Jan 18, 2017 at 4:53 PM, Yang, Yi wrote: >> On Wed, Jan 18, 2017 at 01:29:14PM -0800, Joe Stringer wrote: >>> On 18 January 2017 at 11:54, Eric Garver wrote: >>> > On Tue, Jan 17,

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2017-01-19 Thread Pravin Shelar
On Wed, Jan 18, 2017 at 4:53 PM, Yang, Yi wrote: > On Wed, Jan 18, 2017 at 01:29:14PM -0800, Joe Stringer wrote: >> On 18 January 2017 at 11:54, Eric Garver wrote: >> > On Tue, Jan 17, 2017 at 12:37:19AM +, Yang, Yi Y wrote: >> >> What userspace do "802.1ad

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2017-01-18 Thread Yang, Yi
On Wed, Jan 18, 2017 at 01:29:14PM -0800, Joe Stringer wrote: > On 18 January 2017 at 11:54, Eric Garver wrote: > > On Tue, Jan 17, 2017 at 12:37:19AM +, Yang, Yi Y wrote: > >> What userspace do "802.1ad patches" depend on? Per Pravin's statement, we > >> just backport 802.1ad

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2017-01-16 Thread Yang, Yi Y
Hi, Eric We hope Jiri's L3 patchset can be applied into current ovs because we and Ericsson guys are enabling packet_type support and PTAP & non-PTAP based on L3 patchset, Pravin said you're backporting your 802.1ad patches from net-next to ovs, we don't know when your patches can be posted in

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2017-01-09 Thread Eric Garver
On Mon, Jan 09, 2017 at 03:03:00PM +0530, Pravin Shelar wrote: > On Tue, Jan 3, 2017 at 6:47 AM, Yang, Yi Y wrote: > > Pravin, the issue is current ovs has too many differences from net-next > > tree, the best way is to apply all the patches before your patch, but it > >

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2017-01-09 Thread Pravin Shelar
On Tue, Jan 3, 2017 at 6:47 AM, Yang, Yi Y wrote: > Pravin, the issue is current ovs has too many differences from net-next tree, > the best way is to apply all the patches before your patch, but it seems a > super huge work, it is out of my capability :-) Anybody of you is

Re: [ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2017-01-02 Thread Yang, Yi Y
Pravin, the issue is current ovs has too many differences from net-next tree, the best way is to apply all the patches before your patch, but it seems a super huge work, it is out of my capability :-) Anybody of you is working on this? -Original Message- From: Pravin Shelar

[ovs-dev] [PATCH v2 14/17] datapath: Fix skb->protocol for vlan frames

2016-12-28 Thread Yi Yang
Do not always set skb->protocol to be the ethertype of the L3 header. For a packet with non-accelerated VLAN tags skb->protocol needs to be the ethertype of the outermost non-accelerated VLAN ethertype. Any VLAN offloading is undone on the OVS netlink interface, and any VLAN tags added by