Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

2018-04-13 Thread Han Zhou
On Fri, Apr 13, 2018 at 2:40 PM, Han Zhou wrote: > > > > On Fri, Apr 13, 2018 at 1:42 PM, Ben Pfaff wrote: > > > > On Fri, Apr 13, 2018 at 01:33:26PM -0700, Han Zhou wrote: > > > On Fri, Apr 13, 2018 at 12:54 PM, Ben Pfaff wrote: > > > > I think

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

2018-04-13 Thread Han Zhou
On Fri, Apr 13, 2018 at 1:42 PM, Ben Pfaff wrote: > > On Fri, Apr 13, 2018 at 01:33:26PM -0700, Han Zhou wrote: > > On Fri, Apr 13, 2018 at 12:54 PM, Ben Pfaff wrote: > > > I think that sync_address_sets() is O(n**2) in n_ipv4_addrs and > > > n_ipv6_addrs, because of

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

2018-04-13 Thread Ben Pfaff
On Fri, Apr 13, 2018 at 01:33:26PM -0700, Han Zhou wrote: > On Fri, Apr 13, 2018 at 12:54 PM, Ben Pfaff wrote: > > I think that sync_address_sets() is O(n**2) in n_ipv4_addrs and > > n_ipv6_addrs, because of the allocation strategy. If port groups get > > big (and they will

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

2018-04-13 Thread Han Zhou
On Fri, Apr 13, 2018 at 12:54 PM, Ben Pfaff wrote: > > On Wed, Apr 04, 2018 at 05:51:48PM -0700, Han Zhou wrote: > > Address sets are automatically generated from corresponding port > > groups, and can be used directly in ACL match conditions. > > Thanks! > > I think that

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

2018-04-13 Thread Ben Pfaff
On Wed, Apr 04, 2018 at 05:51:48PM -0700, Han Zhou wrote: > Address sets are automatically generated from corresponding port > groups, and can be used directly in ACL match conditions. Thanks! I think that sync_address_sets() has a memory leak, because I don't see any free() calls that match up

Re: [ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

2018-04-12 Thread Daniel Alvarez Sanchez
Acked-by: Daniel Alvarez Thanks Han! Everything LGTM and the tests pass okay against current master. On Thu, Apr 5, 2018 at 2:51 AM, Han Zhou wrote: > Address sets are automatically generated from corresponding port > groups, and can be used directly in

[ovs-dev] [PATCH v2 2/2] ovn: Support address sets generated from port groups

2018-04-04 Thread Han Zhou
Address sets are automatically generated from corresponding port groups, and can be used directly in ACL match conditions. There are two address sets generated for each port group: _ip4 _ip6 For example, if port_group1 is created, we can directly use below match condition in ACL: "outport