Re: [ovs-dev] [PATCH v2 2/4] netdev-linux: Favour inner packet for multi-encapsulated TSO.

2024-02-15 Thread David Marchand
On Thu, Feb 15, 2024 at 7:03 AM Mike Pattrick wrote: > I've made a branch where we properly account for outer and inner > checksums, and it passes the tests mostly, except for afxdp. > > For afxdp we crash in dp_packet_prealloc_headroom(). netdev-afxdp has > a hardcoded OVS_XDP_HEADROOM=128 bytes

Re: [ovs-dev] [PATCH v2 2/4] netdev-linux: Favour inner packet for multi-encapsulated TSO.

2024-02-14 Thread Mike Pattrick
On Wed, Feb 14, 2024 at 12:09 PM David Marchand wrote: > > Hello Mike, > > On Mon, Feb 12, 2024 at 8:50 PM Mike Pattrick wrote: > > > > Previously if an OVS configuration nested multiple layers of UDP tunnels > > like VXLAN or GENEVE on top of each other through netdev-linux > > interfaces, the

Re: [ovs-dev] [PATCH v2 2/4] netdev-linux: Favour inner packet for multi-encapsulated TSO.

2024-02-14 Thread David Marchand
Hello Mike, On Mon, Feb 12, 2024 at 8:50 PM Mike Pattrick wrote: > > Previously if an OVS configuration nested multiple layers of UDP tunnels > like VXLAN or GENEVE on top of each other through netdev-linux > interfaces, the vnet header would be incorrectly set to the outermost > UDP tunnel

Re: [ovs-dev] [PATCH v2 2/4] netdev-linux: Favour inner packet for multi-encapsulated TSO.

2024-02-14 Thread Mike Pattrick
Note, this failed github CI with the following error message: ../../tests/testsuite: line 4034: ./atconfig: No such file or directory This appears to be a false negative. -M On Mon, Feb 12, 2024 at 2:50 PM Mike Pattrick wrote: > > Previously if an OVS configuration nested multiple layers of

[ovs-dev] [PATCH v2 2/4] netdev-linux: Favour inner packet for multi-encapsulated TSO.

2024-02-12 Thread Mike Pattrick
Previously if an OVS configuration nested multiple layers of UDP tunnels like VXLAN or GENEVE on top of each other through netdev-linux interfaces, the vnet header would be incorrectly set to the outermost UDP tunnel layer instead of the intermediary tunnel layer. This resulted in the middle UDP