> -Original Message-
> From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Justin Pettit
> Sent: Tuesday, August 6, 2019 8:28 AM
> To: Yi-Hung Wei
> Cc: ovs dev ; Alin Gabriel Serdean
>
> Subject: Re: [ovs-dev] [PATCH v2 4/9] ct
> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote:
>
> This patch also adds missing symbols in the windows datapath so
> that the build on windows can pass.
Alin, can you do a quick sanity-check on the Windows part? Thanks.
Yi-Hung, it looks good to me. Just mostly some minor stuff below.
>
Thanks for the patch
I am going to avoid commenting on style or code conciseness in the
interests of time
On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote:
> This patch first defines the dpif interface for a datapath to support
> adding, deleting, getting and dumping conntrack timeout policy.
>
Bleep bloop. Greetings Yi-Hung Wei, I am a robot and I have tried out your
patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
ERROR: Inappropriate bracing around statement
#543 FILE: lib/dpif-netlink.c:3154:
if (tp->pr
This patch first defines the dpif interface for a datapath to support
adding, deleting, getting and dumping conntrack timeout policy.
The timeout policy is identified by a 4 bytes unsigned integer in
datapath, and it currently support timeout for TCP, UDP, and ICMP
protocols.
Moreover, this patch
