Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-11 Thread Darrell Ball
On Fri, Aug 9, 2019 at 1:23 PM Justin Pettit wrote: > > > On Aug 7, 2019, at 11:40 AM, Darrell Ball wrote: > > > > There are 3 behaviors with the patchset that are datapath specific > > > > 1/ Unwildcarding of commit flows with timeout policies > > As we discussed, the userspace conntrack

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-09 Thread Justin Pettit
> On Aug 7, 2019, at 11:40 AM, Darrell Ball wrote: > > There are 3 behaviors with the patchset that are datapath specific > > 1/ Unwildcarding of commit flows with timeout policies > As we discussed, the userspace conntrack does not need to do this and > would not since it is suboptimal

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-07 Thread Darrell Ball
On Wed, Aug 7, 2019 at 11:51 AM Darrell Ball wrote: > > > On Wed, Aug 7, 2019 at 11:40 AM Darrell Ball wrote: > >> >> >> On Tue, Aug 6, 2019 at 9:57 PM Justin Pettit wrote: >> >>> >>> > On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote: >>> > >>> > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei >>>

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-07 Thread Darrell Ball
On Wed, Aug 7, 2019 at 11:40 AM Darrell Ball wrote: > > > On Tue, Aug 6, 2019 at 9:57 PM Justin Pettit wrote: > >> >> > On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote: >> > >> > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei >> wrote: >> > >> >> +struct ct_timeout_policy { >> >> +struct uuid

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-07 Thread Darrell Ball
On Tue, Aug 6, 2019 at 9:57 PM Justin Pettit wrote: > > > On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote: > > > > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote: > > > >> +struct ct_timeout_policy { > >> +struct uuid uuid; > >> +unsigned int last_used_seqno; > >> +struct

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-06 Thread Justin Pettit
> On Aug 5, 2019, at 8:07 PM, Darrell Ball wrote: > > On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote: > >> +struct ct_timeout_policy { >> +struct uuid uuid; >> +unsigned int last_used_seqno; >> +struct ct_dpif_timeout_policy cdtp; >> +struct cmap_node node; /*

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-06 Thread Justin Pettit
> On Aug 1, 2019, at 3:07 PM, Yi-Hung Wei wrote: > > diff --git a/ofproto/ofproto-dpif.c b/ofproto/ofproto-dpif.c > index 751535249e21..6336494e0bc8 100644 > --- a/ofproto/ofproto-dpif.c > +++ b/ofproto/ofproto-dpif.c > > +static struct ct_timeout_policy * > +ct_timeout_policy_alloc(struct

Re: [ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-05 Thread Darrell Ball
Thanks for the patch comments inline On Thu, Aug 1, 2019 at 3:10 PM Yi-Hung Wei wrote: > This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains > the zone-based timeout policy in the vswitchd. Whenever there is a > database change, vswitchd will read the datapath, CT_Zone, and

[ovs-dev] [PATCH v2 5/9] ofproto-dpif: Consume CT_Zone, and CT_Timeout_Policy tables

2019-08-01 Thread Yi-Hung Wei
This patch consumes the CT_Zone and CT_Timeout_Policy tables, maintains the zone-based timeout policy in the vswitchd. Whenever there is a database change, vswitchd will read the datapath, CT_Zone, and CT_Timeout_Policy tables from ovsdb to detect if the is any timeout policy changes. If a new