Re: [ovs-dev] [PATCH v2 ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-09 Thread Ilya Maximets
On 09.08.2019 10:11, Damijan Skvarc wrote: > According to comments I have: > - renamed function name to be "paired" with ovn_destroy_ovnfields > - replaced 0/1 bool values with false/true > > Signed-off-by: Damijan Skvarc This patch named "fix memory leak ...", but I don't see any leaks fixed

Re: [ovs-dev] [PATCH v2 ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-09 Thread Ilya Maximets
On 09.08.2019 10:11, Damijan Skvarc wrote: > According to comments I have: > - renamed function name to be "paired" with ovn_destroy_ovnfields > - replaced 0/1 bool values with false/true > > Signed-off-by: Damijan Skvarc > --- > lib/logical-fields.c | 10 +- > 1 file changed, 5

Re: [ovs-dev] [PATCH v2 ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-09 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: fatal: sha1 information is lacking or useless (lib/logical-fields.c). Repository lacks necessary

[ovs-dev] [PATCH v2 ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-09 Thread Damijan Skvarc
According to comments I have: - renamed function name to be "paired" with ovn_destroy_ovnfields - replaced 0/1 bool values with false/true Signed-off-by: Damijan Skvarc --- lib/logical-fields.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/logical-fields.c

Re: [ovs-dev] [PATCH v2 ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-07 Thread 0-day Robot
Bleep bloop. Greetings Damijan Skvarc, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. git-am: Failed to merge in the changes. Patch failed at 0001 logical-fields: fix memory leak while

[ovs-dev] [PATCH v2 ovn] logical-fields: fix memory leak while initializing ovnfield_by_name

2019-08-07 Thread Damijan Skvarc
fixed 0-day Robot issues Signed-off-by: Damijan Skvarc --- lib/logical-fields.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/logical-fields.c b/lib/logical-fields.c index 62b9a71..fdc78cf 100644 --- a/lib/logical-fields.c +++ b/lib/logical-fields.c @@ -57,9