Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-10-13 Thread Dumitru Ceara
On 10/12/21 9:24 PM, Ilya Maximets wrote: > Dumitru, sorry, I messed up and didn't include the suggested comment. > Feel free to submit a separate patch for that if you think it's needed. It was a nit, I'm not sure it's worth a separate patch. It's OK, thanks!

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-10-12 Thread Ilya Maximets
On 9/2/21 17:53, Dumitru Ceara wrote: > On 9/2/21 5:34 PM, Terry Wilson wrote: >> This ports the C IDL change f50714b to the Python IDL: >> >> Until now the code here would happily try to send transactions to the >> database server even if the database connection was not in the correct >> state.

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-10-12 Thread Ilya Maximets
On 10/12/21 15:56, Ilya Maximets wrote: > On 10/12/21 15:50, Terry Wilson wrote: >> On Mon, Sep 20, 2021 at 1:18 PM Ilya Maximets wrote: >>> >>> On 9/20/21 20:10, Terry Wilson wrote: The problem is that has_ever_connected() doesn't imply that we have downloaded the db into memory since

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-10-12 Thread Ilya Maximets
On 10/12/21 15:50, Terry Wilson wrote: > On Mon, Sep 20, 2021 at 1:18 PM Ilya Maximets wrote: >> >> On 9/20/21 20:10, Terry Wilson wrote: >>> The problem is that has_ever_connected() doesn't imply that we have >>> downloaded the db into memory since the _Server stuff was added. >> >> Hmm. That

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-10-12 Thread Terry Wilson
On Mon, Sep 20, 2021 at 1:18 PM Ilya Maximets wrote: > > On 9/20/21 20:10, Terry Wilson wrote: > > The problem is that has_ever_connected() doesn't imply that we have > > downloaded the db into memory since the _Server stuff was added. > > Hmm. That does sound like a bug to me.

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-09-20 Thread Ilya Maximets
On 9/20/21 20:10, Terry Wilson wrote: > The problem is that has_ever_connected() doesn't imply that we have > downloaded the db into memory since the _Server stuff was added. Hmm. That does sound like a bug to me. has_ever_connected() should reflect only changes in the actual database, not the

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-09-20 Thread Terry Wilson
The problem is that has_ever_connected() doesn't imply that we have downloaded the db into memory since the _Server stuff was added. On Mon, Sep 20, 2021 at 1:05 PM Ilya Maximets wrote: > > On 9/20/21 19:58, Terry Wilson wrote: > > On Mon, Sep 20, 2021 at 12:29 PM Ilya Maximets wrote: > >> > >>

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-09-20 Thread Ilya Maximets
On 9/20/21 19:58, Terry Wilson wrote: > On Mon, Sep 20, 2021 at 12:29 PM Ilya Maximets wrote: >> >> On 9/20/21 18:15, Terry Wilson wrote: >>> On Thu, Sep 2, 2021 at 10:53 AM Dumitru Ceara wrote: On 9/2/21 5:34 PM, Terry Wilson wrote: > This ports the C IDL change f50714b to the

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-09-20 Thread Ilya Maximets
On 9/20/21 19:58, Terry Wilson wrote: > On Mon, Sep 20, 2021 at 12:29 PM Ilya Maximets wrote: >> >> On 9/20/21 18:15, Terry Wilson wrote: >>> On Thu, Sep 2, 2021 at 10:53 AM Dumitru Ceara wrote: On 9/2/21 5:34 PM, Terry Wilson wrote: > This ports the C IDL change f50714b to the

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-09-20 Thread Terry Wilson
On Mon, Sep 20, 2021 at 12:29 PM Ilya Maximets wrote: > > On 9/20/21 18:15, Terry Wilson wrote: > > On Thu, Sep 2, 2021 at 10:53 AM Dumitru Ceara wrote: > >> > >> On 9/2/21 5:34 PM, Terry Wilson wrote: > >>> This ports the C IDL change f50714b to the Python IDL: > >>> > >>> Until now the code

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-09-20 Thread Ilya Maximets
On 9/20/21 18:15, Terry Wilson wrote: > On Thu, Sep 2, 2021 at 10:53 AM Dumitru Ceara wrote: >> >> On 9/2/21 5:34 PM, Terry Wilson wrote: >>> This ports the C IDL change f50714b to the Python IDL: >>> >>> Until now the code here would happily try to send transactions to the >>> database server

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-09-20 Thread Terry Wilson
On Thu, Sep 2, 2021 at 10:53 AM Dumitru Ceara wrote: > > On 9/2/21 5:34 PM, Terry Wilson wrote: > > This ports the C IDL change f50714b to the Python IDL: > > > > Until now the code here would happily try to send transactions to the > > database server even if the database connection was not in

Re: [ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-09-02 Thread Dumitru Ceara
On 9/2/21 5:34 PM, Terry Wilson wrote: > This ports the C IDL change f50714b to the Python IDL: > > Until now the code here would happily try to send transactions to the > database server even if the database connection was not in the correct > state. In some cases this could lead to strange

[ovs-dev] [PATCH v3] [python] Avoid sending transactions when the DB is not synced up

2021-09-02 Thread Terry Wilson
This ports the C IDL change f50714b to the Python IDL: Until now the code here would happily try to send transactions to the database server even if the database connection was not in the correct state. In some cases this could lead to strange behavior, such as sending a database transaction for