Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-04-12 Thread Eelco Chaudron
On 12 Apr 2024, at 9:31, LIU Yulong wrote: > Unfortunately, removed that "ovsrcu_quiesce();" the ovs-vswitchd > still went core: > root root 957M Apr 12 01:35 core.52305 > > But good news is with such change the core dump does not occur so frequently, > it's about 7 days. > > Core trace back:

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-04-12 Thread LIU Yulong
Unfortunately, removed that "ovsrcu_quiesce();" the ovs-vswitchd still went core: root root 957M Apr 12 01:35 core.52305 But good news is with such change the core dump does not occur so frequently, it's about 7 days. Core trace back: #0 0x7ff0cf7ab387 in raise () from /lib64/libc.so.6 #1

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-04-08 Thread Eelco Chaudron
On 7 Apr 2024, at 3:57, LIU Yulong wrote: > Hi Eelco, > > Sorry for the late reply. And thank you very much for your code examination. > > Today, I removed that "ovsrcu_quiesce();" at line 3066 [1], and > started to run the > test in my local environment. Let's see if such change can overcome

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-04-06 Thread LIU Yulong
Hi Eelco, Sorry for the late reply. And thank you very much for your code examination. Today, I removed that "ovsrcu_quiesce();" at line 3066 [1], and started to run the test in my local environment. Let's see if such change can overcome the issue. Regarding the long time lock or quiesce

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-03-22 Thread Eelco Chaudron
On 15 Mar 2024, at 11:04, LIU Yulong wrote: > A potential race condition happened with the following 3 threads: > * PMD thread replaced the old_ukey and transitioned the state to > UKEY_DELETED. > * RCU thread is freeing the old_ukey mutex. > * While the revalidator thread is trying to lock

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-03-21 Thread LIU Yulong
ACK Thanks, Ilya. For now, update such lock movement code to the test hosts, no cores at sweep__ for 10 days. LIU Yulong On Wed, Mar 20, 2024 at 5:42 AM Ilya Maximets wrote: > > On 3/15/24 11:04, LIU Yulong wrote: > > A potential race condition happened with the following 3 threads: > > * PMD

Re: [ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-03-19 Thread Ilya Maximets
On 3/15/24 11:04, LIU Yulong wrote: > A potential race condition happened with the following 3 threads: > * PMD thread replaced the old_ukey and transitioned the state to > UKEY_DELETED. > * RCU thread is freeing the old_ukey mutex. > * While the revalidator thread is trying to lock the old_ukey

[ovs-dev] [PATCH v3] ofproto-dpif-upcall: Try lock for udpif_key map during sweep.

2024-03-15 Thread LIU Yulong
A potential race condition happened with the following 3 threads: * PMD thread replaced the old_ukey and transitioned the state to UKEY_DELETED. * RCU thread is freeing the old_ukey mutex. * While the revalidator thread is trying to lock the old_ukey mutex. We added some timestamp to udpif_key