Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-17 Thread Roi Dayan via dev
On 16/10/2023 19:27, Mike Pattrick wrote: > On Mon, Oct 16, 2023 at 4:08 AM Roi Dayan via dev > wrote: >> >> >> On 16/10/2023 11:00, Roi Dayan wrote: >>> >>> On 16/10/2023 10:42, Eelco Chaudron wrote: On 16 Oct 2023, at 9:09, Roi Dayan wrote: > On 09/10/2023 15:05, Roi

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Mike Pattrick
On Mon, Oct 16, 2023 at 4:08 AM Roi Dayan via dev wrote: > > > On 16/10/2023 11:00, Roi Dayan wrote: > > > > On 16/10/2023 10:42, Eelco Chaudron wrote: > >> > >> > >> On 16 Oct 2023, at 9:09, Roi Dayan wrote: > >> > >>> On 09/10/2023 15:05, Roi Dayan wrote: > The cited commit fixed missing

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 16/10/2023 14:02, Eelco Chaudron wrote: > > > On 16 Oct 2023, at 12:52, Roi Dayan wrote: > >> On 16/10/2023 11:31, Eelco Chaudron wrote: >>> >>> >>> On 16 Oct 2023, at 10:07, Roi Dayan wrote: >>> On 16/10/2023 11:00, Roi Dayan wrote: > > On 16/10/2023 10:42, Eelco Chaudron

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Eelco Chaudron
On 16 Oct 2023, at 12:52, Roi Dayan wrote: > On 16/10/2023 11:31, Eelco Chaudron wrote: >> >> >> On 16 Oct 2023, at 10:07, Roi Dayan wrote: >> >>> On 16/10/2023 11:00, Roi Dayan wrote: On 16/10/2023 10:42, Eelco Chaudron wrote: > > > On 16 Oct 2023, at 9:09, Roi Dayan

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 16/10/2023 11:31, Eelco Chaudron wrote: > > > On 16 Oct 2023, at 10:07, Roi Dayan wrote: > >> On 16/10/2023 11:00, Roi Dayan wrote: >>> >>> On 16/10/2023 10:42, Eelco Chaudron wrote: On 16 Oct 2023, at 9:09, Roi Dayan wrote: > On 09/10/2023 15:05, Roi Dayan wrote:

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Eelco Chaudron
On 16 Oct 2023, at 10:07, Roi Dayan wrote: > On 16/10/2023 11:00, Roi Dayan wrote: >> >> On 16/10/2023 10:42, Eelco Chaudron wrote: >>> >>> >>> On 16 Oct 2023, at 9:09, Roi Dayan wrote: >>> On 09/10/2023 15:05, Roi Dayan wrote: > The cited commit fixed missing mirror packets by reset

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 16/10/2023 11:00, Roi Dayan wrote: > > On 16/10/2023 10:42, Eelco Chaudron wrote: >> >> >> On 16 Oct 2023, at 9:09, Roi Dayan wrote: >> >>> On 09/10/2023 15:05, Roi Dayan wrote: The cited commit fixed missing mirror packets by reset mirror when packets are modified but setting

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 16/10/2023 10:42, Eelco Chaudron wrote: > > > On 16 Oct 2023, at 9:09, Roi Dayan wrote: > >> On 09/10/2023 15:05, Roi Dayan wrote: >>> The cited commit fixed missing mirror packets by reset mirror when >>> packets are modified but setting geneve options was also treated as >>> a modified

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Eelco Chaudron
On 16 Oct 2023, at 9:09, Roi Dayan wrote: > On 09/10/2023 15:05, Roi Dayan wrote: >> The cited commit fixed missing mirror packets by reset mirror when >> packets are modified but setting geneve options was also treated as >> a modified packet but should be treated as a part of set_tunnel >>

Re: [ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-16 Thread Roi Dayan via dev
On 09/10/2023 15:05, Roi Dayan wrote: > The cited commit fixed missing mirror packets by reset mirror when > packets are modified but setting geneve options was also treated as > a modified packet but should be treated as a part of set_tunnel > which doesn't reset mirror. > > Fixes:

[ovs-dev] [PATCH v3 1/3] ofproto-dpif-upcall: Fix redundant mirror on geneve tunnel options.

2023-10-09 Thread Roi Dayan via dev
The cited commit fixed missing mirror packets by reset mirror when packets are modified but setting geneve options was also treated as a modified packet but should be treated as a part of set_tunnel which doesn't reset mirror. Fixes: feed7f677505 ("ofproto-dpif-upcall: Mirror packets that are