Re: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-14 Thread Yi-Hung Wei
On Wed, Aug 14, 2019 at 2:35 PM Darrell Ball wrote: > On Mon, Aug 12, 2019 at 5:54 PM Yi-Hung Wei wrote: >> --- a/lib/dpif-netlink.c >> +++ b/lib/dpif-netlink.c >> +static int >> +dpif_netlink_ct_set_timeout_policy(struct dpif *dpif OVS_UNUSED, >> + const struct

Re: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-14 Thread Darrell Ball
Thanks for the patch mostly minor comments On Mon, Aug 12, 2019 at 5:54 PM Yi-Hung Wei wrote: > This patch first defines the dpif interface for a datapath to support > adding, deleting, getting and dumping conntrack timeout policy. > The timeout policy is identified by a 4 bytes unsigned

Re: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-13 Thread Yi-Hung Wei
On Tue, Aug 13, 2019 at 4:25 AM wrote: > > --- > > Documentation/faq/releases.rst | 3 +- > > datapath-windows/include/OvsDpInterfaceCtExt.h | 114 + > > datapath-windows/ovsext/Netlink/NetlinkProto.h | 8 +- > > include/windows/automake.mk

Re: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-13 Thread aserdean
> -Original Message- > From: ovs-dev-boun...@openvswitch.org boun...@openvswitch.org> On Behalf Of Yi-Hung Wei > Sent: Tuesday, August 13, 2019 3:52 AM > To: d...@openvswitch.org > Subject: [ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack > t

[ovs-dev] [PATCH v3 4/9] ct-dpif, dpif-netlink: Add conntrack timeout policy support

2019-08-12 Thread Yi-Hung Wei
This patch first defines the dpif interface for a datapath to support adding, deleting, getting and dumping conntrack timeout policy. The timeout policy is identified by a 4 bytes unsigned integer in datapath, and it currently support timeout for TCP, UDP, and ICMP protocols. Moreover, this patch