Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

aff > ; Jan Scheurich ; Gray, Mark D > > Subject: Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath > by computing the recirculate actions at translate time. > > On 26 May 2017 at 10:42, Chandran, Sugesh > wrote: > > > > > > Regards > >

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Sugesh ; Andy Zhou >> ; William Tu ; >> gvrose8...@gmail.com; ovs dev ; Ben Pfaff >> ; Jan Scheurich ; Gray, Mark D >> >> Subject: RE: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath >> by computing the recirculate actions at translate time. >> &

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 26 May 2017 at 07:00, Zoltán Balogh wrote: > > Hi Joe, > >> Backing up a bit for context, the stats attribution goes roughly like this: >> * First upcall, handler thread calls through the translate code with a >> packet. The resubmit_stats are derived from that packet. This goes >> through xlat

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Scheurich ; Gray, Mark D > > Subject: RE: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath > by computing the recirculate actions at translate time. > > > Hi Joe, > > > Backing up a bit for context, the stats attribution goes roughly like this: > > *

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Hi Joe, > Backing up a bit for context, the stats attribution goes roughly like this: > * First upcall, handler thread calls through the translate code with a > packet. The resubmit_stats are derived from that packet. This goes > through xlate_actions(). > * First dump of flow from revalidator th

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 17 May 2017 at 04:37, Zoltán Balogh wrote: > Hi Joe > > I started to rework my patch based on your comments and suggestions. I had > some > difficulties with the last one. Let us focus on this below. > >> >> > if (credit_counts) { >> >> > +uint64_t stats_n_bytes = 0; >> >> > + >>

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Hi Joe I started to rework my patch based on your comments and suggestions. I had some difficulties with the last one. Let us focus on this below. > >> > if (credit_counts) { > >> > +uint64_t stats_n_bytes = 0; > >> > + > >> > +if (rule->truncated_packet_size) { > >> > +

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 5/11/17, 7:31 AM, "William Tu" wrote: On Wed, May 10, 2017 at 11:04 AM, Darrell Ball wrote: > What are the use case(s) of truncate “outside” of sampling/mirroring ? > The use of truncation in the context of sampling/mirroring is well known. > I don't know any other use c

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On Thu, May 11, 2017 at 9:12 AM, Joe Stringer wrote: > On 10 May 2017 at 17:08, Andy Zhou wrote: >> On Wed, May 10, 2017 at 2:30 PM, Joe Stringer wrote: >>> On 10 May 2017 at 12:59, Andy Zhou wrote: On Wed, May 10, 2017 at 7:56 AM, William Tu wrote: >> It may be cleaner if we add a ne

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On Thu, May 11, 2017 at 7:57 AM, William Tu wrote: > [snip] Picking up the topic of trunc on patch port. Instead of banning trunc output to a patch port, any down side of translating that to trunc, clone()? After all, native tunneling looks a lot like patch port conce

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 11 May 2017 at 09:04, Zoltán Balogh wrote: > Hi Joe, > > Thank you for your comments! Please, find my answers below. > >> I had trouble trying to review this, in part because I felt like >> changes to fix multiple issues are being placed into one patch. If >> there are separate issues being add

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 10 May 2017 at 17:08, Andy Zhou wrote: > On Wed, May 10, 2017 at 2:30 PM, Joe Stringer wrote: >> On 10 May 2017 at 12:59, Andy Zhou wrote: >>> On Wed, May 10, 2017 at 7:56 AM, William Tu wrote: > It may be cleaner if we add a new trunc action for the datapath, say > trunc2 that appl

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Hi Joe, Thank you for your comments! Please, find my answers below. > I had trouble trying to review this, in part because I felt like > changes to fix multiple issues are being placed into one patch. If > there are separate issues being addressed, each issue should be fixed > in a separate patc

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

[snip] >>> Picking up the topic of trunc on patch port. >>> >>> Instead of banning trunc output to a patch port, any down side of >>> translating that >>> to trunc, clone()? After all, native tunneling >>> looks a lot like patch port conceptually. >> >> How does clone() interact with trunc() in the

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On Wed, May 10, 2017 at 11:04 AM, Darrell Ball wrote: > What are the use case(s) of truncate “outside” of sampling/mirroring ? > The use of truncation in the context of sampling/mirroring is well known. > I don't know any other use cases outside sampling/mirroring. Truncate the current packet, se

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On Wed, May 10, 2017 at 2:30 PM, Joe Stringer wrote: > On 10 May 2017 at 12:59, Andy Zhou wrote: >> On Wed, May 10, 2017 at 7:56 AM, William Tu wrote: It may be cleaner if we add a new trunc action for the datapath, say trunc2 that applies to all outputs within the clone. >>

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> > On May 10, 2017, at 12:59 PM, Andy Zhou > wrote: > > On Wed, May 10, 2017 at 7:56 AM, William Tu > wrote: >>> It may be cleaner if we add a new trunc action for the datapath, say >>> trunc2 that applies >>> to all outputs within the clone. >

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> On May 10, 2017, at 12:59 PM, Andy Zhou wrote: > > On Wed, May 10, 2017 at 7:56 AM, William Tu > wrote: >>> It may be cleaner if we add a new trunc action for the datapath, say >>> trunc2 that applies >>> to all outputs within the clone. >>> >>> So the translation

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 10 May 2017 at 12:59, Andy Zhou wrote: > On Wed, May 10, 2017 at 7:56 AM, William Tu wrote: >>> It may be cleaner if we add a new trunc action for the datapath, say >>> trunc2 that applies >>> to all outputs within the clone. >>> >>> So the translation will look like: clone(trunc2, native tun

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On Wed, May 10, 2017 at 7:56 AM, William Tu wrote: >> It may be cleaner if we add a new trunc action for the datapath, say >> trunc2 that applies >> to all outputs within the clone. >> >> So the translation will look like: clone(trunc2, native tunnel >> translation). Would this >> approach work?

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 9 May 2017 at 04:46, Zoltán Balogh wrote: > Hi, > > Thank you for your comments. Actually, I was wrong in my previous e-mail when > I stated that packet is truncated only at the end of the pipeline, when > output is applied. The packet size is set according max_len set by truncate > when tun

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

What are the use case(s) of truncate “outside” of sampling/mirroring ? The use of truncation in the context of sampling/mirroring is well known. On 5/10/17, 7:56 AM, "ovs-dev-boun...@openvswitch.org on behalf of William Tu" wrote: > It may be cleaner if we add a new trunc action for the da

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> It may be cleaner if we add a new trunc action for the datapath, say > trunc2 that applies > to all outputs within the clone. > > So the translation will look like: clone(trunc2, native tunnel > translation). Would this > approach work? > Or how about we apply actual packet truncation when clon

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Hi, Thank you for your comments. Actually, I was wrong in my previous e-mail when I stated that packet is truncated only at the end of the pipeline, when output is applied. The packet size is set according max_len set by truncate when tunnel_push is applied. So the size of packet is correct. T

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

that motivates trunc2, which should have the normal datapath action behavior. > Best regards, > Zoltan > > >> -----Original Message- >> From: William Tu [mailto:u9012...@gmail.com] >> Sent: Monday, May 08, 2017 4:55 PM >> To: Zoltán Balogh >> Cc: Joe St

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

ilto:u9012...@gmail.com] > Sent: Monday, May 08, 2017 4:55 PM > To: Zoltán Balogh > Cc: Joe Stringer ; Sugesh Chandran ; > ovs dev ; Ben > Pfaff ; Andy Zhou ; Jan Scheurich > > Subject: Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath > by computing th

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

t;> Cc: Sugesh Chandran ; ovs dev >> ; Ben Pfaff ; Andy Zhou >> ; Jan Scheurich >> Subject: RE: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath >> by computing the recirculate actions at >> translate time. >> >> > >> I have a

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> ; Jan Scheurich > Subject: RE: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath > by computing the recirculate actions at > translate time. > > > >> I have a patch that fixes tunneling over patch ports. The 14th > > >> system-userspace

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> >> I have a patch that fixes tunneling over patch ports. The 14th > >> system-userspace > >> test still does fail, but now the packet size in the dump flow remains 242. > >> > >> ./system-traffic.at:554: ovs-ofctl dump-flows br0 | grep "in_port=2" | sed > >> -n 's/.*\(n\_bytes=[0-9]*\).*/\1/p'

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 5 May 2017 at 11:50, Joe Stringer wrote: > On 5 May 2017 at 10:54, Zoltán Balogh wrote: >> Hi, >> >>> Thanks for taking a look. Andy and I have been throwing some thoughts >>> around about this, but I'm not sure we came to a concrete solution yet >>> either. My main thought is that I think tha

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 5 May 2017 at 10:54, Zoltán Balogh wrote: > Hi, > >> Thanks for taking a look. Andy and I have been throwing some thoughts >> around about this, but I'm not sure we came to a concrete solution yet >> either. My main thought is that I think that the 'flow' needs to be >> modified in the similar

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Hi, > Thanks for taking a look. Andy and I have been throwing some thoughts > around about this, but I'm not sure we came to a concrete solution yet > either. My main thought is that I think that the 'flow' needs to be > modified in the similar way that the 'push_tnl' would work in the > datapat

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

TCH v5] tunneling: Avoid recirculation on datapath > by computing the recirculate actions at translate time. > > Hi Joe, > > > Thanks for taking a look. Andy and I have been throwing some thoughts > > around about this, but I'm not sure we came to a concrete solution yet >

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Hi Joe, > Thanks for taking a look. Andy and I have been throwing some thoughts > around about this, but I'm not sure we came to a concrete solution yet > either. My main thought is that I think that the 'flow' needs to be > modified in the similar way that the 'push_tnl' would work in the > datap

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 4 May 2017 at 04:39, Zoltán Balogh wrote: >> I think that what's happening is that when build_tunnel_send() >> serializes the ODP action for push_tunnel, it doesn't update the >> 'flow' to reflect the new encapsulated state of the packet. Then, when >> calling apply_nested_clone_actions() it pe

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On Thu, May 4, 2017 at 4:39 AM, Zoltán Balogh wrote: >> I think that what's happening is that when build_tunnel_send() >> serializes the ODP action for push_tunnel, it doesn't update the >> 'flow' to reflect the new encapsulated state of the packet. Then, when >> calling apply_nested_clone_actions

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

> I think that what's happening is that when build_tunnel_send() > serializes the ODP action for push_tunnel, it doesn't update the > 'flow' to reflect the new encapsulated state of the packet. Then, when > calling apply_nested_clone_actions() it performs lookup in the second > bridge using the unm

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

On 11 April 2017 at 03:14, Sugesh Chandran wrote: > Openvswitch datapath recirculates packets for tunneling, i.e. > the incoming packets are encapsulated at first pass. Further actions are > applied on encapsulated packets on the second pass after recirculating. > The proposed patch compute and ap

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Thanks for keeping this going! I applied it to master. On Thu, Apr 13, 2017 at 08:25:07AM +, Chandran, Sugesh wrote: > Can anyone have a look on this patch?? > > Regards > _Sugesh > > > > -Original Message- > > From: Chandran, Sugesh > > Sent: Tuesday, April 11, 2017 11:14 AM > > T

Re: [ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Can anyone have a look on this patch?? Regards _Sugesh > -Original Message- > From: Chandran, Sugesh > Sent: Tuesday, April 11, 2017 11:14 AM > To: d...@openvswitch.org; b...@ovn.org > Cc: Chandran, Sugesh ; Zoltán Balogh > > Subject: [PATCH v5] tunneling: Avoid recirculation on datapat

[ovs-dev] [PATCH v5] tunneling: Avoid recirculation on datapath by computing the recirculate actions at translate time.

Openvswitch datapath recirculates packets for tunneling, i.e. the incoming packets are encapsulated at first pass. Further actions are applied on encapsulated packets on the second pass after recirculating. The proposed patch compute and append the post tunnel actions at the time of translation its