Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-06 Thread Ilya Maximets
On 05.09.2019 9:58, Sriram Vatala wrote: > Hi Ilya, > Thanks a lot for the explanation. As per your suggestion, I will move all the > counters (including 'tx_retries')to some structure and place a pointer to it > in netdev_dpdk structure so that the padding size will not vary with the >

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-05 Thread Sriram Vatala via dev
Hi Ilya, Thanks a lot for the explanation. As per your suggestion, I will move all the counters (including 'tx_retries')to some structure and place a pointer to it in netdev_dpdk structure so that the padding size will not vary with the introduction of new counters in future. @Kevin Traynor :

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-04 Thread Kevin Traynor
On 04/09/2019 15:03, Ilya Maximets wrote: > On 04.09.2019 16:31, Sriram Vatala wrote: >> Hi Ilya, >> 1) I was working on addressing the comments provided by you. Had a small >> query >> on one of your comments. >> 2) I am trying to understand the problem of padding bytes in struct >>

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-04 Thread Ilya Maximets
On 04.09.2019 16:31, Sriram Vatala wrote: > Hi Ilya, > 1) I was working on addressing the comments provided by you. Had a small > query > on one of your comments. > 2) I am trying to understand the problem of padding bytes in struct > netdev_dpdk which you are referring to in your comment. > 3)

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-04 Thread Sriram Vatala via dev
Hi Ilya, 1) I was working on addressing the comments provided by you. Had a small query on one of your comments. 2) I am trying to understand the problem of padding bytes in struct netdev_dpdk which you are referring to in your comment. 3) If I understand correctly, the macro

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-09-02 Thread Sriram Vatala via dev
Hi Ilya, Thanks for reviewing the patch and suggestions. Will address your comments in next patch. Thanks & Regards, Sriram. -Original Message- From: Ilya Maximets Sent: 30 August 2019 18:53 To: Sriram Vatala ; ovs-dev@openvswitch.org Cc: b...@ovn.org; ian.sto...@intel.com; Kevin

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-30 Thread Ilya Maximets
On 28.08.2019 15:58, Sriram Vatala wrote: > OVS may be unable to transmit packets for multiple reasons and > today there is a single counter to track packets dropped due to > any of those reasons. The most common reason is that a VM is > unable to read packets fast enough causing the vhostuser

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-30 Thread Sriram Vatala via dev
Hi All, Please consider this as a gentle remainder. Thanks & Regards, Sriram. -Original Message- From: Sriram Vatala Sent: 28 August 2019 18:29 To: ovs-dev@openvswitch.org; i.maxim...@samsung.com Cc: b...@ovn.org; ian.sto...@intel.com; Sriram Vatala Subject: [PATCH v7] Detailed packet

Re: [ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-28 Thread 0-day Robot
Bleep bloop. Greetings Sriram Vatala via dev, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line is 138 characters long (recommended limit is 79) #351 FILE:

[ovs-dev] [PATCH v7] Detailed packet drop statistics per dpdk and vhostuser ports

2019-08-28 Thread Sriram Vatala via dev
OVS may be unable to transmit packets for multiple reasons and today there is a single counter to track packets dropped due to any of those reasons. The most common reason is that a VM is unable to read packets fast enough causing the vhostuser port transmit queue on the OVS side to become full.