Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 11:09, Jakob Meng wrote: > On 15.03.24 11:15, Eelco Chaudron wrote: >> [...] >> Hi Jakob, >> >> >> Thank you for submitting this series; I believe it's a valuable addition to >> OVS! Apologies for the delayed response. I've reviewed the entire series, >> and most of the

Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

2024-03-19 Thread Jakob Meng
On 15.03.24 11:15, Eelco Chaudron wrote: > [...] > Hi Jakob, > > > Thank you for submitting this series; I believe it's a valuable addition to > OVS! Apologies for the delayed response. I've reviewed the entire series, and > most of the comments are minor change requests. I'll hold off on

Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

2024-03-15 Thread Eelco Chaudron
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > From: Jakob Meng > > For monitoring systems such as Prometheus it would be beneficial if > OVS would expose statistics in a machine-readable format. > > This patch introduces support for different output formats to ovs-xxx > tools. They gain a

Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

2024-01-19 Thread Simon Horman
On Thu, Jan 18, 2024 at 04:39:56PM +, Simon Horman wrote: > On Thu, Jan 18, 2024 at 04:26:52PM +0100, jm...@redhat.com wrote: > > From: Jakob Meng > > > > For monitoring systems such as Prometheus it would be beneficial if > > OVS would expose statistics in a machine-readable format. > >

Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

2024-01-18 Thread Simon Horman
On Thu, Jan 18, 2024 at 04:26:52PM +0100, jm...@redhat.com wrote: > From: Jakob Meng > > For monitoring systems such as Prometheus it would be beneficial if > OVS would expose statistics in a machine-readable format. ... Recheck-request: github-robot

Re: [ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

2024-01-18 Thread 0-day Robot
Bleep bloop. Greetings Jakob Meng, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator WARNING: Line lacks whitespace around operator

[ovs-dev] [PATCH v7 1/6] Add global option for JSON output to ovs-appctl.

2024-01-18 Thread jmeng
From: Jakob Meng For monitoring systems such as Prometheus it would be beneficial if OVS would expose statistics in a machine-readable format. This patch introduces support for different output formats to ovs-xxx tools. They gain a global option '-f,--format' which allows users to request JSON