Re: [ovs-dev] [PATCH v7 2/2] rhel: Enable USDT scripts by default in Fedora builds

2024-01-26 Thread Aaron Conole 
Simon Horman  writes:

> On Thu, Jan 25, 2024 at 12:05:30PM -0500, Aaron Conole wrote:
>> All supported versions of Fedora do package libbpf, so it
>> makes sense to enable USDT support.
>> 
>> Signed-off-by: Aaron Conole 
>> ---
>>  rhel/openvswitch-fedora.spec.in | 5 +
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/rhel/openvswitch-fedora.spec.in 
>> b/rhel/openvswitch-fedora.spec.in
>> index 5d24ebcda8..3d9afeac59 100644
>> --- a/rhel/openvswitch-fedora.spec.in
>> +++ b/rhel/openvswitch-fedora.spec.in
>> @@ -28,6 +28,8 @@
>>  %bcond_with dpdk
>>  # To disable AF_XDP support, specify '--without afxdp' when building
>>  %bcond_without afxdp
>> +# To control the USDT support
>> +%bcond_without usdt
>>  
>>  # If there is a need to automatically enable the package after installation,
>>  # specify the "--with autoenable"
>> @@ -173,6 +175,9 @@ This package provides IPsec tunneling support for OVS 
>> tunnels.
>>  --enable-afxdp \
>>  %else
>>  --disable-afxdp \
>> +%endif
>> +%if %{with usdt}
>> +--enable-usdt-probes \
>>  %endif
>>  --enable-ssl \
>>  --disable-static \
>
> Hi Aaron,
>
> Our mutual friend ovsrobot didn't seem to like this one :(
>
>  configure: error: unable to find sys/sdt.h needed for USDT support
> error: Bad exit status from /var/tmp/rpm-tmp.pNLYFp (%build)
> Macro expanded in comment on line 23: %define kernel 
> 2.6.40.4-5.fc15.x86_64
>
> Bad exit status from /var/tmp/rpm-tmp.pNLYFp (%build)
>
> Link: https://github.com/ovsrobot/ovs/actions/runs/7658135907/job/20870414014

Thanks - fixed in v8

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v7 2/2] rhel: Enable USDT scripts by default in Fedora builds

2024-01-26 Thread Simon Horman 
On Thu, Jan 25, 2024 at 12:05:30PM -0500, Aaron Conole wrote:
> All supported versions of Fedora do package libbpf, so it
> makes sense to enable USDT support.
> 
> Signed-off-by: Aaron Conole 
> ---
>  rhel/openvswitch-fedora.spec.in | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
> index 5d24ebcda8..3d9afeac59 100644
> --- a/rhel/openvswitch-fedora.spec.in
> +++ b/rhel/openvswitch-fedora.spec.in
> @@ -28,6 +28,8 @@
>  %bcond_with dpdk
>  # To disable AF_XDP support, specify '--without afxdp' when building
>  %bcond_without afxdp
> +# To control the USDT support
> +%bcond_without usdt
>  
>  # If there is a need to automatically enable the package after installation,
>  # specify the "--with autoenable"
> @@ -173,6 +175,9 @@ This package provides IPsec tunneling support for OVS 
> tunnels.
>  --enable-afxdp \
>  %else
>  --disable-afxdp \
> +%endif
> +%if %{with usdt}
> +--enable-usdt-probes \
>  %endif
>  --enable-ssl \
>  --disable-static \

Hi Aaron,

Our mutual friend ovsrobot didn't seem to like this one :(

 configure: error: unable to find sys/sdt.h needed for USDT support
error: Bad exit status from /var/tmp/rpm-tmp.pNLYFp (%build)
Macro expanded in comment on line 23: %define kernel 2.6.40.4-5.fc15.x86_64

Bad exit status from /var/tmp/rpm-tmp.pNLYFp (%build)

Link: https://github.com/ovsrobot/ovs/actions/runs/7658135907/job/20870414014

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v7 2/2] rhel: Enable USDT scripts by default in Fedora builds

2024-01-25 Thread 0-day Robot 
Bleep bloop.  Greetings Aaron Conole, I am a robot and I have tried out your 
patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: The subject summary should end with a dot.
Subject: rhel: Enable USDT scripts by default in Fedora builds
Lines checked: 40, Warnings: 1, Errors: 0


Please check this out.  If you feel there has been an error, please email 
acon...@redhat.com

Thanks,
0-day Robot
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev

[ovs-dev] [PATCH v7 2/2] rhel: Enable USDT scripts by default in Fedora builds

2024-01-25 Thread Aaron Conole 
All supported versions of Fedora do package libbpf, so it
makes sense to enable USDT support.

Signed-off-by: Aaron Conole 
---
 rhel/openvswitch-fedora.spec.in | 5 +
 1 file changed, 5 insertions(+)

diff --git a/rhel/openvswitch-fedora.spec.in b/rhel/openvswitch-fedora.spec.in
index 5d24ebcda8..3d9afeac59 100644
--- a/rhel/openvswitch-fedora.spec.in
+++ b/rhel/openvswitch-fedora.spec.in
@@ -28,6 +28,8 @@
 %bcond_with dpdk
 # To disable AF_XDP support, specify '--without afxdp' when building
 %bcond_without afxdp
+# To control the USDT support
+%bcond_without usdt
 
 # If there is a need to automatically enable the package after installation,
 # specify the "--with autoenable"
@@ -173,6 +175,9 @@ This package provides IPsec tunneling support for OVS 
tunnels.
 --enable-afxdp \
 %else
 --disable-afxdp \
+%endif
+%if %{with usdt}
+--enable-usdt-probes \
 %endif
 --enable-ssl \
 --disable-static \
-- 
2.41.0

___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev