Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-20 Thread Jakob Meng
On 19.03.24 16:41, Eelco Chaudron wrote: > > On 19 Mar 2024, at 16:19, Ilya Maximets wrote: > >> On 3/19/24 15:54, Eelco Chaudron wrote: >>> >>> On 19 Mar 2024, at 15:46, Ilya Maximets wrote: >>> On 3/19/24 15:17, Eelco Chaudron wrote: > > On 19 Mar 2024, at 15:00, Ilya Maximets

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 16:19, Ilya Maximets wrote: > On 3/19/24 15:54, Eelco Chaudron wrote: >> >> >> On 19 Mar 2024, at 15:46, Ilya Maximets wrote: >> >>> On 3/19/24 15:17, Eelco Chaudron wrote: On 19 Mar 2024, at 15:00, Ilya Maximets wrote: > On 3/19/24 14:41, Jakob Meng

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Ilya Maximets
On 3/19/24 15:54, Eelco Chaudron wrote: > > > On 19 Mar 2024, at 15:46, Ilya Maximets wrote: > >> On 3/19/24 15:17, Eelco Chaudron wrote: >>> >>> >>> On 19 Mar 2024, at 15:00, Ilya Maximets wrote: >>> On 3/19/24 14:41, Jakob Meng wrote: > > > On 19.03.24 13:22, Ilya Maximets

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 15:46, Ilya Maximets wrote: > On 3/19/24 15:17, Eelco Chaudron wrote: >> >> >> On 19 Mar 2024, at 15:00, Ilya Maximets wrote: >> >>> On 3/19/24 14:41, Jakob Meng wrote: On 19.03.24 13:22, Ilya Maximets wrote: > On 3/19/24 13:21, Ilya Maximets wrote: >>

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Ilya Maximets
On 3/19/24 15:17, Eelco Chaudron wrote: > > > On 19 Mar 2024, at 15:00, Ilya Maximets wrote: > >> On 3/19/24 14:41, Jakob Meng wrote: >>> >>> >>> On 19.03.24 13:22, Ilya Maximets wrote: On 3/19/24 13:21, Ilya Maximets wrote: > On 3/19/24 13:17, Eelco Chaudron wrote: >> >> On 19

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 15:00, Ilya Maximets wrote: > On 3/19/24 14:41, Jakob Meng wrote: >> >> >> On 19.03.24 13:22, Ilya Maximets wrote: >>> On 3/19/24 13:21, Ilya Maximets wrote: On 3/19/24 13:17, Eelco Chaudron wrote: > > On 19 Mar 2024, at 13:11, Jakob Meng wrote: > >> Hi!

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Ilya Maximets
On 3/19/24 14:41, Jakob Meng wrote: > > > On 19.03.24 13:22, Ilya Maximets wrote: >> On 3/19/24 13:21, Ilya Maximets wrote: >>> On 3/19/24 13:17, Eelco Chaudron wrote: On 19 Mar 2024, at 13:11, Jakob Meng wrote: > Hi! > > On 15.03.24 11:19, Eelco Chaudron wrote: >>

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Jakob Meng
On 19.03.24 13:22, Ilya Maximets wrote: > On 3/19/24 13:21, Ilya Maximets wrote: >> On 3/19/24 13:17, Eelco Chaudron wrote: >>> >>> On 19 Mar 2024, at 13:11, Jakob Meng wrote: >>> Hi! On 15.03.24 11:19, Eelco Chaudron wrote: > On 18 Jan 2024, at 16:26, jm...@redhat.com wrote:

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Ilya Maximets
On 3/19/24 13:21, Ilya Maximets wrote: > On 3/19/24 13:17, Eelco Chaudron wrote: >> >> >> On 19 Mar 2024, at 13:11, Jakob Meng wrote: >> >>> Hi! >>> >>> On 15.03.24 11:19, Eelco Chaudron wrote: On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > ... Thank for the patch! What a

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Ilya Maximets
On 3/19/24 13:17, Eelco Chaudron wrote: > > > On 19 Mar 2024, at 13:11, Jakob Meng wrote: > >> Hi! >> >> On 15.03.24 11:19, Eelco Chaudron wrote: >>> On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: >>> ... >>> Thank for the patch! What a beast to go trough ;) >> >> Thank you for doing it

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Eelco Chaudron
On 19 Mar 2024, at 13:11, Jakob Meng wrote: > Hi! > > On 15.03.24 11:19, Eelco Chaudron wrote: >> On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: >> >>> ... >> Thank for the patch! What a beast to go trough ;) > > Thank you for doing it anyway ☺️ > >> I believe the current approach is

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-03-19 Thread Jakob Meng
Hi! On 15.03.24 11:19, Eelco Chaudron wrote: > On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > >> ... > Thank for the patch! What a beast to go trough ;) Thank you for doing it anyway ☺️ > I believe the current approach is acceptable. However, we could also > incorporate union callbacks: if

Re: [ovs-dev] [PATCH v7 3/6] Migrate commands to extended unixctl API.

2024-01-18 Thread Simon Horman
On Thu, Jan 18, 2024 at 04:26:54PM +0100, jm...@redhat.com wrote: > From: Jakob Meng > > Previous commits introduced support different output formats to > ovs-xxx tools and its Python equivalents. However, the commands > were not yet migrated to the updated {unixctl_}command_register() >