Re: [ovs-dev] [PATCH v7 5/6] appctl: Add option '--pretty' for pretty-printing JSON output.

2024-03-19 Thread Ilya Maximets
On 3/15/24 11:27, Eelco Chaudron wrote: > On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > >> From: Jakob Meng >> diff --git a/lib/unixctl.h b/lib/unixctl.h >> index 35ef6a548..fe9160894 100644 >> --- a/lib/unixctl.h >> +++ b/lib/unixctl.h >> @@ -39,6 +39,7 @@ int unixctl_client_create(const

Re: [ovs-dev] [PATCH v7 5/6] appctl: Add option '--pretty' for pretty-printing JSON output.

2024-03-15 Thread Eelco Chaudron
On 18 Jan 2024, at 16:26, jm...@redhat.com wrote: > From: Jakob Meng > > Signed-off-by: Jakob Meng Some comments below and you might want to add a commit message to this patch. //Eelco > --- > NEWS | 3 +++ > lib/unixctl.c | 4 ++-- > lib/unixctl.h | 1

[ovs-dev] [PATCH v7 5/6] appctl: Add option '--pretty' for pretty-printing JSON output.

2024-01-18 Thread jmeng
From: Jakob Meng Signed-off-by: Jakob Meng --- NEWS | 3 +++ lib/unixctl.c | 4 ++-- lib/unixctl.h | 1 + tests/pmd.at | 29 +++-- utilities/ovs-appctl.c | 22 +++--- 5 files changed, 52 insertions(+), 7