Re: [ovs-dev] [PATCH v8 04/13] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

2018-06-26 Thread Ilya Maximets
On 26.06.2018 15:32, Eelco Chaudron wrote: > > > On 26 Jun 2018, at 12:02, Ilya Maximets wrote: > >> On 26.06.2018 12:19, Eelco Chaudron wrote: >>> >>> >>> On 22 Jun 2018, at 21:03, Lam, Tiago wrote: >>> On 18/06/2018 12:28, Eelco Chaudron wrote: > > > On 11 Jun 2018, at 18:21,

Re: [ovs-dev] [PATCH v8 04/13] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

2018-06-26 Thread Eelco Chaudron
On 26 Jun 2018, at 12:02, Ilya Maximets wrote: On 26.06.2018 12:19, Eelco Chaudron wrote: On 22 Jun 2018, at 21:03, Lam, Tiago wrote: On 18/06/2018 12:28, Eelco Chaudron wrote: On 11 Jun 2018, at 18:21, Tiago Lam wrote: A new mutex, 'nonpmd_mp_mutex', has been introduced to

Re: [ovs-dev] [PATCH v8 04/13] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

2018-06-26 Thread Ilya Maximets
On 26.06.2018 12:19, Eelco Chaudron wrote: > > > On 22 Jun 2018, at 21:03, Lam, Tiago wrote: > >> On 18/06/2018 12:28, Eelco Chaudron wrote: >>> >>> >>> On 11 Jun 2018, at 18:21, Tiago Lam wrote: >>> A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise allocation and free

Re: [ovs-dev] [PATCH v8 04/13] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

2018-06-26 Thread Eelco Chaudron
On 22 Jun 2018, at 21:03, Lam, Tiago wrote: On 18/06/2018 12:28, Eelco Chaudron wrote: On 11 Jun 2018, at 18:21, Tiago Lam wrote: A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise allocation and free operations by non-pmd threads on a given mempool. Can you explain

Re: [ovs-dev] [PATCH v8 04/13] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

2018-06-22 Thread Lam, Tiago
On 18/06/2018 12:28, Eelco Chaudron wrote: > > > On 11 Jun 2018, at 18:21, Tiago Lam wrote: > >> A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise >> allocation and free operations by non-pmd threads on a given mempool. >> > > Can you explain why we need the mutex here? Can't

Re: [ovs-dev] [PATCH v8 04/13] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

2018-06-18 Thread Eelco Chaudron
On 11 Jun 2018, at 18:21, Tiago Lam wrote: A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise allocation and free operations by non-pmd threads on a given mempool. Can you explain why we need the mutex here? Can't see any reason why rte_pktmbuf_free() needs to be protected

[ovs-dev] [PATCH v8 04/13] netdev-dpdk: Serialise non-pmds mbufs' alloc/free.

2018-06-11 Thread Tiago Lam
A new mutex, 'nonpmd_mp_mutex', has been introduced to serialise allocation and free operations by non-pmd threads on a given mempool. free_dpdk_buf() has been modified to make use of the introduced mutex. Signed-off-by: Tiago Lam --- lib/netdev-dpdk.c | 21 - 1 file