Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

2019-07-02 Thread Ian Stokes
On 7/2/2019 4:02 PM, Van Haaren, Harry wrote: -Original Message- From: Stokes, Ian Sent: Tuesday, July 2, 2019 3:40 PM To: Van Haaren, Harry ; ovs-dev@openvswitch.org Cc: i.maxim...@samsung.com Subject: Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable On 5

Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

2019-07-02 Thread Van Haaren, Harry
> -Original Message- > From: Stokes, Ian > Sent: Tuesday, July 2, 2019 3:40 PM > To: Van Haaren, Harry ; ovs-dev@openvswitch.org > Cc: i.maxim...@samsung.com > Subject: Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function > pointers/subtable > > On 5/

Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

2019-07-02 Thread Ian Stokes
On 5/15/2019 6:02 PM, Ian Stokes wrote: On 5/8/2019 4:13 PM, Harry van Haaren wrote: This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry

Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

2019-05-20 Thread Van Haaren, Harry
Hi Ian, Comments inline, and lots of to trim message size. Thanks for review! -H > -Original Message- > From: Stokes, Ian > Sent: Wednesday, May 15, 2019 6:03 PM > To: Van Haaren, Harry ; ovs-dev@openvswitch.org > Cc: acon...@redhat.com; echau...@redhat.com; i.maxim...@samsung.com >

Re: [ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

2019-05-15 Thread Ian Stokes
On 5/8/2019 4:13 PM, Harry van Haaren wrote: This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry van Haaren --- v9: - Use count_1bits

[ovs-dev] [PATCH v9 1/5] dpif-netdev: implement function pointers/subtable

2019-05-08 Thread Harry van Haaren
This allows plugging-in of different subtable hash-lookup-verify routines, and allows special casing of those functions based on known context (eg: # of bits set) of the specific subtable. Signed-off-by: Harry van Haaren --- v9: - Use count_1bits in favour of __builtin_popcount (Ilya) v6: -