Re: [ovs-dev] [PATCHv2] netdev-afxdp: Add need_wakeup supprt.

2019-09-10 Thread William Tu
Hi Eelco, Thanks for the review. On Tue, Sep 10, 2019 at 7:24 AM Eelco Chaudron wrote: > > Hi William, > > One comment below, but I’m also wondering if we should warn/log a > message if OVS is compiled without this feature and we explicitly > configure it? Same for the reverse what if the

Re: [ovs-dev] [PATCHv2] netdev-afxdp: Add need_wakeup supprt.

2019-09-10 Thread Eelco Chaudron
Hi William, One comment below, but I’m also wondering if we should warn/log a message if OVS is compiled without this feature and we explicitly configure it? Same for the reverse what if the kernel does not support this option, will it fail? //Eelco On 5 Sep 2019, at 22:51, William Tu

[ovs-dev] [PATCHv2] netdev-afxdp: Add need_wakeup supprt.

2019-09-05 Thread William Tu
The patch adds support for using need_wakeup flag in AF_XDP rings. A new option, use_need_wakeup, is added. When this option is used, it means that OVS has to explicitly wake up the kernel RX, using poll() syscall and wake up TX, using sendto() syscall. This feature improves the performance by