Re: [ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-10-01 Thread William Tu
Hi Ilya, Thanks for your review. On Mon, Sep 30, 2019 at 10:18:32PM +0300, Ilya Maximets wrote: > Hi, William. > > Thanks for the patch. > Few general comments on the topic: > 1. This function is not afxdp specific. Maybe it's worth to move >it to more generic netdev-linux? > 2.

Re: [ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-10-01 Thread William Tu
On Mon, Sep 30, 2019 at 12:40:59PM +0200, Eelco Chaudron wrote: > > > On 27 Sep 2019, at 19:26, William Tu wrote: > > >The patch detects the numa node id from the name of the netdev, > >by reading the '/sys/class/net//device/numa_node'. > >If not available, ex: virtual device, or any error

Re: [ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-09-30 Thread Ilya Maximets
Hi, William. Thanks for the patch. Few general comments on the topic: 1. This function is not afxdp specific. Maybe it's worth to move it to more generic netdev-linux? 2. netdev-linux caches most of things like mtu and ifindex. Maybe we could cache numa_id too and not read it all the time

Re: [ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-09-30 Thread Eelco Chaudron
On 27 Sep 2019, at 19:26, William Tu wrote: The patch detects the numa node id from the name of the netdev, by reading the '/sys/class/net//device/numa_node'. If not available, ex: virtual device, or any error happens, return numa id 0. Signed-off-by: William Tu Will you update the

Re: [ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-09-27 Thread 0-day Robot
Bleep bloop. Greetings William Tu, I am a robot and I have tried out your patch. Thanks for your contribution. I encountered some error that I wasn't expecting. See the details below. checkpatch: WARNING: Line lacks whitespace around operator #35 FILE: lib/netdev-afxdp.c:561:

[ovs-dev] [PATCHv2] netdev-afxdp: Detect numa node id.

2019-09-27 Thread William Tu
The patch detects the numa node id from the name of the netdev, by reading the '/sys/class/net//device/numa_node'. If not available, ex: virtual device, or any error happens, return numa id 0. Signed-off-by: William Tu --- v2: Address feedback from Eelco fix memory leak of xaspintf log