Re: [ovs-dev] [RFC 4/5] dpif-netdev: Only reload static tx qid when needed.

2019-05-08 Thread Eelco Chaudron
Patch looks good to me, however need to fix the relaxed atomic operations. On 30 Apr 2019, at 14:18, David Marchand wrote: pmd->static_tx_qid is allocated under a mutex by the different pmd threads. Unconditionally reallocating it will make those pmd threads sleep when contention occurs.

[ovs-dev] [RFC 4/5] dpif-netdev: Only reload static tx qid when needed.

2019-04-30 Thread David Marchand
pmd->static_tx_qid is allocated under a mutex by the different pmd threads. Unconditionally reallocating it will make those pmd threads sleep when contention occurs. During "normal" reloads like for rebalancing queues between pmd threads, this can make pmd threads waste time on this. Reallocating