Re: [ovs-dev] [patch v4 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

2019-02-13 Thread Ben Pfaff
> > From: Ben Pfaff [mailto:b...@ovn.org] > > Sent: Tuesday, February 12, 2019 9:13 AM > > To: Darrell Ball > > Cc: d...@openvswitch.org; Nitin Katiyar > > Subject: Re: [ovs-dev] [patch v4 2/2] conntrack: Exclude l2 padding in > > 'conn_key_extract()'. > >

Re: [ovs-dev] [patch v4 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

2019-02-12 Thread Nitin Katiyar
Hi, We would like to get it backported till OVS 2.6 at least. Regards, Nitin > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Tuesday, February 12, 2019 9:13 AM > To: Darrell Ball > Cc: d...@openvswitch.org; Nitin Katiyar > Subject: Re: [ovs-

Re: [ovs-dev] [patch v4 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

2019-02-11 Thread Ben Pfaff
On Mon, Feb 04, 2019 at 04:23:07PM -0800, Darrell Ball wrote: > 'conn_key_extract()' in userspace conntrack is including L2 > (Ethernet) pad bytes for both L3 and L4 sizes. One problem is > any packet with non-zero L2 padding can incorrectly fail L4 > checksum validation. > > This patch fixes

[ovs-dev] [patch v4 2/2] conntrack: Exclude l2 padding in 'conn_key_extract()'.

2019-02-04 Thread Darrell Ball
'conn_key_extract()' in userspace conntrack is including L2 (Ethernet) pad bytes for both L3 and L4 sizes. One problem is any packet with non-zero L2 padding can incorrectly fail L4 checksum validation. This patch fixes conn_key_extract() by ignoring L2 pad bytes. Fixes: a489b16854b5