Re: [ovs-dev] [patch v5 2/2] conntrack: Fix max size for inet_ntop() call.

2019-02-06 Thread Darrell Ball
On Wed, Feb 6, 2019 at 1:22 AM David Marchand wrote: > On Mon, Feb 4, 2019 at 6:56 PM Ben Pfaff wrote: > >> On Thu, Jan 31, 2019 at 11:35:41PM -0800, Darrell Ball wrote: >> > The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle >> > the maximum possible V6 address size for v4

Re: [ovs-dev] [patch v5 2/2] conntrack: Fix max size for inet_ntop() call.

2019-02-06 Thread David Marchand
On Mon, Feb 4, 2019 at 6:56 PM Ben Pfaff wrote: > On Thu, Jan 31, 2019 at 11:35:41PM -0800, Darrell Ball wrote: > > The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle > > the maximum possible V6 address size for v4 mapping case. > > > > Found by inspection. > > > > Fixes:

Re: [ovs-dev] [patch v5 2/2] conntrack: Fix max size for inet_ntop() call.

2019-02-04 Thread Ben Pfaff
On Thu, Jan 31, 2019 at 11:35:41PM -0800, Darrell Ball wrote: > The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle > the maximum possible V6 address size for v4 mapping case. > > Found by inspection. > > Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") >

Re: [ovs-dev] [patch v5 2/2] conntrack: Fix max size for inet_ntop() call.

2019-01-31 Thread David Marchand
On Fri, Feb 1, 2019 at 8:37 AM Darrell Ball wrote: > The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle > the maximum possible V6 address size for v4 mapping case. > > Found by inspection. > > Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") > Signed-off-by:

[ovs-dev] [patch v5 2/2] conntrack: Fix max size for inet_ntop() call.

2019-01-31 Thread Darrell Ball
The call to inet_ntop() in repl_ftp_v6_addr() is 1 short to handle the maximum possible V6 address size for v4 mapping case. Found by inspection. Fixes: bd5e81a0e596 ("Userspace Datapath: Add ALG infra and FTP.") Signed-off-by: Darrell Ball --- v2: s/IPV6_SCAN_LEN/INET6_ADDRSTRLEN/ in char