Re: [ovs-dev] incorrect revalidated action for igmp

2017-08-02 Thread Ben Pfaff
Thanks for verifying the fix. I applied this to master. I think you're right that there's a remaining mismatch here. If you have time to figure out a full and proper solution, then please do so; I'd appreciate it. On Sat, Jul 15, 2017 at 11:11:40AM +0800, Huanle Han wrote: > This patch can

Re: [ovs-dev] incorrect revalidated action for igmp

2017-07-14 Thread Huanle Han
This patch can slove the problem. But I think wc->masks.tp_src should not be masked in userspace as igmp type is not supported in datapath. Otherwise, flow_wildcards_has_extra() in revalidate_ukey__ always return true for igmp megaflow, and igmp flow is never kept in datapath. Thanks, Huanle On

Re: [ovs-dev] incorrect revalidated action for igmp

2017-07-11 Thread Ben Pfaff
On Thu, Jun 22, 2017 at 01:04:48AM +0800, Huanle Han wrote: > In "Normal" action, igmp report packet is expected to processed in slow > path. > However, the igmp_type(flow->tp_src) is not supported to be masked in > datapath. > Then ovs-vswitchd revalidate the flow with igmp_type(flow->tp_src) ==

[ovs-dev] incorrect revalidated action for igmp

2017-06-21 Thread Huanle Han
In "Normal" action, igmp report packet is expected to processed in slow path. However, the igmp_type(flow->tp_src) is not supported to be masked in datapath. Then ovs-vswitchd revalidate the flow with igmp_type(flow->tp_src) == 0. It leads to a "multicast traffic, flooding" action and overwrites