Re: [ovs-dev] skiplist: Remove 'height' from skiplist_node.

2019-02-04 Thread Ben Pfaff
On Tue, Jan 29, 2019 at 02:18:24PM +0300, Ilya Maximets wrote: > On 28.01.2019 20:48, Ilya Maximets wrote: > > On 25.01.2019 23:22, Ben Pfaff wrote: > >> This member was write-only: it was initialized and never used later on. > >> > >> Thanks to Esteban Rodriguez Betancourt for the > >> following

Re: [ovs-dev] skiplist: Remove 'height' from skiplist_node.

2019-01-29 Thread Ilya Maximets
On 28.01.2019 20:48, Ilya Maximets wrote: > On 25.01.2019 23:22, Ben Pfaff wrote: >> This member was write-only: it was initialized and never used later on. >> >> Thanks to Esteban Rodriguez Betancourt for the >> following additional rationale: >> >> In this case you are right, the "height"

Re: [ovs-dev] skiplist: Remove 'height' from skiplist_node.

2019-01-28 Thread Ilya Maximets
On 25.01.2019 23:22, Ben Pfaff wrote: > This member was write-only: it was initialized and never used later on. > > Thanks to Esteban Rodriguez Betancourt for the > following additional rationale: > > In this case you are right, the "height" member is not only not > used, it is in fact