Re: [ovs-dev] [PATCH 1/4] doc-windows: Remove obsolete documentation

Alin, My suggestion would be to hold off on finalizing the documentation until we squash all the pending bugs. Looks like we are getting there. Thanks, -- Nithin On Feb 4, 2017, at 12:21 AM, Alin Serdean > wrote: Hard

Re: [ovs-dev] [PATCH 4/4] doc-windows: Consolidate switch names in documentation

hi Alin, I second Shashank’s thoughts. I prefer the name “OVS-Extended-Switch”, it makes documentation explicit. I’d prefer to keep it that way. I’m sure that once users are familiar with the documentation, they can pretty much pick whatever name they want. Thanks, -- Nithin On Feb 4, 2017,

[ovs-dev] (no subject)

Brauchen Sie ein Unternehmen / persönliche Darlehen? Wenn ja, wenden Sie sich an Justin Williams auf Ihr Darlehen, das Darlehen-Konto: E-Mail: sloanslimi...@gmail.com E-Mail: sloanslimi...@mail.com ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 4/4] doc-windows: Consolidate switch names in documentation

Hi Shashank, Thanks for reviewing the patch! The main problem is we have two switch names defined currently in the documentation. I wanted to change it to have only one. Sorry I wasn't clear in the commit message. The idea is we instruct to create a switch named `OVS-Extended-Switch`. For a

Re: [ovs-dev] [PATCH 2/4] doc-windows: Update supported tunnel ports

Thanks for the review! This patch will be respined once current issue is closed. Alin. > -Original Message- > From: Nithin Raju [mailto:nit...@vmware.com] > Sent: Sunday, February 5, 2017 10:42 AM > To: Alin Serdean > Cc: d...@openvswitch.org > Subject:

[ovs-dev] [PATCH] windows: Remove dead code in daemon-windows

Found by inspection. Signed-off-by: Alin Gabriel Serdean --- lib/daemon-windows.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/daemon-windows.c b/lib/daemon-windows.c index 7e2e9da..4fc97a8 100644 --- a/lib/daemon-windows.c +++

Re: [ovs-dev] [PATCH 1/4] doc-windows: Remove obsolete documentation

From: Nithin Raju [mailto:nit...@vmware.com] Sent: Sunday, February 5, 2017 10:45 AM To: Alin Serdean Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/4] doc-windows: Remove obsolete documentation Alin, My suggestion would be to hold off on finalizing

Re: [ovs-dev] [PATCH 4/4] doc-windows: Consolidate switch names in documentation

Thanks Alin for clarifying. Like Nithin already mentioned in his response, I think we should keep it as is to be more explicit in the documentation. The documentation in the context of this patch is only providing an example, and if someone felt it were too long to type, they would just use

[ovs-dev] [PATCH 02/10] windows: add definition of getpid and getcwd

getcwd - is used in lib/util.c. getcwd is deprecated on Windows but has _getcwd which is defined in : https://msdn.microsoft.com/en-us/library/sf98bd4y(v=vs.120).aspx getpid - is used in several files (i.e. lib/vlog.c). getpid is also and deprecated and _getpid should be used:

[ovs-dev] [PATCH 01/10] windows: Add definition of getrusage

getrusage is implemented in lib/getrusage-windows.c. This patch just adds its definition to include/windows/sys/resource.h, which serves for files that include . Another that we could also do is to move the implementation to include/windows Signed-off-by: Alin Gabriel Serdean

[ovs-dev] [PATCH 00/10] Implicit function declarations on Windows

This series fixes all current errors when Wimplicit-function-declaration (C4013) is triggered. This is a part of the bigger plan to map all the GCC compiler flags to their cl (Visual Studio compiler) equivalent. For the original discussion please view:

[ovs-dev] [PATCH 05/10] windows: fix calls in netlink-socket

Add nl_sock_transact forward declaration, since it is used before being on implemented. This applies only on Windows. Move nl_sock_subscribe_packet__ function before it is used. It makes more sense to move it rather than adding a forward declaration since it is used by the two functions defined

[ovs-dev] [PATCH 10/10] build-windows: cccl fail compilation on Wimplicit-function-declaration

Gcc compiler argument -Wall contains -Wimplicit-function-declaration which gives warnings when a function is used before declared. Map VStudio compiler error C4013 to it. More info on C4013: https://msdn.microsoft.com/en-us/library/d3ct4kz9.aspx At the moment we cannot switch to the equivalent

[ovs-dev] [PATCH 06/10] windows: add function definition to poll-loop.h

poll_wevent_wait_at is used in the #define but the function definition is missing. Signed-off-by: Alin Gabriel Serdean --- lib/poll-loop.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/poll-loop.h b/lib/poll-loop.h index

[ovs-dev] [PATCH 03/10] windows: add includes to daemon-windows

Add fatal-signal.h include since it uses: fatal_signal_atexit_handler and fatal_signal_add_hook Use the defined getpid() function and also include since it is defined in include/windows/unistd.h . Signed-off-by: Alin Gabriel Serdean --- lib/daemon-windows.c |

[ovs-dev] [PATCH 07/10] windows: add include to stream-windows.c

fatal_signal_unlink_file_now is used but the header for it is missing in the include section. Signed-off-by: Alin Gabriel Serdean --- lib/stream-windows.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/stream-windows.c

Re: [ovs-dev] [BUG] upcall handler thread crash

My ovs version is openvswitch-2.5.0(http://openvswitch.org/releases/openvswitch-2.5.0.tar.gz). I had modified the code as follows and getted other crash. Do it need a lock to protect the operations of mbridge->mbundles hmap(xbridge->xport hmap) between ovs-vswichd thread and the upcall

[ovs-dev] [PATCH 08/10] windows: return NULL in xreadlink

readlink does not exist on Windows. While we could skip the function all togheter on Windows, we may add support for it later on. For the moment return change errno to ENOENT and return NULL. FYI: https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/#kBeZetM7P1dorllZ.97

[ovs-dev] [PATCH 09/10] use portable getpagesize() in system-stats

Use the intended portable function defined above "get_page_size()" not "getpagesize()". Signed-off-by: Alin Gabriel Serdean --- vswitchd/system-stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/vswitchd/system-stats.c

Re: [ovs-dev] [urgent] is there anyway to enable multi-vlan for one vm upon ovs ?

I don't think it normally makes sense to have IP addresses on the same subnet on different VLANs. If you do that, then how would the kernel know, when it sends a packet to that subnet, which VLAN to use? On Mon, Feb 06, 2017 at 10:17:31AM +0800, xiucai wrote: > thanks a lot. > i am very sorry