[ovs-dev] [PATCH 1/2] doc: Describe how docs.openvswitch.org works

Signed-off-by: Stephen Finucane --- Documentation/index.rst| 3 +- .../internals/contributing/documentation-style.rst | 6 ++ Documentation/internals/documentation.rst | 78 ++ Documentation/internals/index.rst

Re: [ovs-dev] IPFIX crash

On 4 April 2017 at 22:34, Neelakantam Gaddam wrote: > Hi All, > > While testing the IPFIX feature with openvswitch-2.6.1, observed the below > crash when traffic is on. > > [ 347.143417] BUG: unable to handle kernel NULL pointer dereference > at (null) > [

[ovs-dev] [PATCH 2/2] doc: Update makefile target for docs

Signed-off-by: Stephen Finucane --- Documentation/intro/install/documentation.rst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/intro/install/documentation.rst b/Documentation/intro/install/documentation.rst index

[ovs-dev] [PATCH] compat: vxlan: Fix NULL dereference in dst_cache.

Neelakantam reports: BUG: unable to handle kernel NULL pointer dereference RIP: 0010:[] [] dst_cache_get_ip4+0xc/0x50 [openvswitch] Call Trace: [] vxlan_get_route.isra.41+0xea/0x130 [openvswitch] [] ? __skb_get_hash+0x39/0x160 [] ovs_vxlan_fill_metadata_dst+0x170/0x1e0 [openvswitch] []

[ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

Hi All, I am having a problem for ovn and need help, thanks. I created two logical routes and connected the two LogicalRoutes through a external LogicalSwitch (connected to the external network) . And then LogicalRoute-1 connected to the VM through the internal LogicalSwitch . my

Re: [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

revese my topology: +-++ | VM 172.16.1.7 | +-++ | +-++ | Logical Switch |

Re: [ovs-dev] [ovs-discuss] ovn: unsnat handling error for Distributed Gateway

revese my topology: +-++ | VM 172.16.1.7 | +-++ | +-++ |

Re: [ovs-dev] [PATCH] m4: Add hard requirements for python in "configure"

On 04/06/2017 12:16 AM, Ben Pfaff wrote: > On Wed, Mar 29, 2017 at 01:49:42PM +0200, Timothy Redaelli wrote: >> Since Python 2.7 and python-six are needed to build Open vSwitch, >> ./configure should return an error if they are missing or if they are too old >> >> Signed-off-by: Timothy Redaelli

Re: [ovs-dev] [PATCH] table: provide table formatting option help at runtime

On Fri, Mar 31, 2017 at 01:21:03PM -0400, Lance Richardson wrote: > Show table formatting options with help output from > ovn-nbctl, obn-sbctl, ovs-vsctl, and vtep-ctl commands. > Include "--data" option in ovsdb-client help output. > > Signed-off-by: Lance Richardson

Re: [ovs-dev] [RFC 3/5] ovsdb: add support for role-based access controls

On Mon, Mar 27, 2017 at 02:56:11PM -0400, Lance Richardson wrote: > Add suport for ovsdb RBAC (role-based access control). This includes: > >- Support for new "--rbac " command-line option to > ovsdb-server, to specify the RBAC roles table to be used. > > This table has one row per

Re: [ovs-dev] [RFC 4/5] ovn: add rbac tables to ovn southbound schema

On Thu, Apr 06, 2017 at 08:58:02AM -0700, Ben Pfaff wrote: > On Mon, Mar 27, 2017 at 02:56:12PM -0400, Lance Richardson wrote: > > Add rbac "roles" and "permissions" tables to ovn southbound > > database schema. > > > > Signed-off-by: Lance Richardson > > I see that master

Re: [ovs-dev] [RFC 0/5] role-based access controls for ovsdb-server, ovn-sb

On Mon, Mar 27, 2017 at 02:56:08PM -0400, Lance Richardson wrote: > This series implements role-based access control infrastructure for > ovsdb-server, and uses that infrastructure to apply role-based access > controls to the OVN_Southbound database. This implementation follows > the outline

Re: [ovs-dev] [PATCH v6 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

Thanks for the patches! Acked-by: Sairam Venugopal On 3/24/17, 1:51 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: >This patch adds functionalities to support IPv4 fragments,

Re: [ovs-dev] [PATCH v2 3/3] ovn-nbctl: include table formatting options in man page

On Tue, Apr 04, 2017 at 09:44:51AM -0400, Lance Richardson wrote: > Include descriptions of table formatting optiosn in ovn-nbctl > man page. > > Signed-off-by: Lance Richardson > --- > v2: no changes Thanks, I applied patches 2 and 3 to master.

Re: [ovs-dev] [RFC 1/5] stream: store stream peer id with stream state

On Mon, Mar 27, 2017 at 02:56:09PM -0400, Lance Richardson wrote: > Keep track of authenticated ID for stream peer. For SSL connections, > the authenticated ID is the CN (Common Name) field from the peer's > SSL certificate. > > Signed-off-by: Lance Richardson Not all the

Re: [ovs-dev] [PATCH ovs V6 00/24] Introducing HW offload support for openvswitch

On 5 April 2017 at 02:00, Paul Blakey wrote: > Actually we've based the code on odp_flow_key_from_flow__, we are doing the > same thing, and looking at it again, it isn't foolproof as well and in the > same way. We will do the said check and printing a generic msg in case we >

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 5 April 2017 at 00:38, Roi Dayan wrote: > > > On 05/04/2017 07:18, Roi Dayan wrote: >> >> >> >> On 04/04/2017 23:53, Joe Stringer wrote: >>> >>> On 3 April 2017 at 10:53, Joe Stringer wrote: On 3 April 2017 at 03:27, Roi Dayan

Re: [ovs-dev] [ovs-dev, RFC] ovn: Revised support for service function chaining

John, On Thu, Apr 6, 2017 at 9:15 AM, John McDowall < jmcdow...@paloaltonetworks.com> wrote: > Mickey, > > > > Thanks, here is what I propose, based on your comments: > > > > 1. Support for non-ip traffic : I will make the agreed on changes. > > 2. Match Filter: Will make the changes

Re: [ovs-dev] [RFC 1/5] stream: store stream peer id with stream state

On Thu, Apr 06, 2017 at 08:37:34AM -0700, Ben Pfaff wrote: > On Mon, Mar 27, 2017 at 02:56:09PM -0400, Lance Richardson wrote: > > Keep track of authenticated ID for stream peer. For SSL connections, > > the authenticated ID is the CN (Common Name) field from the peer's > > SSL certificate. > > >

Re: [ovs-dev] [RFC 4/5] ovn: add rbac tables to ovn southbound schema

On Mon, Mar 27, 2017 at 02:56:12PM -0400, Lance Richardson wrote: > Add rbac "roles" and "permissions" tables to ovn southbound > database schema. > > Signed-off-by: Lance Richardson I see that master has changed a little and will require a respin here, but I doubt it's a

Re: [ovs-dev] [PATCH v6 4/5] datapath-windows: Updated OvsTcpSegmentNBL to handle IP fragments.

Acked-by: Sairam Venugopal On 3/24/17, 1:51 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: >With this patch, OvsTcpSegmentNBL not only supports fragmenting NBL >to TCP segments

Re: [ovs-dev] [PATCH v2 1/3] ovsdb-client: improve formatting option description in man page

On Tue, Apr 04, 2017 at 09:44:39AM -0400, Lance Richardson wrote: > Use correct option name for "--no-headings", remove duplicate > "--no-heading" option in synopsis. > > Clarify description of "--data=json" option. > > Signed-off-by: Lance Richardson > --- > v2: all new

Re: [ovs-dev] [RFC 2/5] ovsdb: refactor utility functions into separate file

On Mon, Mar 27, 2017 at 02:56:10PM -0400, Lance Richardson wrote: > Move local db access functions to a new file and make give them > global scope so they can be included in the ovsdb library and used > by other ovsdb library functions. > > Signed-off-by: Lance Richardson

Re: [ovs-dev] [RFC 5/5] ovn-sbctl: support setting rbac role for remote connections

On Mon, Mar 27, 2017 at 02:56:13PM -0400, Lance Richardson wrote: > Add support for specifying rbac "role" when setting remote > connection configuration in southbound database. > > Signed-off-by: Lance Richardson Seems reasonable at first glance, thanks.

Re: [ovs-dev] [PATCH v6 3/5] datapath-windows: Retain MRU value in the _OVS_BUFFER_CONTEXT.

Thanks for incorporating this change. Acked-by: Sairam Venugopal On 3/24/17, 1:51 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: >This patch introduces a new field MRU(Maximum

Re: [ovs-dev] [PATCH v6 5/5] datapath-windows: Fragment NBL based on MRU size

Acked-by: Sairam Venugopal On 3/24/17, 1:51 PM, "ovs-dev-boun...@openvswitch.org on behalf of Anand Kumar" wrote: >This patch adds support for Fragmenting NBL based on the MRU value. >MRU value is

Re: [ovs-dev] [PATCH 1/4] util: New macro ovs_strlcpy_arrays().

On Wed, Apr 5, 2017 at 11:11 PM, Ben Pfaff wrote: > When both arguments to ovs_strlcpy() are character arrays, it makes sense > to just pass the smaller of their sizes as the overall size. It's > somewhat error-prone and definitely redundant to write that by hand, so > this commit

Re: [ovs-dev] [PATCH 2/4] check-structs: struct eth_addr has alignment 2, not 1.

On Wed, Apr 5, 2017 at 11:11 PM, Ben Pfaff wrote: > It consists of ovs_be16 elements, so it has 16-bit alignment. > > (This doesn't make a difference for any actual OpenFlow protocol elements.) > > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou

Re: [ovs-dev] [PATCH] route-table: Fix compatibility with pre-2.6.36 headers.

On Fri, Mar 17, 2017 at 2:21 PM, Ben Pfaff wrote: > Reported-by: Timothy Redaelli > Reported-at: > https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329604.html > Signed-off-by: Ben Pfaff Acked-by: Andy Zhou

[ovs-dev] RE

I have a proposal for you, Kindly contact me via: mrsstacyle...@gmail.com Pravni pogoji / Legal disclaimer Telekom Slovenije, d.d., Ljubljana ___ dev mailing list d...@openvswitch.org

[ovs-dev] [PATCH RFC] dpif-netdev: Add Cuckoo Distributor to Accelerate Megaflow Search

From: Yipeng Wang The Datapath Classifier uses tuple space search for flow classification. The rules are arranged into a set of tuples/subtables (each with a distinct mask). Each subtable is implemented as a hash table and lookup is done with flow keys formed by

Re: [ovs-dev] [PATCH v2] netdev-dpdk: Create separate memory pool for each port

On Wed, Apr 05, 2017 at 05:12:44PM +0100, Kevin Traynor wrote: > On 02/24/2017 11:27 AM, Robert Wojciechowicz wrote: > > Since it's possible to delete memory pool in DPDK > > we can try to estimate better required memory size > > when port is reconfigured, e.g. with different number > > of rx

[ovs-dev] [PATCH 1/4] util: New macro ovs_strlcpy_arrays().

When both arguments to ovs_strlcpy() are character arrays, it makes sense to just pass the smaller of their sizes as the overall size. It's somewhat error-prone and definitely redundant to write that by hand, so this commit adds a new macro that does it automatically. Signed-off-by: Ben Pfaff

[ovs-dev] [PATCH 2/4] check-structs: struct eth_addr has alignment 2, not 1.

It consists of ovs_be16 elements, so it has 16-bit alignment. (This doesn't make a difference for any actual OpenFlow protocol elements.) Signed-off-by: Ben Pfaff --- build-aux/check-structs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[ovs-dev] OVN L3-HA request for feedback

Hello everybody, First I'd like to say hello, because I'll be able to spend more time working with this community, and I'm sure it will be an enjoyable journey for what I've seen (silently watching) during the last few years. I'm planning to start work (together with Anil) on the L3

[ovs-dev] [PATCH] python: Allow tuning the session probe_interval from IDL

This patch is adding a new method set_probe_interval() to the Idl class which allows configuring the probe interval for the IDL session. Instances of Idl might want to tune this interval to be less agressive than the current 5s one. Reported-at:

Re: [ovs-dev] [PATCH v6 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

Hi Anand, Thanks a lot for the patch. At first glance the code looks ok. Just a small nit pick, can you please use a new memory pool tag instead of using `OVS_MEMORY_TAG`. Please define a new member after https://github.com/openvswitch/ovs/blob/master/datapath-windows/ovsext/Util.h#L41 This

Re: [ovs-dev] [PATCH] route-table: Fix compatibility with pre-2.6.36 headers.

On Thu, Apr 06, 2017 at 11:39:54AM -0700, Andy Zhou wrote: > On Fri, Mar 17, 2017 at 2:21 PM, Ben Pfaff wrote: > > Reported-by: Timothy Redaelli > > Reported-at: > > https://mail.openvswitch.org/pipermail/ovs-dev/2017-March/329604.html > > Signed-off-by: Ben

Re: [ovs-dev] [PATCH v6 1/5] datapath-windows: Added a new file to support Ipv4 fragments.

> + > +/* > +*-- > +-- > +* OvsIpv4Reassemble > +* Reassemble the ipv4 fragments and return newNbl on success. > +* Should be called after acquiring the lockObj for the entry. >

Re: [ovs-dev] [PATCH v2] ovn-controller: enable ssl config via local ovsdb

On Thu, Apr 06, 2017 at 12:49:13PM -0400, Lance Richardson wrote: > Allow ovn-controller to use SSL certificate and key configuration > from local ovsdb. With this change, SSL configuration from the > vswitchd database will be used if present, otherwise configuration > can still be specified from

Re: [ovs-dev] [PATCH] m4: Add hard requirements for python in "configure"

On Thu, Apr 06, 2017 at 07:20:32PM +0200, Timothy M. Redaelli wrote: > On 04/06/2017 12:16 AM, Ben Pfaff wrote: > > On Wed, Mar 29, 2017 at 01:49:42PM +0200, Timothy Redaelli wrote: > >> Since Python 2.7 and python-six are needed to build Open vSwitch, > >> ./configure should return an error if

Re: [ovs-dev] [PATCH 1/2] doc: Describe how docs.openvswitch.org works

On Thu, Apr 6, 2017 at 9:58 AM, Stephen Finucane wrote: > Signed-off-by: Stephen Finucane > --- > Documentation/index.rst| 3 +- > .../internals/contributing/documentation-style.rst | 6 ++ >

Re: [ovs-dev] [PATCH 2/4] check-structs: struct eth_addr has alignment 2, not 1.

On Thu, Apr 06, 2017 at 11:35:44AM -0700, Andy Zhou wrote: > On Wed, Apr 5, 2017 at 11:11 PM, Ben Pfaff wrote: > > It consists of ovs_be16 elements, so it has 16-bit alignment. > > > > (This doesn't make a difference for any actual OpenFlow protocol elements.) > > > > Signed-off-by:

[ovs-dev] [datapath backport 03/10] compat: ipv6: orphan skbs in reassembly unit.

From: Eric Dumazet Upstream commit: ipv6: orphan skbs in reassembly unit Andrey reported a use-after-free in IPv6 stack. Issue here is that we free the socket while it still has skb in TX path and in some queues. It happens here because IPv6 reassembly

[ovs-dev] [datapath backport 04/10] datapath: actions: fixed a brace coding style warning.

From: Peter Downs Upstream commit: openvswitch: actions: fixed a brace coding style warning Fixed a brace coding style warning reported by checkpatch.pl Signed-off-by: Peter Downs Signed-off-by: David S. Miller

[ovs-dev] [datapath backport 07/10] datapath: openvswitch: Deferred fifo API change.

Upstream commit: openvswitch: Deferred fifo API change. add_deferred_actions() API currently requires actions to be passed in as a fully encoded netlink message. So far both 'sample' and 'recirc' actions happens to carry actions as fully encoded netlink messages. However, this

[ovs-dev] [datapath backport 08/10] datapath: openvswitch: Refactor recirc key allocation.

Upstream commit: openvswitch: Refactor recirc key allocation. The logic of allocating and copy key for each 'exec_actions_level' was specific to execute_recirc(). However, future patches will reuse as well. Refactor the logic into its own function clone_key(). Signed-off-by:

[ovs-dev] [datapath backport 06/10] datapath: openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD

From: Kris Murphy openvswitch: Add missing case OVS_TUNNEL_KEY_ATTR_PAD Added a case for OVS_TUNNEL_KEY_ATTR_PAD to the switch statement in ip_tun_from_nlattr in order to prevent the default case returning an error. Fixes: b46f6ded906e ("libnl:

[ovs-dev] [datapath backport 05/10] datapath: net/openvswitch: Set the ipv6 source tunnel key address attribute correctly

From: Or Gerlitz Upstream commit: net/openvswitch: Set the ipv6 source tunnel key address attribute correctly When dealing with ipv6 source tunnel key address attribute (OVS_TUNNEL_KEY_ATTR_IPV6_SRC) we are wrongly setting the tunnel dst ip, fix that.

Re: [ovs-dev] [PATCH v2] bundle: add nw_src/dst hash method

On Thu, Mar 09, 2017 at 12:01:02PM +0800, we...@ucloud.cn wrote: > From: wenxu > > Add only nw_src or nw_dst hash feature to bundle and multipath. > > Signed-off-by: wenxu Applied to master, thanks! ___ dev mailing

[ovs-dev] [datapath backport 01/10] dapatah: Fix missing CONFIG_NF_CONNTRACK_LABLES check

This config flag was not consistently checked. Fix it. Signed-off-by: Andy Zhou --- datapath/conntrack.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/datapath/conntrack.c b/datapath/conntrack.c index 4df73528bf69..413095955b1b 100644 ---

[ovs-dev] [datapath backport 02/10] datapath: Pack struct sw_flow_key.

From: Jarno Rajahalme Upstream commit: openvswitch: Pack struct sw_flow_key. struct sw_flow_key has two 16-bit holes. Move the most matched conntrack match fields there. In some typical cases this reduces the size of the key that needs to be hashed into half and

[ovs-dev] [datapath backport 09/10] datapath: openvswitch: Optimize sample action for the clone use cases

Upstream commit: openvswitch: Optimize sample action for the clone use cases With the introduction of open flow 'clone' action, the OVS user space can now translate the 'clone' action into kernel datapath 'sample' action, with 100% probability, to ensure that the clone semantics,

[ovs-dev] [datapath backport 10/10] datapath: Openvswitch: Refactor sample and recirc actions implementation

Upstream commit: Openvswitch: Refactor sample and recirc actions implementation Added clone_execute() that both the sample and the recirc action implementation can use. Signed-off-by: Andy Zhou Acked-by: Pravin B Shelar Signed-off-by:

Re: [ovs-dev] [PATCH ovs V5 00/24] Introducing HW offload support for openvswitch

On 05/04/2017 10:08, Joe Stringer wrote: On 4 April 2017 at 21:18, Roi Dayan wrote: On 04/04/2017 23:53, Joe Stringer wrote: On 3 April 2017 at 10:53, Joe Stringer wrote: On 3 April 2017 at 03:27, Roi Dayan wrote: On 29/03/2017

Re: [ovs-dev] Invitation: OVS-DPDK bi-weekly meeting...

Meeting cancelled today. Next meeting 20th April. thanks, Kevin. On 03/24/2017 04:28 PM, Kevin Traynor wrote: > 24 March 2017 > ATTENDEES: Johann, Antonio, Rashid, Eelco, Flavio, Simon, Georg, Jan, > Robin, Ian, Bhanu, Darren, Billy, Fikkie, Vinod, Rick, Niaz, Kevin > > GENERAL > > If anyone

[ovs-dev] [PATCH 4/4] Add support for OpenFlow 1.6 (draft) port status and port mod messages.

OpenFlow 1.6 adds support for EUI-64 addresses for ports, and extends the maximum length of OpenFlow port names from 16 to 64 bytes. ONF-JIRA: EXT-566 Signed-off-by: Ben Pfaff --- NEWS | 4 +- include/openflow/automake.mk | 1 +

Re: [ovs-dev] [PATCH v6 0/5] datapath-windows: Add support for Ipv4 fragments

Thanks a lot for all the hard work Anand! The patches are in good state overall with some small nits . In the comments over the patches I said I will add an incremental for them. I attached a diff to hopefully get you going. Disregarding the changes to ` OvsApplySWChecksumOnNB` which

Re: [ovs-dev] [PATCH] python: Allow tuning the session probe_interval from IDL

On Thu, Apr 6, 2017 at 6:25 AM, Lucas Alvares Gomes wrote: > This patch is adding a new method set_probe_interval() to the Idl class > which allows configuring the probe interval for the IDL session. > Instances of Idl might want to tune this interval to be less agressive >

Re: [ovs-dev] [PATCH v6 2/5] datapath-windows: Added Ipv4 fragments support in Conntrack

Thanks a lot for the patch. >From what I see you and Yin(https://patchwork.ozlabs.org/patch/742367/) both >benefit by using `ovsFwdCtx` (OvsForwardingContext) in the Conntrack pieces. IMO it make sense just to fire a single patch just to add OvsExecuteConntrackAction/OvsCtExecute_ so both of

Re: [ovs-dev] [PATCH v6 4/5] datapath-windows: Updated OvsTcpSegmentNBL to handle IP fragments.

Since you split the functionality on `BOOLEAN isFragment` mind just creating new function and leaving FixSegmentHeader as is. I think it would look much cleaner. Thanks, Alin. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On

Re: [ovs-dev] [PATCH v6 5/5] datapath-windows: Fragment NBL based on MRU size

Mind creating a function for it? You will need to add the same for OvsTunnelPortTx as well, otherwise the packet won't be fragmented to the vif value before sending it via a tunnel type (i.e. vxlan). I will try to explain more on patch 0. > -Original Message- > From:

Re: [ovs-dev] [PATCH 3/3 v2] datapath-windows: NAT integration with conntrack

Hi Yin, I'm back sorry it took a while . When applying `OvsUpdateAddressAndPort` for some reason there still is a problem with the checksums. There are two aspects which apparently are hit for some reason: 1. normal packet. 2. tcp segment. If I disable tcp/udp checksums(on the NIC) normal