[ovs-dev] [PATCH v2] tests: fix PTAP system test to check only OF stats

2017-07-12 Thread Zoltán Balogh
It turned out, checking datapath flow statistics during system-userspace test is not reliable. Unwanted packets can be injected depending on system configuration. As a workaround, this commit removes checking statistics of datapath flows and does check OpenFlow statistics of the integrator

Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

2017-07-12 Thread Kavanagh, Mark B
>From: Darrell Ball [mailto:db...@vmware.com] >Sent: Tuesday, July 11, 2017 5:03 PM >To: Kavanagh, Mark B ; Chandran, Sugesh >; ovs-dev@openvswitch.org; Varghese, Vipin >; acon...@redhat.com >Subject: Re: [ovs-dev]

Re: [ovs-dev] [PATCH 3/4] ofproto-dpif-xlate: drop L3 packets on L2 legacy port

2017-07-12 Thread Zoltán Balogh
Hello Jan, I'll create the stand-alone commit. However, sending L3 packet from ptap tunnel to veth port won't work. The veth port would handle received packets as L2. I can use patch ports instead. Best regards, Zoltan > -Original Message- > From: Jan Scheurich > Sent: Wednesday,

Re: [ovs-dev] [PATCH] netdev: fix crash when ifa_netmask is null

2017-07-12 Thread linhaifeng
在 2017/7/12 12:55, Ben Pfaff 写道: > On Tue, Jul 04, 2017 at 08:52:57AM +0800, Haifeng Lin wrote: >> The ifa_netmask is null when failed to call ioctl >> in getifaddrs >> >> Signed-off-by: Haifeng Lin > Thanks for figuring this out. > > What does it mean if ifa_netmask is

Re: [ovs-dev] [PATCH] tests: fix PTAP system test to check only OF stats

2017-07-12 Thread Zoltán Balogh
Thank you for pointing this out! I've sent v2 to the list. https://patchwork.ozlabs.org/patch/787037/ /Zoltan > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, July 11, 2017 6:11 PM > To: Zoltán Balogh ;

Re: [ovs-dev] [PATCH] Support IPv6 link-local address scopes on Linux.

2017-07-12 Thread Darrell Ball
On 7/11/17, 9:23 PM, "Ben Pfaff" wrote: Thanks for the review. I'm very new to the concept of IPv6 link-local address scoping. What does this subset out of the larger feature? There is lots of flexibility here, mostly not relevant to ovs; for example one basic

[ovs-dev] how to get packet information in ovs-dpdk?

2017-07-12 Thread Sam
hi all, I'm running ovs-dpdk(ovs-2.4.9), I found the counter of bond port of br_t is increasing, but I want to know what's these packets, how could I do this? first, I use `ovs-ofctl snoop br_t`, but it quit quickly as below: > [root@yf-mos-test-net07 ~]# /usr/local/bin/ovs-ofctl snoop >

Re: [ovs-dev] [PATCH] odp-execute: Reuse rss hash in OVS_ACTION_ATTR_HASH.

2017-07-12 Thread Andy Zhou
On Tue, Jul 11, 2017 at 7:30 AM, Ilya Maximets wrote: > If RSS hash exists in a packet it can be reused instead of > 5 tuple hash re-calculation in OVS_ACTION_ATTR_HASH. This > leads to increasing the performance of sending packets to > the OVS bonding in userspace

Re: [ovs-dev] ICT HELPDESK TEAM

2017-07-12 Thread Henry, Edwina via dev
From: Henry, Edwina Sent: Wednesday, July 12, 2017 3:29 AM To: Henry, Edwina Subject: ICT HELPDESK TEAM Account tijdelijk geblokkeerd Uw e-mailaccount was LOGIN enkele uren geleden van het onbekende locatie-IP-adres: 103.240.180.228, en is geïdentificeerd

[ovs-dev] ofport = -1?

2017-07-12 Thread Krzysztof Wojciechowski
Hello I am writing some kind of SDN driver at this moment. I have problem with ofports. Sometimes they have value "-1". I am not sure if its wrong. But i cant add flow with ACTION=output:-1 I think We didn't have this problem with Xen Cloud Platform or Xen installed on Xen on Debian. But it

Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-12 Thread Thomas Morin
Hi Eric, 2017-07-11, Eric Garver: Inserting an important note for reviewers/testers. [...] Note: This depends on vport-netdev changes to allow L3 netdev ports, kernel commit 217ac77a3c25 ("openvswitch: allow L3 netdev ports"). So you either need a 4.10+ kernel or use the modules provided

Re: [ovs-dev] how to get packet information in ovs-dpdk?

2017-07-12 Thread linhaifeng
You can use dpdk tool 'pdump' to capture packets http://dpdk.org/doc/guides-16.07/sample_app_ug/pdump.html 在 2017/7/12 16:21, Sam 写道: > hi all, > > I'm running ovs-dpdk(ovs-2.4.9), I found the counter of bond port of br_t > is increasing, but I want to know what's these packets, how could I do

Re: [ovs-dev] [PATCH] packets: Do not initialize ct_orig_tuple.

2017-07-12 Thread Bodireddy, Bhanuprakash
Thanks Darrell for testing this patch. I will send on v2 with your suggestions below. - Bhanuprakash. >-Original Message- >From: Darrell Ball [mailto:db...@vmware.com] >Sent: Sunday, July 9, 2017 9:44 PM >To: Bodireddy, Bhanuprakash ;

Re: [ovs-dev] [PATCH] packets: Reorganize the pkt_metdata structure.

2017-07-12 Thread Bodireddy, Bhanuprakash
>On Sun, Jul 09, 2017 at 10:53:52PM +, Darrell Ball wrote: >> I went thru. this patch and see the merits of the objective. >> I also did various testing with it. >> I had one comment inline. Thanks Darrell for testing this patch. I will factor in your comment in next version of patch. >>

[ovs-dev] Best SEO Services With Special Offers

2017-07-12 Thread amit sarma
Sent from Outlook Hi, Sir/ Can you outsource some SEO business to us? We will work according to you and your clients and for a Long term relationship. We will target in this Price More than 15 keywords 50% Discount Offer. Please share your Skype ID or Cell no so that

Re: [ovs-dev] [PATCH] packets: Reorganize the pkt_metdata structure.

2017-07-12 Thread Bodireddy, Bhanuprakash
Hi Ben, >On Thu, Jun 22, 2017 at 10:10:49PM +0100, Bhanuprakash Bodireddy wrote: >> pkt_metadata_init() is called for every packet in userspace datapath >> and initializes few members in pkt_metadata. Before this the members >> that needs to be initialized are prefetched using

Re: [ovs-dev] [PATCH] socket-util: Support sendmmsg() on Linux and non-Linux platforms.

2017-07-12 Thread Takashi YAMAMOTO
On Thu, Jul 13, 2017 at 1:23 AM, Ben Pfaff wrote: > This will have its first user in an upcoming commit. > > Signed-off-by: Ben Pfaff > --- > configure.ac| 3 ++- > include/sparse/sys/socket.h | 5 + > lib/socket-util.c | 38

Re: [ovs-dev] [PATCH] nx-match: Don't append "ct_nw_proto" nx_match if mask not set.

2017-07-12 Thread Ben Pfaff
On Wed, Jul 12, 2017 at 03:47:07PM -0700, Justin Pettit wrote: > The function nx_put_raw() shouldn't append "ct_nw_proto" to nx_match if > the corresponding mask isn't set. > > Signed-off-by: Justin Pettit > --- > lib/nx-match.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [ovs-dev] [PATCH] nx-match: Don't append "ct_nw_proto" nx_match if mask not set.

2017-07-12 Thread Ben Pfaff
On Wed, Jul 12, 2017 at 07:04:26PM -0700, Justin Pettit wrote: > > > On Jul 12, 2017, at 5:42 PM, Ben Pfaff wrote: > > > > On Wed, Jul 12, 2017 at 03:47:07PM -0700, Justin Pettit wrote: > >> The function nx_put_raw() shouldn't append "ct_nw_proto" to nx_match if > >> the

[ovs-dev] [PATCH v2] socket-util: Support sendmmsg() regardless of platform.

2017-07-12 Thread Ben Pfaff
This will have its first user in an upcoming commit. Signed-off-by: Ben Pfaff --- v1->v2: Note that FreeBSD also has sendmmsg. Fix sendmsg() return type. configure.ac| 3 ++- include/sparse/sys/socket.h | 5 + lib/socket-util.c | 38

Re: [ovs-dev] [PATCH] socket-util: Support sendmmsg() on Linux and non-Linux platforms.

2017-07-12 Thread Ben Pfaff
On Thu, Jul 13, 2017 at 08:45:21AM +0900, Takashi YAMAMOTO wrote: > On Thu, Jul 13, 2017 at 1:23 AM, Ben Pfaff wrote: > > > This will have its first user in an upcoming commit. > > > > Signed-off-by: Ben Pfaff > > --- > > configure.ac| 3 ++- > >

[ovs-dev] [PATCH v1 1/2] datapath: add vport-gtp for GPRS Tunneling Protocol

2017-07-12 Thread Jiannan Ouyang
Add vport-gtp which uses gtp_create_flow_based_dev exported by the Linux GTP module to create a flow based net_device Signed-off-by: Jiannan Ouyang --- datapath/Modules.mk | 2 + datapath/linux/Modules.mk | 1 +

[ovs-dev] [PATCH v1 2/2] userspace: Add L3 tunnel type GTP

2017-07-12 Thread Jiannan Ouyang
Userspace support for L3 vport type OVS_VPORT_TYPE_GTP Signed-off-by: Jiannan Ouyang --- lib/dpif-netlink.c | 5 + lib/netdev-vport.c | 14 -- ofproto/ofproto-dpif-ipfix.c | 6 ++ ofproto/ofproto-dpif-sflow.c | 6 +-

[ovs-dev] [PATCH v1 0/2] Add GTP vport based on upstream datapath

2017-07-12 Thread Jiannan Ouyang
This patch series depends on the Linux net-next patch set [PATCH net-next] Flow Based GTP Tunneling With flow based GTP tunneling supported in the upstream datapath, we can create a gtp vport associated with a flow based GTP net_device. This allows us to program GTP tunnels via ovs-vsctl.

[ovs-dev] [PATCH v2] ovsschema: Fix line lengths.

2017-07-12 Thread Bhanuprakash Bodireddy
According to coding style the line lengths should be <=79. Fix the schema file and update the checksum and version number to reflect the change. Signed-off-by: Bhanuprakash Bodireddy --- v1->v2 * Update version number from 7.15.0 -> 7.5.1. Also updated cksum

Re: [ovs-dev] [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when deleted

2017-07-12 Thread fukaige
> -Original Message- > From: fukaige > Sent: Tuesday, July 11, 2017 3:34 PM > To: 'Ben Pfaff' > Cc: d...@openvswitch.org; Zhaoshenglong > Subject: RE: [PATCH v3] tnl-ports: Remove netdevs in netdev_hash when > deleted > > > > -Original Message- > > From: Ben Pfaff

Re: [ovs-dev] [PATCH] nx-match: Don't append "ct_nw_proto" nx_match if mask not set.

2017-07-12 Thread Justin Pettit
> On Jul 12, 2017, at 5:42 PM, Ben Pfaff wrote: > > On Wed, Jul 12, 2017 at 03:47:07PM -0700, Justin Pettit wrote: >> The function nx_put_raw() shouldn't append "ct_nw_proto" to nx_match if >> the corresponding mask isn't set. >> >> Signed-off-by: Justin Pettit

Re: [ovs-dev] [PATCH v2] netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send

2017-07-12 Thread Gao Zhenyu
Thanks for working on patch of implementing sendmmsg. I will revise my patch base on it. Thanks Zhenyu Gao 2017-07-13 0:25 GMT+08:00 Ben Pfaff : > On Fri, Jul 07, 2017 at 12:39:51AM +, Zhenyu Gao wrote: > > Sendmmsg can reduce cpu cycles in sending packets to kernel. > >

Re: [ovs-dev] [PATCH] packets: Reorganize the pkt_metdata structure.

2017-07-12 Thread Ben Pfaff
On Thu, Jul 13, 2017 at 02:10:24AM +, Bodireddy, Bhanuprakash wrote: > > > >On Wed, Jul 12, 2017 at 10:38:30AM +, Bodireddy, Bhanuprakash wrote: > >> Hi Ben, > >> > >> >On Thu, Jun 22, 2017 at 10:10:49PM +0100, Bhanuprakash Bodireddy wrote: > >> >> pkt_metadata_init() is called for every

Re: [ovs-dev] [PATCH v2] socket-util: Support sendmmsg() regardless of platform.

2017-07-12 Thread Ben Pfaff
Thanks. I applied this to master. On Thu, Jul 13, 2017 at 10:46:44AM +0800, Gao Zhenyu wrote: > LGTM. > > Thanks > Zhenyu Gao > > 2017-07-13 8:39 GMT+08:00 Ben Pfaff : > > > This will have its first user in an upcoming commit. > > > > Signed-off-by: Ben Pfaff > >

Re: [ovs-dev] [PATCH net-next v1 0/3] Flow Based GTP Tunneling

2017-07-12 Thread Joe Stringer
On 12 July 2017 at 17:44, Jiannan Ouyang wrote: > This patch series augmented the existing GTP module to support flow > based GTP tunneling and modified the openvswitch datapath to support the > GTP vport type. > > A flow based GTP net device enables that, > 1) on the RX path, the

[ovs-dev] [PATCH v2] packets: Do not initialize ct_orig_tuple.

2017-07-12 Thread Bhanuprakash Bodireddy
Commit "odp: Support conntrack orig tuple key." introduced new fields in struct 'pkt_metadata'. pkt_metadata_init() is called for every packet in the userspace datapath. When testing a simple single flow case with DPDK, we observe a lower throughput after the above commit (it was 14.88 Mpps

[ovs-dev] [PATCH net-next v1 0/3] Flow Based GTP Tunneling

2017-07-12 Thread Jiannan Ouyang
This patch series augmented the existing GTP module to support flow based GTP tunneling and modified the openvswitch datapath to support the GTP vport type. A flow based GTP net device enables that, 1) on the RX path, the outer (IP/UDP/GTP) header information could to be stored in the

[ovs-dev] [PATCH net-next v1 3/3] openvswitch: Add GPRS Tunnel Protocol (GTP) vport support

2017-07-12 Thread Jiannan Ouyang
Add OVS_VPORT_TYPE_GTP type and vport-gtp support. Signed-off-by: Jiannan Ouyang --- include/uapi/linux/openvswitch.h | 1 + net/openvswitch/Kconfig | 10 +++ net/openvswitch/Makefile | 1 + net/openvswitch/vport-gtp.c | 144

[ovs-dev] [PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap

2017-07-12 Thread Jiannan Ouyang
If flow-based encap/decap is enabled, a separate code path is created for both packet RX and TX. PDP contexts are not used in flow-based mode since all metadata is maintained in metadata_dst: - for RX, pdp lookup and ms check are bypassed, while metadata_dst is constructed and attached to the

Re: [ovs-dev] [PATCH] packets: Reorganize the pkt_metdata structure.

2017-07-12 Thread Bodireddy, Bhanuprakash
> >On Wed, Jul 12, 2017 at 10:38:30AM +, Bodireddy, Bhanuprakash wrote: >> Hi Ben, >> >> >On Thu, Jun 22, 2017 at 10:10:49PM +0100, Bhanuprakash Bodireddy wrote: >> >> pkt_metadata_init() is called for every packet in userspace >> >> datapath and initializes few members in pkt_metadata. Before

Re: [ovs-dev] [PATCH v2] socket-util: Support sendmmsg() regardless of platform.

2017-07-12 Thread Gao Zhenyu
LGTM. Thanks Zhenyu Gao 2017-07-13 8:39 GMT+08:00 Ben Pfaff : > This will have its first user in an upcoming commit. > > Signed-off-by: Ben Pfaff > --- > v1->v2: Note that FreeBSD also has sendmmsg. Fix sendmsg() return type. > > configure.ac| 3

Re: [ovs-dev] 答复: 答复: 答复: [PATCH] pkt reassemble: fix kernel panic for ovs reassemble

2017-07-12 Thread Greg Rose
On 07/06/2017 08:25 PM, 王志克 wrote: Hi Greg, Any progress? Thanks. Br, Wang Zhike Hi Wang, I've been out of town since June 30 but will try to find some time to take this up again this week. Thanks, - Greg ___ dev mailing list

Re: [ovs-dev] [PATCH v4 4/7] ovn: l3ha, handling of multiple gateway chassis

2017-07-12 Thread Guru Shetty
On 12 July 2017 at 06:36, Miguel Angel Ajo Pelayo wrote: > This patch in the series still has the race condition where all the chassis > the Gateway_Chassis list of a chassisredirect port will try to fight for > the chassis column of Port_Binding. Other than that it works. >

Re: [ovs-dev] ofport = -1?

2017-07-12 Thread Ben Pfaff
On Wed, Jul 12, 2017 at 02:05:58PM +0200, Krzysztof Wojciechowski wrote: > I am writing some kind of SDN driver at this moment. I have problem with > ofports. Sometimes they have value "-1". I am not sure if its wrong. But i > cant add flow with ACTION=output:-1 > I think We didn't have this

Re: [ovs-dev] [PATCH] packets: Reorganize the pkt_metdata structure.

2017-07-12 Thread Ben Pfaff
On Wed, Jul 12, 2017 at 10:38:30AM +, Bodireddy, Bhanuprakash wrote: > Hi Ben, > > >On Thu, Jun 22, 2017 at 10:10:49PM +0100, Bhanuprakash Bodireddy wrote: > >> pkt_metadata_init() is called for every packet in userspace datapath > >> and initializes few members in pkt_metadata. Before this

Re: [ovs-dev] how to get packet information in ovs-dpdk?

2017-07-12 Thread Ben Pfaff
On Wed, Jul 12, 2017 at 04:21:04PM +0800, Sam wrote: > hi all, > > I'm running ovs-dpdk(ovs-2.4.9), I found the counter of bond port of br_t > is increasing, but I want to know what's these packets, how could I do this? > > first, I use `ovs-ofctl snoop br_t`, but it quit quickly as below: > >

[ovs-dev] [PATCH v4 2/7] ovn: l3ha, NBDB and SBDB changes and documentation

2017-07-12 Thread Miguel Angel Ajo
From: "majop...@redhat.com" This commit introduces the north and south db changes necessary for the l3ha router implementation. It defines a new Table in both NBDB and SBDB. The Gateway_Chassis table is created, with a tiny difference between NBDB and SBDB, NBDB references

[ovs-dev] [PATCH v4 3/7] ovn: l3ha, ovn-northd gateway chassis propagation

2017-07-12 Thread Miguel Angel Ajo
From: "majop...@redhat.com" The redirect-chassis option of logical router ports is now translated to Gateway_Chassis entries for backwards compatibility. Gateway_Chassis entries in nbdb are copied over to sbdb and linked them to the Chassis entry. Co-authored-by: Anil

[ovs-dev] [PATCH v4 4/7] ovn: l3ha, handling of multiple gateway chassis

2017-07-12 Thread Miguel Angel Ajo
From: "majop...@redhat.com" This patch handles multiple gateway_chassis within chassisredirect ports. All the gateway_chassis within chassisredirect port will implement the rules to de-encapsulate incoming packets for such port (please note that later patches in the series

[ovs-dev] Business Proposal 2017

2017-07-12 Thread Denelle Hope
Hi Good day. Would you be interested to get in touch with Key Decision Makers across B2B industry sector as mentioned below? We provide complete contact information like dual verified Opt-in Email address, direct Phone no and other business information. Below are the Industry sector,

[ovs-dev] [PATCH v4 1/7] ovn: l3ha, add extra check on distributed gateway ports

2017-07-12 Thread Miguel Angel Ajo
Check that removing the options:redirect-chassis in NBDB is going to remove the cr-${port} in the SBDB. This is introduced to avoid any regression of this behaviour on the l3ha series. Signed-off-by: Miguel Angel Ajo --- tests/ovn.at | 8 1 file changed, 8

[ovs-dev] [PATCH v4 7/7] ovn: l3ha, gratuitous ARP for HA router

2017-07-12 Thread Miguel Angel Ajo
From: Venkata Anil Kommaddi This patch extends gratuitous ARP support for NAT addresses so that it applies to centralized NAT rules on a HA router. Gratuitous ARP packets for centralized NAT rules on a HA router are only generated on the active gateway chassis.

Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-12 Thread Eric Garver
On Wed, Jul 12, 2017 at 02:17:38PM +0200, Thomas Morin wrote: > Hi Eric, > > > 2017-07-11, Eric Garver: > > > Inserting an important note for reviewers/testers. > [...] > > > > > > Note: This depends on vport-netdev changes to allow L3 netdev ports, > > > kernel commit 217ac77a3c25

[ovs-dev] [PATCH v4 5/7] ovn: l3ha, enable bfd between tunnel endpoints

2017-07-12 Thread Miguel Angel Ajo
From: Venkata Anil This patch enables bfd protocol between gateways and transport nodes, all gateway nodes with any HA chassisredirect port will enable BFD to all tunnel endpoints, while transport nodes will enable BFD to all tunnel endpoints hosting an HA gateway

[ovs-dev] [PATCH v4 6/7] ovn: l3ha, make is_chassis_active aware of gateway_chassis

2017-07-12 Thread Miguel Angel Ajo
From: "majop...@redhat.com" is_chassis_active now is only true for redirect-chassis ports in the case of the specific lport being active on the local chassis. This will naturally make the ARP responder / redirection openflow rules automatically inserted/removed when a

Re: [ovs-dev] [PATCH 00/10] Support layer3 VXLAN-GPE and GRE in kernel datapath

2017-07-12 Thread thomas.morin
On 7/12/17 2:17 PM, Thomas Morin wrote: However, as per our discussion on irc yesterday [1], I wasn't able to have this working (issue on reception) on an 4.8.x kernel, even with the openvswitch kernel module provided with OVS. Is it possible that another kernel fix/modification is needed that

Re: [ovs-dev] [PATCH v2] netdev-linux: Replace sendmsg with sendmmsg in netdev_linux_send

2017-07-12 Thread Ben Pfaff
On Fri, Jul 07, 2017 at 12:39:51AM +, Zhenyu Gao wrote: > Sendmmsg can reduce cpu cycles in sending packets to kernel. > Replace sendmsg with sendmmsg in function netdev_linux_send to send > batch packets if sendmmsg is available. > > If kernel side doesn't support sendmmsg, will fallback to

Re: [ovs-dev] [PATCH 2/2] openvswitch-switch.postinst: Remove upstart files.

2017-07-12 Thread Ben Pfaff
On Mon, Jun 26, 2017 at 04:05:14AM -0700, Gurucharan Shetty wrote: > For a while, ubuntu used upstart scripts as an alternative > for sysv scripts. For e.g popular releases like ubuntu12.04 > and ubuntu14.04 have upstart infrastructure. From Ubuntu16.04, > they have moved to systemd. > > Ubuntu

Re: [ovs-dev] [PATCH v3] netdev-dpdk: use rte_eth_dev_set_mtu

2017-07-12 Thread Darrell Ball
On 7/12/17, 1:04 AM, "Kavanagh, Mark B" wrote: >From: Darrell Ball [mailto:db...@vmware.com] >Sent: Tuesday, July 11, 2017 5:03 PM >To: Kavanagh, Mark B ; Chandran, Sugesh >;

Re: [ovs-dev] [PATCH v3 1/3] conntrack: Move ct_state parsing to lib/flow.c

2017-07-12 Thread Ben Pfaff
On Tue, Jun 27, 2017 at 11:11:32AM -0700, Yi-Hung Wei wrote: > This patch moves conntrack state parsing function from ovn-trace.c to > lib/flow.c, because it will be used by ofproto/trace unixctl command > later on. It also updates the ct_state checking logic, since we no longer > assume

Re: [ovs-dev] [PATCH] netdev: fix crash when ifa_netmask is null

2017-07-12 Thread Ben Pfaff
On Wed, Jul 12, 2017 at 04:19:38PM +0800, linhaifeng wrote: > 在 2017/7/12 12:55, Ben Pfaff 写道: > > On Tue, Jul 04, 2017 at 08:52:57AM +0800, Haifeng Lin wrote: > >> The ifa_netmask is null when failed to call ioctl > >> in getifaddrs > >> > >> Signed-off-by: Haifeng Lin >

Re: [ovs-dev] [PATCH 1/2] openvswitch-switch.postinst: Replace tabs by spaces

2017-07-12 Thread Ben Pfaff
On Mon, Jun 26, 2017 at 04:05:13AM -0700, Gurucharan Shetty wrote: > There was some inconsistency with some tabs and some spaces > used at different places. > > Signed-off-by: Gurucharan Shetty Acked-by: Ben Pfaff ___ dev

Re: [ovs-dev] [PATCH 2/2] openvswitch-switch.postinst: Remove upstart files.

2017-07-12 Thread Guru Shetty
On 12 July 2017 at 09:34, Ben Pfaff wrote: > On Mon, Jun 26, 2017 at 04:05:14AM -0700, Gurucharan Shetty wrote: > > For a while, ubuntu used upstart scripts as an alternative > > for sysv scripts. For e.g popular releases like ubuntu12.04 > > and ubuntu14.04 have upstart

[ovs-dev] [PATCH] socket-util: Support sendmmsg() on Linux and non-Linux platforms.

2017-07-12 Thread Ben Pfaff
This will have its first user in an upcoming commit. Signed-off-by: Ben Pfaff --- configure.ac| 3 ++- include/sparse/sys/socket.h | 5 + lib/socket-util.c | 38 ++ lib/socket-util.h | 25

Re: [ovs-dev] [PATCH 1/2] checkpatch: Suggest ovs_assert() to author.

2017-07-12 Thread Ben Pfaff
On Mon, Jun 26, 2017 at 03:13:05PM -0400, Aaron Conole wrote: > Bhanuprakash Bodireddy writes: > > > Suggest the author to use the OVS wrapper of the assert function. > > > > Signed-off-by: Bhanuprakash Bodireddy > > --- > >

Re: [ovs-dev] [PATCH 2/2] ovsschema: Fix line lengths.

2017-07-12 Thread Ben Pfaff
On Sun, Jun 18, 2017 at 09:48:10PM +0100, Bhanuprakash Bodireddy wrote: > According to coding style the line lengths should be <=79. Fix the > schema file and update only the checksum as no changes are made to > schema. > > Signed-off-by: Bhanuprakash Bodireddy

Re: [ovs-dev] [PATCH] ovn-northd: Optimize acl of localnet-port

2017-07-12 Thread Han Zhou
On Sun, Jul 9, 2017 at 6:51 PM, wrote: > > Localnet port is not an endpoint, and have no security requirements > to use localnet port at present. So, for performance consideration, we > could do not use ct for localnet port. > > The more specific discussion can be found

[ovs-dev] [PATCH] conntrack: Fix for force/commit bug

2017-07-12 Thread Greg Rose
When the direction is being forced key->ct_state may not have been set. Check for this condition and take action to set the state correctly so that the force direction occurs. Co-authored-by: Joe Stringer Signed-off-by: Joe Stringer Signed-off-by: Greg Rose

Re: [ovs-dev] [RFC v2 4/4] docs: Document ingress scheduling feature

2017-07-12 Thread O Mahony, Billy
Hi Darrell, Thanks for reviewing. > -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, July 11, 2017 7:29 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: Re: [ovs-dev] [RFC v2 4/4] docs: Document ingress scheduling >

Re: [ovs-dev] [RFC v2 2/4] netdev-dpdk: Apply ingress_sched config to dpdk phy ports

2017-07-12 Thread O Mahony, Billy
> -Original Message- > From: Darrell Ball [mailto:db...@vmware.com] > Sent: Tuesday, July 11, 2017 6:49 PM > To: O Mahony, Billy ; d...@openvswitch.org > Subject: Re: [ovs-dev] [RFC v2 2/4] netdev-dpdk: Apply ingress_sched config > to dpdk phy ports > > > >

[ovs-dev] Procedimientos de Contabilidad + 11 Temas

2017-07-12 Thread Promo del mes de Julio
Buenas Tardes: Este mes de Julio le invitamos a adquirir una de nuestras pólizas de Capacitación online, los cuáles constan de 12 Temas que son utilizables durante 3 meses, las 24 hrs del día, las veces que usted así lo requiera. En Específico le ofrecemos el plan de Contabilidad y Finanzas

Re: [ovs-dev] [PATCH] conntrack: Fix for force/commit bug

2017-07-12 Thread Greg Rose
On 07/12/2017 02:38 PM, Joe Stringer wrote: On 12 July 2017 at 11:05, Greg Rose wrote: When the direction is being forced key->ct_state may not have been set. Check for this condition and take action to set the state correctly so that the force direction occurs.

Re: [ovs-dev] [PATCH 5/6] test-conntrack: Fix dead store reported by clang.

2017-07-12 Thread Andy Zhou
On Tue, Jul 11, 2017 at 9:16 PM, Ben Pfaff wrote: > On Fri, Jun 23, 2017 at 09:49:19AM +, Kavanagh, Mark B wrote: >> >From: ovs-dev-boun...@openvswitch.org >> >[mailto:ovs-dev-boun...@openvswitch.org] On Behalf Of >> >Bhanuprakash Bodireddy >> >Sent: Monday, June 19, 2017 7:54

Re: [ovs-dev] [PATCH] conntrack: Fix for force/commit bug

2017-07-12 Thread Joe Stringer
On 12 July 2017 at 11:05, Greg Rose wrote: > When the direction is being forced key->ct_state may not have been > set. Check for this condition and take action to set the state > correctly so that the force direction occurs. > > Co-authored-by: Joe Stringer >

Re: [ovs-dev] [PATCH v3 2/3] ofproto/trace: Add support for tracing conntrack recirculation

2017-07-12 Thread Ben Pfaff
On Tue, Jun 27, 2017 at 11:11:33AM -0700, Yi-Hung Wei wrote: > Previously, a user need to run ofproto/trace multiple times to derive the > final datapath actions if a flow hit conntrack actions that involves > recirculation. To improve the usability of ofproto/trace, in this patch, > we keep track

Re: [ovs-dev] [PATCH v3 3/3] ofproto/trace: Add --ct-next option to ofproto/trace

2017-07-12 Thread Ben Pfaff
On Tue, Jun 27, 2017 at 11:11:34AM -0700, Yi-Hung Wei wrote: > Previous patch enables ofproto/trace to automatically trace a flow > that involves multiple recirculation on conntrack. However, it always > sets the ct_state to trk|est when it processes recirculated conntrack flows. > With this

[ovs-dev] [PATCH] nx-match: Don't append "ct_nw_proto" nx_match if mask not set.

2017-07-12 Thread Justin Pettit
The function nx_put_raw() shouldn't append "ct_nw_proto" to nx_match if the corresponding mask isn't set. Signed-off-by: Justin Pettit --- lib/nx-match.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/nx-match.c b/lib/nx-match.c index