Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On 7/27/2017 11:32 AM, Simon Horman wrote: On Thu, Jul 27, 2017 at 11:29:10AM +0300, Or Gerlitz wrote: On 7/27/2017 11:00 AM, Simon Horman wrote: Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per second" and use that to convert ticks to msecs. This is how iproute does the

Re: [ovs-dev] [PATCH v2 0/4] Output packet batching.

HI Ilya, I am OOO and would review and test this patch series shortly(by Monday). Bhanuprakash. >-Original Message- >From: Ilya Maximets [mailto:i.maxim...@samsung.com] >Sent: Wednesday, July 26, 2017 4:21 PM >To: ovs-dev@openvswitch.org; Bodireddy, Bhanuprakash

Re: [ovs-dev] [PATCH] dpif: Refactor obj type from void pointer to dpif_class

On Wed, Jul 26, 2017 at 02:35:10PM -0700, Joe Stringer wrote: > On 24 July 2017 at 22:28, Roi Dayan wrote: > > It's basically what is being passed today and passing a specific > > type adds a compiler type check. > > > > Signed-off-by: Roi Dayan > >

Re: [ovs-dev] [PATCH V2] tc: Add SCTP support

On Wed, Jul 26, 2017 at 02:35:51PM -0700, Joe Stringer wrote: > On 25 July 2017 at 04:39, Roi Dayan wrote: > > From: Vlad Buslov > > > > Implement SCTP source and destination ports support for flower. > > > > Signed-off-by: Vlad Buslov

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On Thu, Jul 27, 2017 at 11:29:10AM +0300, Or Gerlitz wrote: > On 7/27/2017 11:00 AM, Simon Horman wrote: > >>Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per > >>second" and use that to convert ticks to msecs. > >>This is how iproute does the conversion when parsing tc filters.

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On 27/07/2017 11:37, Or Gerlitz wrote: On 7/27/2017 11:32 AM, Simon Horman wrote: On Thu, Jul 27, 2017 at 11:29:10AM +0300, Or Gerlitz wrote: On 7/27/2017 11:00 AM, Simon Horman wrote: Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per second" and use that to convert ticks

Re: [ovs-dev] Revisit OVN meeting schedule?

Thank you for bringing this up. #1 works great for me, but #2 also works. On Wed, Jul 26, 2017 at 6:14 PM, Daniel Alvarez Sanchez wrote: > On Wed, Jul 26, 2017 at 5:13 PM, Ben Pfaff wrote: > > > On July 26, 2017 8:07:57 AM PDT, Russell Bryant

[ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

From: Paul Blakey Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per second" and use that to convert ticks to msecs. This is how iproute does the conversion when parsing tc filters. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On Thu, Jul 27, 2017 at 09:14:00AM +0300, Roi Dayan wrote: > From: Paul Blakey > > Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per > second" and use that to convert ticks to msecs. > This is how iproute does the conversion when parsing tc filters. > >

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On 7/27/2017 11:00 AM, Simon Horman wrote: Use sysconf(_SC_CLK_TCK) to read run time "number of clock ticks per second" and use that to convert ticks to msecs. This is how iproute does the conversion when parsing tc filters. Signed-off-by: Paul Blakey Reviewed-by: Roi

Re: [ovs-dev] OVS-DPDK public meeting

26th July 2017 ATTENDEES: Aaron C, Antonio F, Ciara L, Darrell B, Flavio L, Mark M, Shachar B, Olga A, Sugesh C, Thomas M, Mark K, Michael L, Johan T, Peter S, Ian S, Kevin T, Yipeng W, Bob D, Jason van A, Billy O'M (may have missed some) === GENERAL === - OVS 2.8 -- Probably branch next

[ovs-dev] [PATCH] dpif-netlink-rtnl: Fix false errors on interfaces without tunnel config

When we skip adding a port using rtnetlink and not because of an error we need to return EOPNOTSUPP to avoid logging an error message. Fixes: 2fd3d5eda508 ("dpif-netlink-rtnl: Support layer3 GRE") Signed-off-by: Roi Dayan Reviewed-by: Paul Blakey ---

Re: [ovs-dev] [PATCH v7 1/1] ovn: l3ha, CLI for logical router port gateway chassis

On Tue, Jul 18, 2017 at 2:05 AM, Venkata Anil Kommaddi wrote: > From: Venkata Anil > > This change adds commands to set, get and delete gateway chassis > for logical router port. > > Signed-off-by: Venkata Anil Kommaddi > --- >

Re: [ovs-dev] [PATCH] dpif-netlink: Fix log level for error message

On Thu, Jul 27, 2017 at 10:27:18AM +0300, Roi Dayan wrote: > Since it's an error message log it with VLOG_ERR instead of VLOG_INFO. > > Signed-off-by: Roi Dayan > --- > lib/dpif-netlink.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

[ovs-dev] [PATCH 3/3] netdev-tc-offloads: Parse ip related fields only if eth type is ip

From: Paul Blakey No need to parse ip related fields otherwise. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

[ovs-dev] [PATCH 0/3] Small refactoring related to tc

Hi, The following patches are small refactoring related to tc. Thanks, Roi Paul Blakey (3): tc: Refactor nl_msg_put_flower_options tc: Split IPs and transport layer ports unions in flower struct netdev-tc-offloads: Parse ip related fields only if eth type is ip lib/netdev-tc-offloads.c

Re: [ovs-dev] Openvswitch crash when bringing down the dpdk bond port using "ovs-ofctl mod-port br-prv dpdk1 down"

I think this patch will have below issue though I don't know how much impact it will cause. packet which are not processed and present in the dpdk port’s rxq at the time of bringing down the port (using mod-port) they will remain there. And next time when Somebody bring up the port(using

[ovs-dev] [PATCH] docs: Move restart related note to appropriate place.

Currently, 'restart' related note is at the end of 'Setup OVS' section. This makes the reader think that changing the 'pmd-cpu-mask' requires application restart. It was mistakenly moved while converting to rST. Fix that by moving the note closer to options it relates to. CC: Stephen Finucane

Re: [ovs-dev] [PATCH v2] ofproto-dpif-ipfix: add support for per-flow drop counters

Hi Ben, I did some additional investigation and I finally figured out why I was unable to see 'sample' action. The reason was that I was using 100% sampling probability for my tests. In such a case 'sample' action is not created. Decreasing sampling probability solved the issue, but only

[ovs-dev] [PATCH 2/3] tc: Split IPs and transport layer ports unions in flower struct

From: Paul Blakey Split dst/src_port and ipv4/ipv6 union so we can distingush them easily for later features. Signed-off-by: Paul Blakey Reviewed-by: Roi Dayan --- lib/netdev-tc-offloads.c | 29 + lib/tc.c

Re: [ovs-dev] [PATCH] tc: Correct convert ticks to msecs on parsing tc TM

On 7/27/2017 1:14 PM, Roi Dayan wrote: the system call is done only once. good to know, would be worth to mention that on the change-log, so it's clear we're good w.r.t performance. Or. ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH 0/3] Small refactoring related to tc

On 27/07/2017 13:19, Roi Dayan wrote: Hi, The following patches are small refactoring related to tc. Thanks, Roi Paul Blakey (3): tc: Refactor nl_msg_put_flower_options tc: Split IPs and transport layer ports unions in flower struct netdev-tc-offloads: Parse ip related fields only if

[ovs-dev] hola

how are you doing my dear friend?Wie geht es dir mein lieber freund ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3 0/2] basic encap/decap

Hi, As Yi wrote before, we would appreciate if somebody could review the series. I won't be available for the next two weeks and Jan is on vacation until 4th August. So, none of us will be able to update the patches next week. Best regards, Zoltan > -Original Message- > From:

[ovs-dev] [PATCH] ovs-ovctl: Fix "OpenFlow versions" in ovs-ofctl -V

Fix the output of "ovs-ofctl -V" to show OpenFlow 1.4 as max supported versions since OpenFlow 1.4 was enabled by default in commit 8d3485791188 ("OpenFlow: Enable OpenFlow 1.4 by default.") CC: Ben Pfaff Signed-off-by: Timothy Redaelli ---

Re: [ovs-dev] [PATCH v2] ovn: Restrict encap modification to its creating chassis

On Wed, Jul 26, 2017 at 5:05 PM, Mark Michelson wrote: > This patch extends RBAC restrictiveness of the encap table in > the ovn southbound database by only allowing modification by the > chassis that created the encap. > > Signed-off-by: Mark Michelson

Re: [ovs-dev] Revisit OVN meeting schedule?

> On Jul 26, 2017, at 8:07 AM, Russell Bryant wrote: > > It has been difficult for some of our newer contributors in Europe to > make our weekly OVN IRC meeting, so I wanted to revisit the schedule. > Roughly we have 2 options to consider: > > 1) Change the time to accommodate

Re: [ovs-dev] [PATCH] docs: Move restart related note to appropriate place.

-Original Message- From: on behalf of Ilya Maximets Date: Thursday, July 27, 2017 at 3:53 AM To: "ovs-dev@openvswitch.org" , Stephen Finucane Cc: Ilya Maximets

Re: [ovs-dev] [PATCH] dpif-netlink: Fix log level for error message

On 27 July 2017 at 05:43, Eric Garver wrote: > On Thu, Jul 27, 2017 at 10:27:18AM +0300, Roi Dayan wrote: >> Since it's an error message log it with VLOG_ERR instead of VLOG_INFO. >> >> Signed-off-by: Roi Dayan >> --- >> lib/dpif-netlink.c | 4 ++-- >> 1 file

Re: [ovs-dev] [PATCH 2/2] travis: Fail the build if any of the Linux build preparations fail.

> On Jul 27, 2017, at 1:41 PM, Ben Pfaff wrote: > > We want the build to fail if we can't prepare properly for it, but > linux-prepare.sh ignored errors. This fixes the problem. > > This would have made it more obvious where the problem fixed by the > previous commit originated.

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit wrote: > > Signed-off-by: Justin Pettit > --- > NEWS| 1 + > include/ovn/actions.h | 67 --- > ovn/controller/ovn-controller.8.xml | 9 +++ >

Re: [ovs-dev] [PATCH] docs: Move restart related note to appropriate place.

I sent a patch here to consolidate and make more coherent the various pmd-cpu-mask references https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336367.html This includes removing a reference to the pmd-cpu-mask under the setup section and pointing the reader to the Performance Tuning

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

> On Jul 27, 2017, at 4:03 PM, Han Zhou wrote: > > > > On Wed, Jul 26, 2017 at 1:55 PM, Justin Pettit wrote: > > > > Signed-off-by: Justin Pettit > > --- > > NEWS| 1 + > > include/ovn/actions.h

Re: [ovs-dev] [PATCH] dpif-netlink: Fix log level for error message

On Thu, Jul 27, 2017 at 10:17:48AM -0700, Joe Stringer wrote: > On 27 July 2017 at 05:43, Eric Garver wrote: > > On Thu, Jul 27, 2017 at 10:27:18AM +0300, Roi Dayan wrote: > >> Since it's an error message log it with VLOG_ERR instead of VLOG_INFO. > >> > >> Signed-off-by: Roi Dayan

[ovs-dev] [PATCH] netlink: Correct comment for nl_msg_put_unspec().

Signed-off-by: Justin Pettit --- lib/netlink.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/netlink.c b/lib/netlink.c index 4cf1aaca621c..de3ebcd0e792 100644 --- a/lib/netlink.c +++ b/lib/netlink.c @@ -235,8 +235,7 @@ nl_msg_put_unspec_zero(struct

[ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse build.

Newer travis environments claim to have LLVM support (llvm-config exists and works) but in reality don't, which prevents sparse from building and later parts of the build from succeeding. Signed-off-by: Ben Pfaff --- .travis/linux-prepare.sh | 7 ++- 1 file changed, 6

Re: [ovs-dev] [PATCH 1/3] ofproto-dpif-rid: Include action length as part of hash.

On Thu, Jul 13, 2017 at 11:30:49PM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > ofproto/ofproto-dpif-rid.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ofproto/ofproto-dpif-rid.c b/ofproto/ofproto-dpif-rid.c > index d546b150b938..26c2357007b2

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Store tunnel metadata in frozen metadata directly.

On Thu, Jul 27, 2017 at 07:26:49PM -0700, Justin Pettit wrote: > > > On Jul 27, 2017, at 4:24 PM, Ben Pfaff wrote: > > > > On Thu, Jul 13, 2017 at 11:30:50PM -0700, Justin Pettit wrote: > >> "recirc_id_node" contains a 'state_metadata_tunnel' member field. The > >>

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Store tunnel metadata in frozen metadata directly.

> On Jul 27, 2017, at 10:27 PM, Ben Pfaff wrote: > > On Thu, Jul 27, 2017 at 07:26:49PM -0700, Justin Pettit wrote: >> >>> On Jul 27, 2017, at 4:24 PM, Ben Pfaff wrote: >>> >>> On Thu, Jul 13, 2017 at 11:30:50PM -0700, Justin Pettit wrote: "recirc_id_node"

Re: [ovs-dev] [PATCH v2] datapath-windows: Refactor OvsCreateNewNBLsFromMultipleNBs

Thanks for refactoring it. Acked-by: Anand Kumar Thanks, Anand Kumar On 7/24/17, 3:31 PM, "ovs-dev-boun...@openvswitch.org on behalf of Shashank Ram" wrote: Previously, the function would take the

[ovs-dev] [patch_v1] docs/dpdk: Consolidate pmd-cpu-mask references.

The DPDK introductory documentation has various references to pmd-cpu-mask, including a section devoted to it. These parts of the documentation seeemed to have been written at different times and look like they were individually ported from other sources. They all include an example command which

Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse build.

Thanks for the reviews. I fixed the trailing whitespace and pushed this to master. On Thu, Jul 27, 2017 at 02:50:25PM -0700, Justin Pettit wrote: > BTW, it appears this does add some trailing whitespace. > > --Justin > > > > On Jul 27, 2017, at 2:16 PM, Justin Pettit wrote:

Re: [ovs-dev] [PATCH 1/3] ofproto-dpif-rid: Include action length as part of hash.

> On Jul 27, 2017, at 1:54 PM, Ben Pfaff wrote: > > On Thu, Jul 13, 2017 at 11:30:49PM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit >> --- >> ofproto/ofproto-dpif-rid.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git

Re: [ovs-dev] [PATCH] netlink: Correct comment for nl_msg_put_unspec().

> On Jul 27, 2017, at 2:11 PM, Joe Stringer wrote: > > On 27 July 2017 at 13:15, Justin Pettit wrote: >> Signed-off-by: Justin Pettit >> --- > > Acked-by: Joe Stringer Thanks. Pushed to master. --Justin

[ovs-dev] [PATCH] ovsdb-server: Document clarification for some bad wording in RFC 7047.

Reported-by: Harish Kanakaraju Signed-off-by: Ben Pfaff --- AUTHORS.rst | 1 + ovsdb/ovsdb-server.1.in | 8 2 files changed, 9 insertions(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index 10c84c185262..8ec7db84e9ea 100644 ---

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Store tunnel metadata in frozen metadata directly.

On Thu, Jul 13, 2017 at 11:30:50PM -0700, Justin Pettit wrote: > "recirc_id_node" contains a 'state_metadata_tunnel' member field. The > "frozen_metadata" structure used by "recird_id_node" had a 'tunnel' > member that always pointed to 'state_metadata_tunnel". This commit just > stores the

Re: [ovs-dev] [PATCH] ovn: Add support for ACL logging.

On Thu, Jul 27, 2017 at 5:59 PM, Justin Pettit wrote: > > > It seems "invalid" packets won't get logged in this patch. I think it would be useful: in addition to log packets per-ACL, enable logging for packets returned as "invalid" state from conntrack. It can be a global

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-rid: Always store tunnel metadata.

> On Jul 27, 2017, at 4:27 PM, Ben Pfaff wrote: > > On Thu, Jul 13, 2017 at 11:30:51PM -0700, Justin Pettit wrote: >> Tunnel metadata was only stored if the tunnel destination was set. It's >> possible, for example, that a flow could set the tunnel id field before >>

Re: [ovs-dev] [PATCH 2/3] ofproto-dpif-rid: Store tunnel metadata in frozen metadata directly.

> On Jul 27, 2017, at 4:24 PM, Ben Pfaff wrote: > > On Thu, Jul 13, 2017 at 11:30:50PM -0700, Justin Pettit wrote: >> "recirc_id_node" contains a 'state_metadata_tunnel' member field. The >> "frozen_metadata" structure used by "recird_id_node" had a 'tunnel' >> member that always

[ovs-dev] [PATCH] ovn-controller: Refactor function of consider_port_binding

The function of consider_port_binding is redundant. This patch divide the function to some sub-function by the port type. Change-Id: I86a408e97e6d6211f3695cf42fc5b858352ac7ff Signed-off-by: wang qianyu --- ovn/controller/physical.c | 819

[ovs-dev] [PATCH] ofproto-dpif-rid: Don't include action_set_len as part of hash.

It doesn't improve the hashing, since the number of bytes hashed is included in hash_bytes64() hash calculation. Signed-off-by: Justin Pettit --- ofproto/ofproto-dpif-rid.c | 1 - 1 file changed, 1 deletion(-) diff --git a/ofproto/ofproto-dpif-rid.c

Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse build.

> On Jul 27, 2017, at 1:41 PM, Ben Pfaff wrote: > > Newer travis environments claim to have LLVM support (llvm-config exists > and works) but in reality don't, which prevents sparse from building and > later parts of the build from succeeding. > > Signed-off-by: Ben Pfaff

Re: [ovs-dev] [PATCH] netlink: Correct comment for nl_msg_put_unspec().

On 27 July 2017 at 13:15, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- Acked-by: Joe Stringer ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] flow: Refactor flow_compose() API.

> > I think, it's better to use 'dp_packet_delete(packet)' instead of two > lines above. 'delete' is the better pair for 'new'. 'uninit' is mostly > for packets allocated statically and initialized by 'dp_packet_init()'. > > Additionally this will help to avoid issues if 'dp_packet_new' will > be

Re: [ovs-dev] [PATCH 1/3] ofproto-dpif-rid: Include action length as part of hash.

On Thu, Jul 27, 2017 at 02:05:22PM -0700, Justin Pettit wrote: > > > On Jul 27, 2017, at 1:54 PM, Ben Pfaff wrote: > > > > On Thu, Jul 13, 2017 at 11:30:49PM -0700, Justin Pettit wrote: > >> Signed-off-by: Justin Pettit > >> --- > >> ofproto/ofproto-dpif-rid.c |

Re: [ovs-dev] [PATCH 1/3] ofproto-dpif-rid: Include action length as part of hash.

> On Jul 27, 2017, at 4:17 PM, Ben Pfaff wrote: > > On Thu, Jul 27, 2017 at 02:05:22PM -0700, Justin Pettit wrote: >> >>> On Jul 27, 2017, at 1:54 PM, Ben Pfaff wrote: >>> >>> On Thu, Jul 13, 2017 at 11:30:49PM -0700, Justin Pettit wrote: Signed-off-by:

Re: [ovs-dev] [PATCH 3/3] ofproto-dpif-rid: Always store tunnel metadata.

On Thu, Jul 13, 2017 at 11:30:51PM -0700, Justin Pettit wrote: > Tunnel metadata was only stored if the tunnel destination was set. It's > possible, for example, that a flow could set the tunnel id field before > recirculation and then set the destination field afterwards. The > previous