Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Darrell Ball
-Original Message- From: Ben Pfaff Date: Wednesday, August 9, 2017 at 10:40 AM To: Darrell Ball Cc: Darrell Ball , "d...@openvswitch.org" Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum

Re: [ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 07:45:13PM +0800, Yi Yang wrote: > In order to adapt to MD type 1 and MD type 2 at the same > time and avoid breaking Linux kernel uAPI later, we change > struct ovs_action_encap_nsh to the below format. > > struct ovs_action_encap_nsh { > uint8_t flags; > uint8_t

Re: [ovs-dev] [PATCH] dp-packet: Use OVS_UNUSED to mark possibly unused parameters.

2017-08-09 Thread Ben Pfaff
Thanks, applied to master. On Wed, Aug 09, 2017 at 06:09:12PM +, Darrell Ball wrote: > Acked-by: Darrell Ball > > -Original Message- > From: on behalf of Ben Pfaff > Date: Wednesday, August 9, 2017 at 10:43 AM > To:

Re: [ovs-dev] [PATCH] ofproto-dpif: Mark packets as "untracked" after call to ct().

2017-08-09 Thread Justin Pettit
Hmm, it was the first time I'd used the internal system tester so I must have invoked it improperly. I'll fix these issues and send out a v2. Thanks, --Justin > On Aug 8, 2017, at 6:02 PM, Darrell Ball wrote: > > I just did a second round > > One correction for first

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Chandran, Sugesh
Hi Darrel, I reviewed and tested the patch. It does fixed the UT failures in --with-dpdk case. One comment below. Regards _Sugesh > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Darrell Ball > Sent: Wednesday,

[ovs-dev] [PATCH v4 0/6] OVS-DPDK rxq to pmd assignment improvements.

2017-08-09 Thread Kevin Traynor
For the DPDK datapath, by default rxqs are assigned to available pmds in round robin order with no weight or priority. It can happen that some very busy queues are handled by one pmd which does not have enough cycles to prevent packets being dropped on them. While at the same time another pmd

Re: [ovs-dev] [PATCH v3 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

2017-08-09 Thread Kevin Traynor
On 08/08/2017 07:15 PM, Greg Rose wrote: > On 08/01/2017 08:58 AM, Kevin Traynor wrote: >> Previously rxqs were assigned to pmds by round robin in >> port/queue order. >> >> Now that we have the processing cycles used for existing rxqs, >> use that information to try and produced a better balanced

[ovs-dev] [PATCH v4 1/6] dpif-netdev: Change polled_queue to use dp_netdev_rxq.

2017-08-09 Thread Kevin Traynor
Soon we will want to store processing cycle counts in the dp_netdev_rxq, so use that as a basis for the polled_queue that pmd_thread_main uses. Signed-off-by: Kevin Traynor --- lib/dpif-netdev.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Ben Pfaff
On Tue, Aug 08, 2017 at 06:54:46PM -0700, Darrell Ball wrote: > Reset the DPDK HWOL checksum flags in dp_packet_init_. > The new HWOL bad checksum flag is uninitialized for non-dpdk ports and > this is noticed as test failures using netdev-dummy ports, when built with > the --with-dpdk flag set.

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 05:32:02PM +, Darrell Ball wrote: > > > -Original Message- > From: on behalf of Ben Pfaff > Date: Wednesday, August 9, 2017 at 10:15 AM > To: Darrell Ball > Cc: "d...@openvswitch.org"

Re: [ovs-dev] [PATCH] dp-packet: Use OVS_UNUSED to mark possibly unused parameters.

2017-08-09 Thread Darrell Ball
Acked-by: Darrell Ball -Original Message- From: on behalf of Ben Pfaff Date: Wednesday, August 9, 2017 at 10:43 AM To: "d...@openvswitch.org" Cc: Ben Pfaff Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 09:41:51AM +, Yang, Yi Y wrote: > Hi, Jan > > I have worked out a patch, will send it quickly for Ben. In addition, I also > will send out a patch to change encap_nsh _nsh to push_nsh and pop_nsh. > Per comments from all the people, we all agreed to do so :-) > >

Re: [ovs-dev] [PATCH v5 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-08-09 Thread Ben Pfaff
On Fri, Aug 04, 2017 at 04:09:58PM +0530, Numan Siddique wrote: > On Fri, Aug 4, 2017 at 3:02 AM, Ben Pfaff wrote: > > > On Mon, Jul 31, 2017 at 06:11:35PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > This patch adds a new OVN

[ovs-dev] Starting point for extending OVS

2017-08-09 Thread Chui Hui Chiu
Hello, We are students trying to extend OVS in the Linux environment for our research works. We have primitive understandings of OVS after reading the documents. However, we are uncertain whether we are on the adequate track. The new features of our design and our speculated starting points

Re: [ovs-dev] [PATCH] ovs-vsctl-bashcomp: Make compatible with busybox "awk".

2017-08-09 Thread Ben Pfaff
On Fri, Aug 04, 2017 at 09:54:26AM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: d...@openvswitch.org > > Cc: "Ben Pfaff" , "Stuart Cardall" > > > > Sent: Friday, 14 July, 2017 12:42:54 AM > > Subject: [ovs-dev] [PATCH]

Re: [ovs-dev] [PATCH v1] netdev-dpdk: Implement TCP/UDP TX cksum in ovs-dpdk side

2017-08-09 Thread Gao Zhenyu
I see, for flows in phy-phy setup, they should not be calculate cksum. I will revise my patch to do the cksum for vhost port only. I will send a new patch next week. Thanks Zhenyu Gao 2017-08-08 17:53 GMT+08:00 Loftus, Ciara : > > > > Hi Loftus, > > > > Thanks for

Re: [ovs-dev] [PATCHv2 1/4] ovsdb-idl: Avoid class declaration.

2017-08-09 Thread Gao Zhenyu
How about: struct ovsdb_idl_table { ... const struct ovsdb_idl_table_class *table_class } struct ovsdb_idl { const struct ovsdb_idl_class *idl_class; Besides of that, I see many places consume the table class. Do you mind to make a macro helps to fetch the class? Like:

Re: [ovs-dev] [PATCHv2 2/4] ovsdb-idl: Avoid mutable type specifier.

2017-08-09 Thread Gao Zhenyu
How about mutable --> is_mutable ? Thanks Zhenyu Gao 2017-08-10 6:27 GMT+08:00 Joe Stringer : > In C++, 'mutable' is a keyword. If this is used as the name for a field, > then C++ compilers can get confused about the context and fail to > compile references to such fields. Rename

Re: [ovs-dev] DPDK build errors on travis

2017-08-09 Thread Darrell Ball
-Original Message- From: Ben Pfaff Date: Tuesday, August 8, 2017 at 11:22 AM To: Darrell Ball Cc: "d...@openvswitch.org" Subject: Re: [ovs-dev] DPDK build errors on travis Yes, travis is switching. We need to adapt to it

[ovs-dev] [PATCH v3] route-table: Remove netdevs in netdev_hash when deleted

2017-08-09 Thread fukaige
From: Kaige Fu Start a virtual machine with its backend tap device attached to a brought up linux bridge. If we delete the linux bridge when vm is still running, we'll get the following error when trying to create a ovs bridge with the same name. The reason is that

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

2017-08-09 Thread Jan Scheurich
Hi all, In OVS 2.8 we support only fixed size NSH MD1 context data for matching and in set/copy_field actions. OVS parses an MD2 NSH header but does not make any TLV headers available to OF. The plan is to add support for matching/manipulating NSH MD2 TLVs through a new infrastructure of

[ovs-dev] [patch_v1] travis: Fix DPDK builds in new environment.

2017-08-09 Thread Darrell Ball
The following error is seen: 17.05.1/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:29: /home/travis/build/darball/ovs/linux-3.16.46/arch/x86/include/asm/ dma-mapping.h:32:35: error: inlining failed in call to ‘get_dma_ops’: call is unlikely and code size would grow [-Werror=inline]

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Ilya Maximets
Not a full review. One comment inline. > Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User > port queues. Also add netdev_dpdk_vhost_tx_burst() function that > uses rte_vhost_enqueue_burst() to enqueue burst of packets on vHost User > ports. > > Signed-off-by: Bhanuprakash

Re: [ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

2017-08-09 Thread Ilya Maximets
Not a full review. Comments inline. > Add netdev_txq_flush(), that flush packets on a queue. This is needed > to transmit packets on the intermediate queue. > > This commit also implements netdev_dpdk_txq_flush() function. If there > are any packets waiting in the queue, they are transmitted

Re: [ovs-dev] [PATCH 0/5] dpif-netdev: Cuckoo-Distributor implementation

2017-08-09 Thread Fischetti, Antonio
Any comment on this patchset? Adding Jan in CC. In one of the last bi-weekly meeting there was some interest in testing this patchset in conjunction with the patch to avoid using EMC for recirculated packets - this is contained inside the patchset

Re: [ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

2017-08-09 Thread Miguel Angel Ajo Pelayo
Nice idea, I have btw some comments/thoughts/questions regarding this: 1) Does OVSDB have any heartbeat protocol? (to detect that one northd has died even during inactive periods). Otherwise we can document the need to tweak the tcp_keepalive settings of the system to have some sensible

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Ilya Maximets
One more comment inline. On 09.08.2017 11:06, Ilya Maximets wrote: > Not a full review. > One comment inline. > >> Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User >> port queues. Also add netdev_dpdk_vhost_tx_burst() function that >> uses rte_vhost_enqueue_burst() to

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

2017-08-09 Thread Yang, Yi Y
Hi, Jan I have worked out a patch, will send it quickly for Ben. In addition, I also will send out a patch to change encap_nsh _nsh to push_nsh and pop_nsh. Per comments from all the people, we all agreed to do so :-) diff --git a/datapath/linux/compat/include/linux/openvswitch.h

Re: [ovs-dev] [PATCHv2] ovn: Add support for ACL logging.

2017-08-09 Thread Miguel Angel Ajo Pelayo
Nice addition :D On Sat, Jul 29, 2017 at 2:01 AM, Justin Pettit wrote: > > > On Jul 28, 2017, at 4:57 PM, Ben Pfaff wrote: > > > > On Fri, Jul 28, 2017 at 03:48:38PM -0700, Justin Pettit wrote: > >> Signed-off-by: Justin Pettit > >> Acked-by:

[ovs-dev] Why my AT_CHECK() can't work?

2017-08-09 Thread Sam
Hi all, I'm using autotest to test ovs, and I write a new *.at file using only one AT_CHECK sentence like this: AT_CHECK([ovs-appctl dpdk/bond-show dpdkb2], [0], [stdout]) > AT_CHECK([[sed '/ACTIVE/p' stdout | head -4]], [0], [[LACP actor_state > ACTIVE AGGREGATION SYNC COLLECTING DISTRIBUTING >

Re: [ovs-dev] Why my AT_CHECK() can't work?

2017-08-09 Thread Sam
Then I change commd into `awk '/ACTIVE/' stdout | head -4`, it failed again, log is : ./netdev-dpdk.at:28: awk '/ACTIVE/' stdout | head -4 > --- - 2017-08-09 17:41:24.809066088 +0800 > +++ /home/gangyewei-3/mvs/mvs/tests/testsuite.dir/at-groups/789/stdout > 2017-08-09 17:41:24.807150522 +0800

[ovs-dev] [PATCH] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Yi Yang
In order to adapt to MD type 1 and MD type 2 at the same time and avoid breaking Linux kernel uAPI later, we change struct ovs_action_encap_nsh to the below format. struct ovs_action_encap_nsh { uint8_t flags; uint8_t mdtype; uint8_t mdlen; uint8_t np; __be32 path_hdr;

[ovs-dev] [PATCH v1 2/2] nsh: rename encap_nsh and decap_nsh as push_nsh and pop_nsh

2017-08-09 Thread Yi Yang
Per kernel data path naming convention, we need to rename encap_nsh and decap_nsh as push_nsh and pop_nsh, respectively. This change will make sure our data path actions follow the same convention in both userspace and kernel data path. The variables, structs, function names are also changed to

[ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Yi Yang
In order to adapt to MD type 1 and MD type 2 at the same time and avoid breaking Linux kernel uAPI later, we change struct ovs_action_encap_nsh to the below format. struct ovs_action_encap_nsh { uint8_t flags; uint8_t mdtype; uint8_t mdlen; uint8_t np; __be32 path_hdr;

[ovs-dev] [PATCH v1 0/2] nsh: change data path action names and struct to adapt to kernel requirements

2017-08-09 Thread Yi Yang
This patch series is to adapt to kernel data path requirments, all the people have made an agreement, we need to use variable struct ovs_action_encap_nsh and push_nsh & pop_nsh. Yi Yang (2): nsh: enable struct ovs_action_encap_nsh to support variable length nsh: rename encap_nsh and decap_nsh

Re: [ovs-dev] [PATCH] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Yang, Yi Y
Please ignore this one and use this series https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337128.html which includes this one. -Original Message- From: Yang, Yi Y Sent: Wednesday, August 9, 2017 5:56 PM To: d...@openvswitch.org Cc: b...@ovn.org; Yang, Yi Y

[ovs-dev] ovsdb-server replication: Possible to exclude syncing specific column of a table??

2017-08-09 Thread Arunkumar Rg
Hi All, I need a clarification on ovsdb-server replication's set-sync-exclude-tables. *Is there a way, by which we can say exclude syncing specific column of a table??* The use case I'm looking at is: 1. The replication is configured for DB "hardware_vtep". 2. I'm trying to use the

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Ilya Maximets
On 09.08.2017 13:03, Ilya Maximets wrote: > One more comment inline. > > On 09.08.2017 11:06, Ilya Maximets wrote: >> Not a full review. >> One comment inline. >> >>> Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User >>> port queues. Also add netdev_dpdk_vhost_tx_burst()

[ovs-dev] Spring Roll Pastry

2017-08-09 Thread Bonesca
  [ View in browser ]( http://r.newsletter.bonescamail.nl/nru6rm8uoatrf.html )         TYJ SPRING ROLL PASTRY SINGAPORE   Code - Description 8842  - 215 mm 40 leaves 20 x 500 gr 8843  - 250 mm 30 leaves 30 x 500 gr   1 Box € 1,75 10 Box € 1,65 Palet € 1,55 per pack!     This email was sent

Re: [ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

2017-08-09 Thread Bodireddy, Bhanuprakash
Hi Ilya, >> >> +/* Flush tx queues. >> + * This is done periodically to empty the intermediate queue in case >> +of >> + * fewer packets (< INTERIM_QUEUE_BURST_THRESHOLD) buffered in the >queue. >> + */ >> +static int >> +netdev_dpdk_txq_flush(struct netdev *netdev, int qid , bool >>

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Bodireddy, Bhanuprakash
>> >> +static int >> +netdev_dpdk_vhost_tx_burst(struct netdev_dpdk *dev, int qid) { >> +struct dpdk_tx_queue *txq = >tx_q[qid]; >> +struct rte_mbuf **cur_pkts = (struct rte_mbuf >> +**)txq->vhost_burst_pkts; >> + >> +int tx_vid = netdev_dpdk_get_vid(dev); >> +int tx_qid = qid *

Re: [ovs-dev] [PATCH] tunnel: ToS and TTL inheritance for MPLS tunneled traffic

2017-08-09 Thread Balazs Nemeth
Hi Ben, As Miklos is on vacation, let me answer your questions. The 'latest_nw_tos' variable is storing always the updated value of 'nw_tos'. It is not always the same as 'flow->nw_tos'. E.g. in xlate_sample_action(), 'flow' pointer is declared just before calling tnl_port_send(). In case of

Re: [ovs-dev] [PATCH v4 1/5] netdev: Add netdev_txq_flush function.

2017-08-09 Thread Ilya Maximets
On 09.08.2017 15:29, Bodireddy, Bhanuprakash wrote: > Hi Ilya, >>> >>> +/* Flush tx queues. >>> + * This is done periodically to empty the intermediate queue in case >>> +of >>> + * fewer packets (< INTERIM_QUEUE_BURST_THRESHOLD) buffered in the >> queue. >>> + */ >>> +static int >>>

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Bodireddy, Bhanuprakash
>enable) if (enable) { dev->tx_q[qid].map = qid; >> >> Here flushing required too because we're possibly enabling previously >remapped queue. >> } else { +/* If the queue is disabled in the guest, the

Re: [ovs-dev] [PATCH v4 2/5] netdev-dpdk: Add netdev_dpdk_vhost_txq_flush function.

2017-08-09 Thread Ilya Maximets
On 09.08.2017 15:35, Bodireddy, Bhanuprakash wrote: >>> >>> +static int >>> +netdev_dpdk_vhost_tx_burst(struct netdev_dpdk *dev, int qid) { >>> +struct dpdk_tx_queue *txq = >tx_q[qid]; >>> +struct rte_mbuf **cur_pkts = (struct rte_mbuf >>> +**)txq->vhost_burst_pkts; >>> + >>> +int

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Aaron Conole
Darrell Ball writes: > Thanks Joe > I forgot to add your Tested-by to V5; I have been testing this myself; > but let me know if you would like it added – I can send a V6. It will automatically be added by patchwork. It is sufficient to download (ex:

Re: [ovs-dev] [PATCH] Remove duplicate description about Experimenter classes

2017-08-09 Thread Ben Pfaff
On Tue, Aug 08, 2017 at 02:55:05PM +0800, Yi Yang wrote: > commit 3d2fbd70bda514f7327970b859663f34f994290c brought > duplicate description about Experimenter classes > ONFOXM_ET and NXOXM_NSH in lib/meta-flow.xml, branch-2.8 > has the same issue. > > Signed-off-by: Yi Yang

Re: [ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Yang, Yi Y
Noticed, please check the reply for that one. -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Thursday, August 10, 2017 4:04 AM To: Yang, Yi Y Cc: d...@openvswitch.org Subject: Re: [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support

Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse build.

2017-08-09 Thread Lance Richardson
> From: "Ben Pfaff" > To: d...@openvswitch.org > Cc: "Ben Pfaff" > Sent: Thursday, July 27, 2017 4:41:05 PM > Subject: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse > build. > > Newer travis environments claim to have LLVM support (llvm-config

[ovs-dev] [PATCH trivial 3/3] ovn-northd: Fix minor style variation.

2017-08-09 Thread Joe Stringer
Signed-off-by: Joe Stringer --- ovn/northd/ovn-northd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c index 99d15a7a56c4..49e4ac3383d3 100644 --- a/ovn/northd/ovn-northd.c +++ b/ovn/northd/ovn-northd.c @@

Re: [ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

2017-08-09 Thread Russell Bryant
On Wed, Aug 9, 2017 at 1:29 PM, Ben Pfaff wrote: > On Tue, Aug 01, 2017 at 12:19:18PM -0400, Russell Bryant wrote: >> Add native support for active-standby HA in ovn-northd by having each >> instance attempt to acquire an OVSDB lock. Only the instance of >> ovn-northd that

[ovs-dev] [PATCH v2] python: make python idl unicode-tolerant

2017-08-09 Thread Lance Richardson
Ensure that JSON is utf-8 encoded and that bytes sent/received on the stream sockets are in utf-8 form. Add a test case to verify that unicode data can be sent/received successfully using Python IDL module. Co-authored-by: Terry Wilson Signed-off-by: Terry Wilson

Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant

2017-08-09 Thread Russell Bryant
On Wed, Aug 9, 2017 at 3:32 PM, Ben Pfaff wrote: > On Wed, Aug 09, 2017 at 03:27:32PM -0400, Russell Bryant wrote: >> On Tue, Aug 8, 2017 at 2:44 PM, Lance Richardson wrote: >> > Ensure that JSON is utf-8 encoded and that bytes sent/received on >> > the stream

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Joe Stringer
On 8 August 2017 at 19:10, Darrell Ball wrote: > Thanks Joe > I forgot to add your Tested-by to V5; I have been testing this myself; but > let me know if you would like it added – I can send a V6. No worries, it looks like you'll resubmit with a slightly different approach so

Re: [ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Yang, Yi Y
Ben, no matter it is MD type 1 or MD type 2, we use the same netlink attribute OVS_ACTION_ATTR_ENCAP_NSH to transfer these data, another netlink attribute OVS_KEY_ATTR_NSH is for struct ovs_key_nsh. So I can't catch your point, can you explain it more? -Original Message- From: Ben

Re: [ovs-dev] [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support variable length

2017-08-09 Thread Ben Pfaff
I gave a more detailed explanation later: https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337164.html On Wed, Aug 09, 2017 at 07:52:38PM +, Yang, Yi Y wrote: > Ben, no matter it is MD type 1 or MD type 2, we use the same netlink > attribute OVS_ACTION_ATTR_ENCAP_NSH to transfer

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

2017-08-09 Thread Yang, Yi Y
Ben, do you mean we bring two new attributes (OVS_NSH_ATTR_MD1 and OVS_NSH_ATTR_MD2) and embed one of them in OVS_ACTION_ATTR_ENCAP_NSH? Anyway we need to use a struct or something else to transfer those metadata between functions, how do you think we can handle this without metadata in

[ovs-dev] [PATCH trivial 1/3] netdev-dummy: Fix minor style variation.

2017-08-09 Thread Joe Stringer
Signed-off-by: Joe Stringer --- lib/netdev-dummy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c index 62ddd0c67834..f731af1dfd0e 100644 --- a/lib/netdev-dummy.c +++ b/lib/netdev-dummy.c @@ -1574,7 +1574,7 @@

[ovs-dev] [PATCH 3/3] checkpatch: Check for trailing operators.

2017-08-09 Thread Joe Stringer
The style guide states that lines should not end with '?' or ':'. Check for this and report an error. Signed-off-by: Joe Stringer --- v2: Restrict to '?' and ':'. Make sure that goto tags aren't flagged. --- utilities/checkpatch.py | 14 +- 1 file changed, 13

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Darrell Ball
-Original Message- From: "Chandran, Sugesh" Date: Wednesday, August 9, 2017 at 12:55 PM To: Darrell Ball , Ben Pfaff Cc: "d...@openvswitch.org" Subject: RE: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL

Re: [ovs-dev] [PATCH trivial 1/3] netdev-dummy: Fix minor style variation.

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 01:38:05PM -0700, Joe Stringer wrote: > Signed-off-by: Joe Stringer For all three patches: Acked-by: Ben Pfaff ___ dev mailing list d...@openvswitch.org

Re: [ovs-dev] [PATCH net-next] openvswitch: add NSH support

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 08:12:36PM +, Yang, Yi Y wrote: > Ben, do you mean we bring two new attributes (OVS_NSH_ATTR_MD1 and > OVS_NSH_ATTR_MD2) and embed one of them in OVS_ACTION_ATTR_ENCAP_NSH? Yes. > Anyway we need to use a struct or something else to transfer those > metadata between

Re: [ovs-dev] [PATCH 2/3] checkpatch: Fix matching on C filenames.

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 01:37:51PM -0700, Joe Stringer wrote: > Most of the prerequisite checks so far matched on filenames that ended > in some character followed by 'c' or 'h', rather than a filename that > ends in '.c' or '.h'. Fix this. > > Signed-off-by: Joe Stringer

Re: [ovs-dev] [PATCH 1/3] checkpatch: Check for infix operator whitespace.

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 01:37:50PM -0700, Joe Stringer wrote: > The 'Expressions' section of the coding style specifies that one space > should be on either side of infix binary and ternary operators. This > adds a check to checkpatch.py for most of these. > > The regex won't match if there are

Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant

2017-08-09 Thread Russell Bryant
On Tue, Aug 8, 2017 at 2:44 PM, Lance Richardson wrote: > Ensure that JSON is utf-8 encoded and that bytes sent/received on > the stream sockets are in utf-8 form. Add a test case to verify > that unicode column data can be sent/received successfully using > Python module. >

Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 03:27:32PM -0400, Russell Bryant wrote: > On Tue, Aug 8, 2017 at 2:44 PM, Lance Richardson wrote: > > Ensure that JSON is utf-8 encoded and that bytes sent/received on > > the stream sockets are in utf-8 form. Add a test case to verify > > that unicode

Re: [ovs-dev] [PATCH V3 0/2] Fix for dumping vxlan flows from ovs-dpctl

2017-08-09 Thread Ben Pfaff
On Tue, Aug 08, 2017 at 05:03:10PM +0300, Roi Dayan wrote: > Hi, > > The first patch is to avoid false errors about getting ifindex > as the device might disappear already. > The second patch is a fix for dumping vxlan rules with ovs-dpctl. Thanks for the fixing. I applied these patches to

Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 03:42:05PM -0400, Russell Bryant wrote: > It looked OK for me other than how it made my terminal crash when I > tried to view it. :-) It sounds like you should report a bug to the terminal emulator maintainers. Output shouldn't be able to crash a terminal.

Re: [ovs-dev] [PATCH v2] python: make python idl unicode-tolerant

2017-08-09 Thread Russell Bryant
On Wed, Aug 9, 2017 at 3:38 PM, Lance Richardson wrote: > Ensure that JSON is utf-8 encoded and that bytes sent/received on > the stream sockets are in utf-8 form. Add a test case to verify > that unicode data can be sent/received successfully using Python > IDL module. > >

[ovs-dev] AdvancedMD Users List

2017-08-09 Thread Kristina
Hi, I was curious to know if you would be interested in AdvancedMD Users List 2017? Let me know your target criteria and we will revert back to you with further details. Target Users: Geography: Looking forward to continued success with you. Regards, Kristina Jones |

[ovs-dev] [PATCH trivial 2/3] ofproto-dpif-ipfix: Fix minor style variation.

2017-08-09 Thread Joe Stringer
Signed-off-by: Joe Stringer --- ofproto/ofproto-dpif-ipfix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c index fcba02e45b75..472c27281d5f 100644 --- a/ofproto/ofproto-dpif-ipfix.c +++

Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse build.

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 04:36:42PM -0400, Lance Richardson wrote: > > From: "Ben Pfaff" > > To: d...@openvswitch.org > > Cc: "Ben Pfaff" > > Sent: Thursday, July 27, 2017 4:41:05 PM > > Subject: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse > >

Re: [ovs-dev] [PATCH 3/3] checkpatch: Check for trailing operators.

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 01:37:52PM -0700, Joe Stringer wrote: > The style guide states that lines should not end with '?' or ':'. Check > for this and report an error. > > Signed-off-by: Joe Stringer The comment should be updated since the style considers && at the end of a line

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Darrell Ball
-Original Message- From: "Chandran, Sugesh" Date: Wednesday, August 9, 2017 at 11:17 AM To: Darrell Ball , Ben Pfaff Cc: "d...@openvswitch.org" Subject: RE: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL

Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant

2017-08-09 Thread Lance Richardson
> From: "Russell Bryant" > To: "Ben Pfaff" > Cc: "Lance Richardson" , "ovs dev" > Sent: Wednesday, August 9, 2017 3:42:05 PM > Subject: Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant > > On Wed, Aug 9,

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Chandran, Sugesh
Regards _Sugesh > > > > > > Correct, I reused reset_dp_packet_checksum_ol_flags() to do the > > initialization as well > > > I could also have created a separate function. > > > > > > In case a DPDK dev is used, those flags will be managed by DPDK. >

[ovs-dev] [PATCH] netdev-dpdk: include dpdk PCI header directly

2017-08-09 Thread Aaron Conole
As part of a devargs rework in DPDK, the PCI header file was removed, and needs to be directly included. This isn't required to build with 17.05 or earlier, but will be required should a future update happen. Signed-off-by: Aaron Conole --- lib/netdev-dpdk.c | 1 + 1 file

Re: [ovs-dev] [PATCH 1/2] ofproto-dpif-ipfix: Use common OVS functions for getting current time.

2017-08-09 Thread Ben Pfaff
On Mon, Aug 07, 2017 at 01:27:37PM -0700, Andy Zhou wrote: > On Mon, Jun 5, 2017 at 6:04 PM, Ben Pfaff wrote: > > OVS has common infrastructure functions for getting the current time, but > > this code was not using them. It is not clear why, so this commit changes > > it to use

Re: [ovs-dev] [PATCH v5 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

2017-08-09 Thread Numan Siddique
On Aug 10, 2017 12:06 AM, "Ben Pfaff" wrote: On Fri, Aug 04, 2017 at 04:09:58PM +0530, Numan Siddique wrote: > On Fri, Aug 4, 2017 at 3:02 AM, Ben Pfaff wrote: > > > On Mon, Jul 31, 2017 at 06:11:35PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Joe Stringer
On 9 August 2017 at 12:51, Aaron Conole wrote: > Darrell Ball writes: > >> Thanks Joe >> I forgot to add your Tested-by to V5; I have been testing this myself; >> but let me know if you would like it added – I can send a V6. > > It will automatically be

[ovs-dev] [PATCH] redhat: add vfio udev rules

2017-08-09 Thread Aaron Conole
This commit builds on the non-root ovs work and adds a udev rule which will automatically set the group permissions of vfio devices. Signed-off-by: Aaron Conole --- Systemd folks say that this is not something that should be a part of systemd, but should be part of

[ovs-dev] [PATCH 2/3] checkpatch: Fix matching on C filenames.

2017-08-09 Thread Joe Stringer
Most of the prerequisite checks so far matched on filenames that ended in some character followed by 'c' or 'h', rather than a filename that ends in '.c' or '.h'. Fix this. Signed-off-by: Joe Stringer --- utilities/checkpatch.py | 8 1 file changed, 4 insertions(+), 4

[ovs-dev] [PATCH 1/3] checkpatch: Check for infix operator whitespace.

2017-08-09 Thread Joe Stringer
The 'Expressions' section of the coding style specifies that one space should be on either side of infix binary and ternary operators. This adds a check to checkpatch.py for most of these. The regex won't match if there are speech marks on the line, because the style should not apply to the

Re: [ovs-dev] ovsdb-server replication: Possible to exclude syncing specific column of a table??

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 05:34:16PM +0530, Arunkumar Rg wrote: > Hi All, > > I need a clarification on ovsdb-server replication's > set-sync-exclude-tables. > > *Is there a way, by which we can say exclude syncing specific column of a > table??* > > The use case I'm looking at is: > >1. The

[ovs-dev] [PATCH v4 2/6] dpif-netdev: Add rxq processing cycle counters.

2017-08-09 Thread Kevin Traynor
Add two counters to dp_netdev_rxq which will be used for storing the processing cycles of an rxq. Processing cycles will be stored in reference to a defined interval. One counter is used for storing cycles during the current in progress interval, while the other is used to store the cycles of the

[ovs-dev] [PATCH v4 3/6] dpif-netdev: Count the rxq processing cycles for an rxq.

2017-08-09 Thread Kevin Traynor
Count the cycles used for processing an rxq during the pmd rxq interval. As this is an in flight counter and pmds run independently, also store the total cycles used during the last full interval. Signed-off-by: Kevin Traynor --- lib/dpif-netdev.c | 65

Re: [ovs-dev] [PATCH] ovn-northd: Add native active-standby HA.

2017-08-09 Thread Ben Pfaff
On Tue, Aug 01, 2017 at 12:19:18PM -0400, Russell Bryant wrote: > Add native support for active-standby HA in ovn-northd by having each > instance attempt to acquire an OVSDB lock. Only the instance of > ovn-northd that currently holds the lock will make active changes to > the OVN databases. >

[ovs-dev] [PATCH v4 4/6] dpif-netdev: Change rxq_scheduling to use rxq processing cycles.

2017-08-09 Thread Kevin Traynor
Previously rxqs were assigned to pmds by round robin in port/queue order. Now that we have the processing cycles used for existing rxqs, use that information to try and produced a better balanced distribution of rxqs across pmds. i.e. given multiple pmds, the rxqs which have consumed the largest

Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Darrell Ball
-Original Message- From: on behalf of Ben Pfaff Date: Wednesday, August 9, 2017 at 10:15 AM To: Darrell Ball Cc: "d...@openvswitch.org" Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL

[ovs-dev] [PATCH v4 5/6] dpif-netdev: Change pmd selection order.

2017-08-09 Thread Kevin Traynor
Up to his point rxqs are sorted by processing cycles they consumed and assigned to pmds in a round robin manner. Ian pointed out that on wrap around the most loaded pmd will be the next one to be assigned an additional rxq and that it would be better to reverse the pmd order when wraparound

[ovs-dev] [PATCH v4 6/6] dpif-netdev: Add ovs-appctl dpif-netdev/pmd-rxq-rebalance.

2017-08-09 Thread Kevin Traynor
Rxqs consumed processing cycles are used to improve the balance of how rxqs are assigned to pmds. Currently some reconfiguration is needed to perform a reassignment. Add an ovs-appctl command to perform a new assignment in order to balance based on the latest rxq processing cycle information.

Re: [ovs-dev] Why my AT_CHECK() can't work?

2017-08-09 Thread Ben Pfaff
On Wed, Aug 09, 2017 at 05:23:20PM +0800, Sam wrote: > Hi all, > > I'm using autotest to test ovs, and I write a new *.at file using only one > AT_CHECK sentence like this: > > AT_CHECK([ovs-appctl dpdk/bond-show dpdkb2], [0], [stdout]) > > AT_CHECK([[sed '/ACTIVE/p' stdout | head -4]], [0],

Re: [ovs-dev] [patch_v1] travis: Fix DPDK builds in new environment.

2017-08-09 Thread Ben Pfaff
On Tue, Aug 08, 2017 at 11:57:36PM -0700, Darrell Ball wrote: > The following error is seen: > 17.05.1/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:29: > /home/travis/build/darball/ovs/linux-3.16.46/arch/x86/include/asm/ > dma-mapping.h:32:35: error: inlining failed in call to

Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse build.

2017-08-09 Thread Lance Richardson
> From: "Ben Pfaff" > To: "Lance Richardson" > Cc: d...@openvswitch.org > Sent: Wednesday, August 9, 2017 4:47:49 PM > Subject: Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse > build. > > On Wed, Aug 09, 2017 at 04:36:42PM -0400, Lance

[ovs-dev] [PATCHv2 1/4] ovsdb-idl: Avoid class declaration.

2017-08-09 Thread Joe Stringer
In C++, 'class' is a keyword. If this is used as the name for a field, then C++ compilers can get confused about the context and fail to compile references to such fields. Rename the field to 'class_' to avoid this issue. Signed-off-by: Joe Stringer --- v2: Rebase. ---

[ovs-dev] [PATCHv2 2/4] ovsdb-idl: Avoid mutable type specifier.

2017-08-09 Thread Joe Stringer
In C++, 'mutable' is a keyword. If this is used as the name for a field, then C++ compilers can get confused about the context and fail to compile references to such fields. Rename the field to 'mutable_' to avoid this issue. Signed-off-by: Joe Stringer --- v2: Rebase. ---

Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on init.

2017-08-09 Thread Darrell Ball
-Original Message- From: Aaron Conole Date: Wednesday, August 9, 2017 at 12:51 PM To: Darrell Ball Cc: Joe Stringer , Darrell Ball , ovs dev Subject: Re: [ovs-dev] [patch_v4] dp-packet: Reset

[ovs-dev] [PATCHv2 3/4] ovsdb-idl: Avoid new expression.

2017-08-09 Thread Joe Stringer
In C++, 'new' is a keyword. If this is used as the name for a field, then C++ compilers can get confused about the context and fail to compile references to such fields. Rename the field to 'new_datum' to avoid this issue. Signed-off-by: Joe Stringer --- v2: Rebase. Rename

[ovs-dev] [PATCHv2 4/4] ovsdb-idl: Rename 'old' to 'old_datum'.

2017-08-09 Thread Joe Stringer
Now that the 'new' datum is named 'new_datum', be more consistent by renaming 'old' to 'old_datum' to match. Signed-off-by: Joe Stringer --- v2: New patch. --- lib/ovsdb-data.h | 4 +-- lib/ovsdb-idl-provider.h | 22 +++--- lib/ovsdb-idl.c | 74

[ovs-dev] [PATCHv2 0/4] Improve C++ support for OVSDB IDL.

2017-08-09 Thread Joe Stringer
In the OVSDB IDL, we use C++ keywords such as "new", "mutable", "class" for variable and field names. This series adds an underscore after each usage of these names, to improve the ability to use the IDL from C++ code. This series focuses primarily on code that exists in the tree; To address such

  1   2   >