Re: [ovs-dev] [PATCH 3/4] tc: Add header rewrite using tc pedit action

On 8 August 2017 at 07:21, Roi Dayan wrote: > From: Paul Blakey > > To be later used to implement ovs action set offloading. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > --- Hi Paul and folks, some

[ovs-dev] [PATCH] redhat: fix upgrades where group doesn't exist

The upgrade from older Open vSwitch versions on RHEL will try, as much as possible, to preserve the system. This means no new users or groups are created. As an effect, it's possible for the chown to fail, because the hugetlbfs group may not exist. While it did on my systems, it was not there

[ovs-dev] pwclient XML errors and form feeds

Earlier today on IRC I brought up an error I had while attempting to use pwclient to get a patch from patchwork. Here [1] is the pastebin I linked to. At the time, I thought it was due to HTTP chunked encoding being used and the xmlrpclib or HTTP client library not handling that properly. I

Re: [ovs-dev] OVS 2.9 Intel Roadmap

> > That is the one in flight now. > I guess there are no others being planned, then ? > Not from Intel that I am aware of. > > -Original Message- > From: "Stokes, Ian" > Date: Monday, August 14, 2017 at 2:56 AM > To: Jan Scheurich ,

[ovs-dev] [patch_v3 1/3] dpif-netdev: Fix per packet cycles statistics.

From: Ilya Maximets DP_STAT_LOOKUP_HIT statistics used mistakenly for calculation of total number of packets. This leads to completely wrong per packet cycles statistics. For example: emc hits:0 megaflow hits:253702308 avg. subtable lookups per

[ovs-dev] [patch_v3 0/3] dpif-netdev: Fix and refactor pmd stats.

Fix total pmd stats calculation, refactor pmd stats, enhance the pmd stats test and clarify pmd-stats-show output. Darrell Ball (2): dpif-netdev: Refactor some pmd stats. tests: Enhance the pmd stats test. Ilya Maximets (1): dpif-netdev: Fix per packet cycles statistics.

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

On Tue, Aug 15, 2017 at 12:09:14AM +0800, Eric Garver wrote: > On Thu, Aug 10, 2017 at 09:21:15PM +0800, Yi Yang wrote: > > Hi Yi, > > In general I'd like to echo Jiri's comments on the netlink attributes. > I'd like to see the metadata separate. > > I have a few other comments below. > >

Re: [ovs-dev] [PATCH 4/4] netdev-tc-offloads: Add support for action set

On 8 August 2017 at 07:21, Roi Dayan wrote: > From: Paul Blakey > > Implement support for offloading ovs action set using > tc header rewrite action. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > --- >

[ovs-dev] [PATCH 2/2] python: Force file system encoding on cmdline args

On Windows, the default file system encoding is 'mbcs' resulting in a bad conversion. To make it cross-platform tolerant use 'sys.getfilesystemencoding()' instead of 'utf-8'. Co-authored-by: Alin Serdean Signed-off-by: Alin Balutoiu

[ovs-dev] [PATCH 1/2] python: fix python3 encode/decode on Windows

Fix double encoding/decoding on data, caused by 'get_decoded_buffer' and 'get_encoded_buffer'. The functions 'get_decoded_buffer' and 'get_encoded_buffer' from winutils have been removed. They are no longer necessary since the buffers received/returned are already in the right form. The

Re: [ovs-dev] [patch_v2 2/3] dpif-netdev: Refactor some pmd stats.

-Original Message- From: Ilya Maximets Date: Monday, August 14, 2017 at 5:36 AM To: "ovs-dev@openvswitch.org" , Darrell Ball Cc: 'Jan Scheurich' , Antonio Fischetti

Re: [ovs-dev] [PATCH] datapath-windows: Update ICMP-Type and Code comparison in CT lookup

Hi Sai and Anand, Thanks a lot for the patch. I have a few questions regarding the approach. Please see inline. > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Anand Kumar > Sent: Friday, August 11, 2017 11:42 PM >

Re: [ovs-dev] [PATCH] datapath-windows: Do not modify port field for ICMP during SNAT/DNAT

We should revisit how we do hashes and compares over the 'OVS_CT_KEY' at some point. As you pointed "/* icmp_id and port overlap in the union */" You can drop the lines: > HASH_ADD(src.port); > HASH_ADD(dst.port); And > FIELD_COMPARE(src.port); > FIELD_COMPARE(dst.port); the

Re: [ovs-dev] OVS 2.9 Intel Roadmap

: RE: [ovs-dev] OVS 2.9 Intel Roadmap > > What about Billy's patch set for Rx queue prioritization? > https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336001.html > Jan > Good catch Jan, I missed that myself (Billy was out of office last week when putting the list together). I'll add

Re: [ovs-dev] [PATCH v3 4/4] dp-packet: Use memcpy on dp_packet elements.

Could you show some throughput results for a particular tests ? -Original Message- From: on behalf of "antonio.fische...@intel.com" Date: Friday, August 11, 2017 at 8:52 AM To: "d...@openvswitch.org"

Re: [ovs-dev] OVS 2.9 Intel Roadmap

> Any prioritization or other qos features missing ? > Hi Darrell, Do you mean the 2 qos patchsets on the list currently (support for queues and move qos in do_tx_copy?). If so, I didn’t include these in the list as Intel were not the authors. I do plan to provide feedback on them though but

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

On Mon, 14 Aug 2017 10:35:42 +, Jan Scheurich wrote: > Is it worth to speculate on how a hypothetical future NSH version > (with a different Version value in the Base header) might look like? Absolutely. This is uAPI we're talking about and once merged, it's set in stone. Whatever we come up

Re: [ovs-dev] OVS 2.9 Intel Roadmap

What about Billy's patch set for Rx queue prioritization? https://mail.openvswitch.org/pipermail/ovs-dev/2017-July/336001.html Jan > -Original Message- > From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev- > boun...@openvswitch.org] On Behalf Of Stokes, Ian > Sent: Monday, 14 August,

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

> From: Jiri Benc [mailto:jb...@redhat.com] > Sent: Monday, 14 August, 2017 09:51 > > On Sun, 13 Aug 2017 21:13:57 +, Jan Scheurich wrote: > > Jiri, I am not too familiar with conventions on the OVS netlink > > interface regarding the handling of variable length fields. What is > > the

Re: [ovs-dev] [PATCH 0/7] Add offload support for ip ttl and tcp flags

On Fri, Aug 11, 2017 at 11:43:23AM -0700, Joe Stringer wrote: > On 8 August 2017 at 01:03, Simon Horman wrote: > > On Mon, Aug 07, 2017 at 06:19:04PM +0300, Roi Dayan wrote: > >> Hi, > >> > >> This series adds support for offloading ip ttl and tcp flags > >> using tc

[ovs-dev] [PATCH v6 1/3] ovn util: Refactor dhcp_opts_map to make it generic

From: Numan Siddique Renamed 'struct dhcp_opts_map' to 'struct gen_opts_map' and renamed ovn-dhcp.h to ovn-l7.h. An upcoming commit to support IPv6 Router Advertisement, will make use of the refactored code to store the IPv6 ND RA options in 'struct gen_opts_map'.

[ovs-dev] [PATCH v6 2/3] ovn-controller: Add a new action - 'put_nd_ra_opts'

From: Numan Siddique This patch adds a new OVN action 'put_nd_ra_opts' to support native IPv6 Router Advertisement in OVN. This action can be used to respond to the IPv6 Router Solicitation requests. ovn-controller parses this action and adds a NXT_PACKET_IN2 OF flow with

Re: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC lookup/insert for recirc packets

-Original Message- From: on behalf of "antonio.fische...@intel.com" Date: Friday, August 11, 2017 at 8:52 AM To: "d...@openvswitch.org" Subject: [ovs-dev] [PATCH v3 1/4] dpif-netdev: Skip EMC

Re: [ovs-dev] [PATCH v3] route-table: Remove netdevs in netdev_hash when deleted

> -Original Message- > From: Tonghao Zhang [mailto:xiangxia.m@gmail.com] > Sent: Thursday, August 10, 2017 9:23 AM > To: fukaige > Cc: ovs dev > Subject: Re: [ovs-dev] [PATCH v3] route-table: Remove netdevs in netdev_hash > when deleted > > why not remove the function of

[ovs-dev] [PATCH v6 0/3] Add IPv6 Router Solicitation responder support

From: Numan Siddique v5 -> v6 Addressed review comments in p2. 'put_nd_ra_opts' action now encodes the ICMPv6 RA complete data in the 'userdata' field of the controller action. v4 -> v5 --- There were some unrelated changes which cropped in when rebasing in

Re: [ovs-dev] [PATCH] rhel: Add support for "systemctl reload openvswitch"

On 08/08/2017 11:01 PM, Timothy M. Redaelli wrote: > > The script is actually "specialized" to how Fedora/RHEL starts > openvswitch since, I think, only Fedora/RHEL have ovsdb-server and > ovs-vswitchd as splitted systemd unit files. For the record, SUSE uses the same approach > [...] > >

[ovs-dev] [PATCH v4] route-table: Remove netdevs in netdev_hash when deleted

From: Kaige Fu Start a virtual machine with its backend tap device attached to a brought up linux bridge. If we delete the linux bridge when vm is still running, we'll get the following error when trying to create a ovs bridge with the same name. The reason is that

Re: [ovs-dev] OVS 2.9 Intel Roadmap

Any prioritization or other qos features missing ? -Original Message- From: on behalf of "Stokes, Ian" Date: Friday, August 11, 2017 at 8:54 AM To: "ovs-dev@openvswitch.org" Subject: [ovs-dev] OVS 2.9

Re: [ovs-dev] [PATCH v3 3/4] conntrack: pass current time to conntrack_execute.

I did not try it yet, but seems reasonable -Original Message- From: on behalf of "antonio.fische...@intel.com" Date: Friday, August 11, 2017 at 8:52 AM To: "d...@openvswitch.org" Subject: [ovs-dev]

Re: [ovs-dev] [PATCH v3 2/4] dpif-netdev: Avoid reading RSS hash when EMC is disabled

I did not try it yet, but seems reasonable If the hash is needed for something else, it will be read at that point. -Original Message- From: on behalf of "antonio.fische...@intel.com" Date: Friday, August 11, 2017 at 8:52

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

On Sun, 13 Aug 2017 21:13:57 +, Jan Scheurich wrote: > Jiri, I am not too familiar with conventions on the OVS netlink > interface regarding the handling of variable length fields. What is > the benefit of structuring the push_nsh action into > > OVS_ACTION_ATTR_PUSH_NSH > +--

Re: [ovs-dev] [PATCH 0/4] Add offload support for action set

On Tue, Aug 08, 2017 at 05:21:50PM +0300, Roi Dayan wrote: > Hi, > > This series adds support for offloading action set using > tc interface. Other than some minor nits regarding the 3rd patch, which I posted in response to that patch, this series looks good to me. And this is a feature I am

Re: [ovs-dev] [PATCH RFC v3 4/4] dpif-netdev: Time based output batching.

On 14.08.2017 02:33, Jan Scheurich wrote: >> This allows to collect packets from more than one RX burst >> and send them together with a configurable maximum latency. >> >> 'other_config:output-max-latency' can be used to configure >> time that a packet can wait in output batch for sending. >> >>

[ovs-dev] [PATCH RFC 2/2] dpif-netdev: Use microseconds granularity for output-max-latency.

Signed-off-by: Ilya Maximets --- lib/dpif-netdev.c| 16 +--- vswitchd/vswitch.xml | 5 +++-- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index 0d78ae4..cf1591c 100644 --- a/lib/dpif-netdev.c +++

[ovs-dev] [PATCH RFC 1/2] timeval: Introduce time_usec().

This function will provide monotonic time in microseconds. Signed-off-by: Ilya Maximets --- lib/timeval.c | 22 ++ lib/timeval.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/lib/timeval.c b/lib/timeval.c index dd63f03..be2eddc 100644 ---

Re: [ovs-dev] [PATCH RFC v3 4/4] dpif-netdev: Time based output batching.

> >>From earlier in-house trials we know we need to target flush times of 50 > us or less, so we clearly need better time resolution. Sub-ms timing in PMD > should be based on TSC cycles, which are already kept in the pmd struct. > Could you provide a corresponding patch for performance testing? >

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

> From: Jiri Benc [mailto:jb...@redhat.com] > Sent: Monday, 14 August, 2017 12:48 > > On Mon, 14 Aug 2017 10:35:42 +, Jan Scheurich wrote: > > Is it worth to speculate on how a hypothetical future NSH version > > (with a different Version value in the Base header) might look like? > >

Re: [ovs-dev] [patch_v2 2/3] dpif-netdev: Refactor some pmd stats.

> The per packets stats are presently overlapping in that > miss stats include lost stats; make these stats non-overlapping > for clarity and make this clear in the dp_stat_type enum. This > also eliminates the need to increment two 'miss' stats for a > single packet. > > The subtable lookup

Re: [ovs-dev] [PATCH 3/4] tc: Add header rewrite using tc pedit action

On Tue, Aug 08, 2017 at 05:21:53PM +0300, Roi Dayan wrote: > From: Paul Blakey > > To be later used to implement ovs action set offloading. > > Signed-off-by: Paul Blakey > Reviewed-by: Roi Dayan > --- > lib/tc.c | 372 >

Re: [ovs-dev] [PATCH RFC v3 4/4] dpif-netdev: Time based output batching.

> > We have tested the effect of turbo mode on TSC and there is none. The > TSC frequency remains at the nominal clock speed, no matter if the core is > clocked down or up. So, I believe for PMD threads (where performance > matters) TSC would be an adequate and efficient clock. > > It's highly

Re: [ovs-dev] [PATCH RFC v3 4/4] dpif-netdev: Time based output batching.

On 14.08.2017 16:12, Jan Scheurich wrote: >>> >From earlier in-house trials we know we need to target flush times of 50 >> us or less, so we clearly need better time resolution. Sub-ms timing in PMD >> should be based on TSC cycles, which are already kept in the pmd struct. >> Could you provide a

Re: [ovs-dev] OVS 2.9 Intel Roadmap

That is the one in flight now. I guess there are no others being planned, then ? -Original Message- From: "Stokes, Ian" Date: Monday, August 14, 2017 at 2:56 AM To: Jan Scheurich , Darrell Ball ,

Re: [ovs-dev] [PATCH net-next v2] openvswitch: enable NSH support

On Thu, Aug 10, 2017 at 09:21:15PM +0800, Yi Yang wrote: > OVS master and 2.8 branch has merged NSH userspace > patch series, this patch is to enable NSH support > in kernel data path in order that OVS can support > NSH in 2.8 release in compat mode by porting this. > > Signed-off-by: Yi Yang